From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms1.migadu.com with LMTPS id MFNRK6H0KGbvPAAAe85BDQ:P1 (envelope-from ) for ; Wed, 24 Apr 2024 14:01:38 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2.migadu.com with LMTPS id MFNRK6H0KGbvPAAAe85BDQ (envelope-from ) for ; Wed, 24 Apr 2024 14:01:37 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=fabionatali.com header.s=gm1 header.b=Ws4EV7GO; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1713960097; h=from:from:sender:sender:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=xzS+Jft48Mbih3hWjFk0ikK7jT3VdIIAYZcSngEIjPY=; b=mYPC0byn37iz9Xlg8lHX3WUDZ11CAyy8HBV5B6taHTTwGwNK98v3YSsR4XFivTxoDbeByo BIYMJNYlP4nV/GPPpu4ge8CssyG4qM7Ll5BQEN+gTFnvzJg5l7yjYsglQ/eZnTQd2DW3dr DGr6yqTdtwuf7LnRhO6cVkTLWuMwbjh3q3bgLVDK+pjjifzuL42f9f9nq557rcgzEMw4jz gmx9VGREN3srE9yaDlb+vfNg0MFc6ywlssY9CFyi+BsbXthFqDy+vsrFL1NaBN1HA7uDpn 45MlC1ar6NI0B+l+JOZLAQlMYYp8GxJtc3Dfw6LS5/X23YwOzoWZwmwbrtN9TQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=fabionatali.com header.s=gm1 header.b=Ws4EV7GO; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1713960097; a=rsa-sha256; cv=none; b=uQBpp9NFTyq6L7R4BDqoCMFj3R1ogfBfeLBe8DWrFLrVZFNZO6EqkMlIMcoexBV8efbn1Z BUoEa3ZHZUwIrwNmikf0jJqYNdfQOVUYJ2D39ZmXdxHISy8HBgjpVgf7ChWL+sNiHrP0DR xDy9uI/z4KPcN9t2A2sFXHkSNNkNuR2EpJt2fJ/puzDCQg6icFvPGoHI68hFi++DE8G/d0 HiBG1Dz5vNcrt/AH5BdQEhkF8AVOwOtYA/rPwBwJ8f+tdJ2cW31BRfPYupV4QGDv3F4Xkl YGK3Xw/hJTZ5ox2fZHqKpDk6JPLa/1Kj6McnkNk0d44FODW56/gUrbHaaq7Z6w== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 63CFE624EB for ; Wed, 24 Apr 2024 14:01:37 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rzbJB-0004Xv-Ti; Wed, 24 Apr 2024 08:01:05 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rzbJ4-0004Ui-9j for guix-patches@gnu.org; Wed, 24 Apr 2024 08:01:00 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rzbJ3-0006q5-Uk for guix-patches@gnu.org; Wed, 24 Apr 2024 08:00:57 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rzbJJ-0005TJ-V5 for guix-patches@gnu.org; Wed, 24 Apr 2024 08:01:14 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#68289] [PATCH] services: xorg: Add xorg-start-command-xinit procedure. Resent-From: Fabio Natali Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Wed, 24 Apr 2024 12:01:13 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 68289 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Tomas Volf <~@wolfsden.cz> Cc: 68289@debbugs.gnu.org Received: via spool by 68289-submit@debbugs.gnu.org id=B68289.171396003920654 (code B ref 68289); Wed, 24 Apr 2024 12:01:13 +0000 Received: (at 68289) by debbugs.gnu.org; 24 Apr 2024 12:00:39 +0000 Received: from localhost ([127.0.0.1]:58086 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rzbId-0005MC-4m for submit@debbugs.gnu.org; Wed, 24 Apr 2024 08:00:37 -0400 Received: from relay2-d.mail.gandi.net ([2001:4b98:dc4:8::222]:53639) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rzbIR-0005IT-Tf for 68289@debbugs.gnu.org; Wed, 24 Apr 2024 08:00:26 -0400 Received: by mail.gandi.net (Postfix) with ESMTPSA id B9E7740004; Wed, 24 Apr 2024 11:59:55 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=fabionatali.com; s=gm1; t=1713959996; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xzS+Jft48Mbih3hWjFk0ikK7jT3VdIIAYZcSngEIjPY=; b=Ws4EV7GOTEwcMB36QyJEO/ztbSkSGUAGbbIky50jYL8DNjY8y5pfXyEbEnn0/zNwhydqGL b/XenGU0PIjCBVw7s7oVjcdzRxYuqiIEvuJCDKojHJZdYCXEDrwOVaFe2RQ2JmI1XCRXxc GFkmsw4auRRLo13Sq1u4zeA0Kxo2xUyma/wOOWkxGzwZSEV1VECd0uozcMXD0pKNGyKzeh dv1KixwNZhEv5ksyX5D+IbABI/0pH2GbIjvAsNKDgmP+asWGT2a4zQ3cfvTPWSRWRh/VfV ilf5CKGztuE8DmxDDBmCfgeL/0KPxX+WaNwvRVd7Psh/8CQat+ZM5zhdTxQX7A== In-Reply-To: <87zftpedyt.fsf@fabionatali.com> References: <87o7a9upoq.fsf@fabionatali.com> <87r0f4l4kb.fsf@fabionatali.com> <87zftpedyt.fsf@fabionatali.com> Date: Wed, 24 Apr 2024 12:59:55 +0100 Message-ID: <87le53nf7o.fsf@fabionatali.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-GND-Sasl: me@fabionatali.com X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-to: Fabio Natali X-ACL-Warn: , Fabio Natali via Guix-patches From: Fabio Natali via Guix-patches via Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -6.98 X-Migadu-Scanner: mx11.migadu.com X-Spam-Score: -6.98 X-Migadu-Queue-Id: 63CFE624EB X-TUID: j4n3sBmE4HyW On 2024-04-19, 13:25 +0100, Fabio Natali wrote: > On 2024-04-18, 23:09 +0200, Tomas Volf <~@wolfsden.cz> wrote: >> first, let me thank you for the review, and apologize for somewhat >> late response, sadly I have been busy. Hi Tomas, Sorry for the slow follow-up. After some further testing and some input from other Guix friends, this is my humble feedback on what I'd put in a v2 patch. - Use Guix's 'invoke' instead of a custom 'checked-system*' procedure. - Where possible, use '#$(file-append foobar "/bin/foo")' instead of '(string-append #$foobar "/bin/foo")', so that as much computation as possible happens at build time as opposed to run time. It's a microscopic difference, but still worth the change I think. What do you think? Not urgent, but do you think this is something you might be interested to include in a v2? No problem if you're busy, but let me know if there's anything I can help with. Tangentally, with regard to 'capture-stdout', I'm exploring if this is something that could be added to '(guix build utils)'=E2=81=B0 or perhaps addressed in Guile=C2=B9 instead of Guix. This can be left as it is in the patch, and potentially refactored away once a similar procedure is available from Guix or Guile. Thanks, best wishes, Fabio. =E2=81=B0 https://lists.gnu.org/archive/html/guix-devel/2024-04/msg00199.ht= ml =C2=B9 https://lists.gnu.org/archive/html/bug-guile/2024-04/msg00015.html --=20 Fabio Natali https://fabionatali.com