From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms1.migadu.com with LMTPS id +FbTKCRmKma91AAA62LTzQ:P1 (envelope-from ) for ; Thu, 25 Apr 2024 16:18:12 +0200 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id +FbTKCRmKma91AAA62LTzQ (envelope-from ) for ; Thu, 25 Apr 2024 16:18:12 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=detgxP5A; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1714054692; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=XJbiPDMxKrnliEc7udfauyYY857JDOtu4Uj7NsOmHSg=; b=XdRsdYx/nrW+icK1B9S9Jzz6zS1xGVXEd3EELo5EuUO0FFO6ORg4Of7jGeorouOzYOhrjJ UdvYNIxaXtOi3oNGRENxyziox8lJPRjfBWk+R7NtYIshc1dvERQwOPqRIw/HyhhlgmrPe3 4VWisnF4lMLWZYsSPqkVUTvN/9XhSXHXiOTMdcXzfGA8X9TdBbHq5hc4KPg7Ihh67wDdWq NeJNxPFYff7VwaAC1iUXV7+EI+fEKzjNphUVy+hH5Hu4QoMQDR/zOay2kVk3bmjgR6NwHM +wQFa8s6mmi5q/LQQZQySKMbWZxlpdgLRsBKWwqyNIBrKUtUyyGBmpYSjXnsgQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=fail ("headers rsa verify failed") header.d=gmail.com header.s=20230601 header.b=detgxP5A; dmarc=fail reason="SPF not aligned (relaxed)" header.from=gmail.com (policy=none); spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1714054692; a=rsa-sha256; cv=none; b=mV3blvmYy+n3+wjQxzFyaYNSV4zzmE3dzY70gJetO6iBa3DLOG6CtgsczfCmnavbQRYr1B 0AnrjhmD4toYebI8PRHcY/8bdb55S0K/++As3pJKLn0AHcm8PJY8WLHkrTk2QY3ZWOh7kb wjR/ovhwI5DwK5eJVf2dfImlvZA1t3c1x0rLq/Xp/fEXtgjw4WMI3Xttdoly7VJ8zZweiP FppWw2gXjngAMPUVHQ2jvjfMunOl5kUAMNHQrUJHZWQUMf4khb1I5/xzCDd9Dt8SAdumLY nc7krzZaDp/PBvSGWUjpN3nt5o/UqL1Spdg93mVLNCJdmtXIpil764kb9qTeTg== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 42ED462181 for ; Thu, 25 Apr 2024 16:18:12 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1rzzv9-0007AG-KL; Thu, 25 Apr 2024 10:17:55 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1rzzv8-00079d-8u for guix-patches@gnu.org; Thu, 25 Apr 2024 10:17:54 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1rzzv8-0001hL-01 for guix-patches@gnu.org; Thu, 25 Apr 2024 10:17:54 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1rzzvP-0006MU-99 for guix-patches@gnu.org; Thu, 25 Apr 2024 10:18:11 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#70317] [PATCH 00/13] Add soju References: <20240409204806.12347-1-jesse@eisses.email> In-Reply-To: <20240409204806.12347-1-jesse@eisses.email> Resent-From: Sharlatan Hellseher Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 25 Apr 2024 14:18:10 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 70317 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: 70317@debbugs.gnu.org Cc: jesse@eisses.email Received: via spool by 70317-submit@debbugs.gnu.org id=B70317.171405465524032 (code B ref 70317); Thu, 25 Apr 2024 14:18:10 +0000 Received: (at 70317) by debbugs.gnu.org; 25 Apr 2024 14:17:35 +0000 Received: from localhost ([127.0.0.1]:60848 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rzzun-0006FG-Be for submit@debbugs.gnu.org; Thu, 25 Apr 2024 10:17:35 -0400 Received: from mail-wm1-x32f.google.com ([2a00:1450:4864:20::32f]:52608) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1rzzue-0006D7-KQ for 70317@debbugs.gnu.org; Thu, 25 Apr 2024 10:17:30 -0400 Received: by mail-wm1-x32f.google.com with SMTP id 5b1f17b1804b1-41b498ed12dso6268995e9.1 for <70317@debbugs.gnu.org>; Thu, 25 Apr 2024 07:17:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1714054621; x=1714659421; darn=debbugs.gnu.org; h=mime-version:message-id:date:subject:cc:to:from:from:to:cc:subject :date:message-id:reply-to; bh=XJbiPDMxKrnliEc7udfauyYY857JDOtu4Uj7NsOmHSg=; b=detgxP5AHHh+I0mbvJfpsGuBcImjDLykZkxauCCK/pOlBtm6y0S5IRsqfD3fNjzGwb GgYba42TQVN7VkAFNZAkcikxa4LpojBeDA33QtSnTeWwNj4rsX65kMHljGwutGSVcawn SENqG4n5ulwqBPS/LZPzjG5NlpZ1P2lut6RlVGYeT40aRnFe6PX7zZStmfoOraXC+1lq 7hUQPk7ttSZ5r2iI7fsuE7vvYqhO1WkjcyR5wLFRDSVwX7M646PELcu6pxhNXjuQ4FMX tvIbqbxDyfMYmHSg7tlHNRO+cG2Ec8p2mT5SPPZxvxYkW7XqJxXAtirJuO+zc7jereS0 cmow== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1714054621; x=1714659421; h=mime-version:message-id:date:subject:cc:to:from:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=XJbiPDMxKrnliEc7udfauyYY857JDOtu4Uj7NsOmHSg=; b=fvffL37gKt7MzqO5QIVuriKb3SORVH7cq6ZYwIg8+59EVMOymS+bjE5qfxWgsG0x1B Bs7I8yovB/FvZnmP8TCFsfjvlC/WCPKbHhg4a49DZlqaN0TIdipMyXq+2JhLMLrj0eo3 4hTnTSVmfhz96ZTPcNxU6NuOmazTwhxtBw18KQbKVX0DXobqNIhM5ARWgfmyOy/1cm0N 7s1jXv6FmeHh9zXHqYLnWhscoWbSvzYQ6lf30ig+88QDUQiV+ZHrxqkXhqPm1s5tAWsb 7NfEX/ITDBc8nPseAi7jBXEf4qz5VOg80+AcMt4BymRPhAkDCjsfgu/f+qLJEVerAcMj j3Vw== X-Gm-Message-State: AOJu0Yy/BMPocsACgBUNUU4ICCLaQuh/+EfKarYqeMXScDqBafQSVfY6 IVJOO16L0KtB/mBUaXQ5viIRQT8SkOI0z02f2tDdCwL7Svgcs4sTp8C9SfLM X-Google-Smtp-Source: AGHT+IFCaVCifD9CvLi5aFqw9fZregv2ewBQ5j7ZLn2BaOZ02wV6lQ2vxMjctDIiZWIzF223IDj2Kw== X-Received: by 2002:a05:600c:3503:b0:417:f527:21d0 with SMTP id h3-20020a05600c350300b00417f52721d0mr5272504wmq.0.1714054620473; Thu, 25 Apr 2024 07:17:00 -0700 (PDT) Received: from guxtil (cpc100856-bagu15-2-0-cust368.1-3.cable.virginm.net. [82.25.93.113]) by smtp.gmail.com with ESMTPSA id l37-20020a05600c1d2500b004186f979543sm31749063wms.33.2024.04.25.07.16.59 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 25 Apr 2024 07:16:59 -0700 (PDT) From: Sharlatan Hellseher Date: Thu, 25 Apr 2024 15:16:50 +0100 Message-ID: <87le511q99.fsf@gmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Flow: FLOW_IN X-Migadu-Country: US X-Migadu-Spam-Score: -6.89 X-Migadu-Scanner: mx11.migadu.com X-Spam-Score: -6.89 X-Migadu-Queue-Id: 42ED462181 X-TUID: JP0oH6ZkSQjD --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi Jesse, Thank you for the patches. From=20the first review round it looks like QA is not happy with some git conflicts while applying the patches. I've checked the general styling and some of the packages have lables, some not, some use list style some not, let's still to one style across all of the. WDYT? Some review point for v2: =2D rebase to master, fix git conflict =2D do not use input labels e.g. from =2D-8<---------------cut here---------------start------------->8--- + (inputs `(("linux-pam" ,linux-pam))) =2D-8<---------------cut here---------------end--------------->8--- to =2D-8<---------------cut here---------------start------------->8--- + (inputs (list linux-pam)) =2D-8<---------------cut here---------------end--------------->8--- =2D use list style everywhere in arguments e.g. from =2D-8<---------------cut here---------------start------------->8--- + (arguments + `(#:go ,go-1.18 + #:import-path "git.sr.ht/~emersion/go-sqlite3-fts5" =2D-8<---------------cut here---------------end--------------->8--- to =2D-8<---------------cut here---------------start------------->8--- + (arguments + (list + #:go ,go-1.18 + #:import-path "git.sr.ht/~emersion/go-sqlite3-fts5" =2D-8<---------------cut here---------------end--------------->8--- =2D check import-path, it should be the same as may see in go.mod from=20 =2D-8<---------------cut here---------------start------------->8--- + #:import-path "github.com/golang-jwt/jwt")))) =2D-8<---------------cut here---------------end--------------->8--- to =2D-8<---------------cut here---------------start------------->8--- + #:import-path "github.com/golang-jwt/jwt/v4")))) =2D-8<---------------cut here---------------end--------------->8--- https://github.com/golang-jwt/jwt/blob/v4.5.0/go.mod If the module name does not contain "v" try to update existing package in Guix. =2D description of the package needs to be more informative and longer than synopsis =2D-8<---------------cut here---------------start------------->8--- + (synopsis "Standalone FTS5 extension for go-sqlite3") + (description "Standalone FTS5 extension for +@@url{https://github.com/mattn/go-sqlite3,go-sqlite3}.") =2D-8<---------------cut here---------------end--------------->8--- =2D explain why tests are disabled =2D-8<---------------cut here---------------start------------->8--- + (arguments + (list + #:tests? #f + #:import-path "gopkg.in/irc.v4" + #:unpack-path "gopkg.in/irc.v4")) =2D-8<---------------cut here---------------end--------------->8--- =2D according to the description, soju may be placed in (gnu packages irc) =2D-8<---------------cut here---------------start------------->8--- + (synopsis "User-friendly IRC bouncer") ; =2D-8<---------------cut here---------------end--------------->8--- =2D try to apply G-expression which may simplify the package a lot (se examples in golang-* modules) =2D-8<---------------cut here---------------start------------->8--- + #:phases (modify-phases %standard-phases + (replace 'build + (lambda* (#:key outputs #:allow-other-keys) + (with-directory-excursion "src/git.sr.ht/~emersion/s= oju" + (setenv "SYSCONFDIR" + (string-append (assoc-ref outputs "out") + "/etc")) + (invoke "make")))) =2D-8<---------------cut here---------------end--------------->8--- Looking forward for v2! =2D- Oleg --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEmEeB3micIcJkGAhndtcnv/Ys0rUFAmYqZdIACgkQdtcnv/Ys 0rXdwhAAn098Eqz+KtZHElzIrX+7UgUcLlN7LZf1oJyyz+6hHxC3NL1jedvyU+25 Ttpu3iA8Yfc6ZWON0T4+CxMttfFEh0e/gBkp78sySSCQM3/c9zeuzFDS8as4IeBM BeYYU8UD9dlG3uWh8in6NszDnTOC6FDKx0mGzeHebX+xj06kBuoCfykTIn9SIjB1 dU3e+XGX2ORXMmwRXBukImbw4qAZqc2OY/1gMB/fl0X9b67xOXmouGBIRMaMC9Pp EBRXMYzvRdPLHKARmOsQW+5jYHKbbR60NMUtu269S8eMzJ2t3dEwvBwcmrSxiBiR fnwjfpT2JEnBg5ESnWZn3kGc+y++B76Uzqe1Cip8cbEYloM8qnGClHZtku6fm9V7 8bbPxJAiyjO3P0WOuF7TTGVwdB4x99kmFfgBoOmUeygzc+DGsMkHAsdnKty9edGm aSKYOR8KqN2hQBA3VgASP6qO3gEsENB59RnDf0yK65a27zMHWFyVGaFYdRGkOkEr NxRPdeQJG4dL6QUtL3W9Dcccktx12FWDMK7M9yhfGVPd/QPccwafSed8cj6W8Wo+ SpW1iquA5Q+8ooxQ337wAdR2d9XJhXlAMNyaI0tIrz4R0db0dDpNHYQ3mQYpADlh vuyFczNN9vM1a8UnbYLWHQSFGYibokTHW9FTIWDxV4z6Ioqgxps= =MNd4 -----END PGP SIGNATURE----- --=-=-=--