From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id +Et4NH2wCmcFYQEA62LTzQ:P1 (envelope-from ) for ; Sat, 12 Oct 2024 17:23:10 +0000 Received: from aspmx1.migadu.com ([2001:41d0:403:4876::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id +Et4NH2wCmcFYQEA62LTzQ (envelope-from ) for ; Sat, 12 Oct 2024 19:23:09 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=E0t8CEJl; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=V5dTCEvZ; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Seal: i=1; s=key1; d=yhetil.org; t=1728753789; a=rsa-sha256; cv=none; b=DiJKuMVD6Nsf7HCPj44qX6zjlQePBuhMyBpsfySsQ0lLU7sbfWbJtYAjyggz0fG8XGsrSh SHoil43De87YsyCbQfAJ2jNAQ7Ha/4pwhqoVAyk8E6/o8+OASPEAFDTW/UUfkxY2FBtmlH qPlKA/O8NdCNpIy1QrTJIZi2g4znEDvJzxDSfGsP+HhZIPYNiY0LR6mJ0Ordt/elnq0C9w Fummo+CrRmx7BjVxF/hpd43w6lkH+luDg5qLjLQ0G6B1uNSnmPcfmjBIt0R/MAUc2eij23 ZODh0hP+Gf+ryM2b2QjQJBrMDo2hsXlKJgd3Od+NUSu1qsAo8FP82aeN7lCw1A== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b=E0t8CEJl; dkim=fail ("headers rsa verify failed") header.d=gnu.org header.s=fencepost-gnu-org header.b=V5dTCEvZ; dmarc=pass (policy=none) header.from=gnu.org; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org" ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1728753789; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding:resent-cc: resent-from:resent-sender:resent-message-id:in-reply-to:in-reply-to: references:references:list-id:list-help:list-unsubscribe: list-subscribe:list-post:dkim-signature; bh=zpMelJjyS4pPUecy3Jly+aBJVEj8Z89rwzLHJfTXIkk=; b=V+ImKm9cuI7M4JSJMGiLTvO2z9tDsucs3HSEUsuQUjtLMftdC+SRTq1wpwf545utUR6J1e 6EYTUcOY3sTAlbJNjxHhsBPG8HBpv1tMSuPC/vqC5irpejDBzgGooFfx6mdSRKx6jDy5Kb KvGIyECvd9DnAGpWgsy1XtzLt7xfY+b0aTHrGXiOCIpz6+MwIO1JeeX5kF/zj7pGERVcL4 qws7JwR2x0QMNly0OrABoaxeF607xENuuAiQED0C2W8L7kvWsTMJ4q7psdL0zLy9sfgbhp 59xW125lzBLPbOSmL9MIIrzlQ5MKZBnLCcheMqoJvkgeaK5U1FrgyDTa+0vn5Q== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 3B96D1BBA5 for ; Sat, 12 Oct 2024 19:23:08 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1szfpJ-0005Hj-OR; Sat, 12 Oct 2024 13:22:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1szfpI-0005HX-8m for guix-patches@gnu.org; Sat, 12 Oct 2024 13:22:48 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1szfpH-0007hE-VP for guix-patches@gnu.org; Sat, 12 Oct 2024 13:22:48 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=zpMelJjyS4pPUecy3Jly+aBJVEj8Z89rwzLHJfTXIkk=; b=E0t8CEJlHiKM4SI+7KVouUnpC7w+8NjjiuK7SMS4QGR9+yBIfVaBqNu/ogTJQh/Xy/Djl3XGtgTUXo++p1eERbjpMo3v9aL0n83899GZcKcExmpmPkkSo/BTkAlXuNKTTsb+b6+CgMiguQagh6oi5O2qQDLKud84aueQJ/WWTdFtD1SmH8Xgd55D1HN7VEfxryb7Cqd0IfKSUlfcWzGOfC3coXmnPIEo7GZrjnWOcR22FWp2ztJiWc07UI6owqpN4ycPDrTGBdr0LjRHZn5igMe9suu+RSG/gC2lW0MnI+tyDMe2o5oF9AuhkXfZSlp2u64psYNotiLyXaHnDXn0QQ==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1szfpV-00065w-Pb for guix-patches@gnu.org; Sat, 12 Oct 2024 13:23:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#72925] Adding JPM package for Janet Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 12 Oct 2024 17:23:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72925 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Suhail Singh Cc: Sharlatan Hellseher , 72925@debbugs.gnu.org, Munyoki Kilyungi , Katherine Cox-Buday , Guillaume Le Vaillant , jgart Received: via spool by 72925-submit@debbugs.gnu.org id=B72925.172875374723384 (code B ref 72925); Sat, 12 Oct 2024 17:23:01 +0000 Received: (at 72925) by debbugs.gnu.org; 12 Oct 2024 17:22:27 +0000 Received: from localhost ([127.0.0.1]:53559 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1szfow-000655-Sd for submit@debbugs.gnu.org; Sat, 12 Oct 2024 13:22:27 -0400 Received: from eggs.gnu.org ([209.51.188.92]:47732) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1szfou-00064q-NC for 72925@debbugs.gnu.org; Sat, 12 Oct 2024 13:22:25 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1szfoa-0007fs-3m; Sat, 12 Oct 2024 13:22:04 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=gnu.org; s=fencepost-gnu-org; h=MIME-Version:Date:References:In-Reply-To:Subject:To: From; bh=zpMelJjyS4pPUecy3Jly+aBJVEj8Z89rwzLHJfTXIkk=; b=V5dTCEvZ9la2sJ/Bm29z yB77j9e8UH+mCq/bPw0BrRwsgw/Zcp9v3vWqPXbymE0Zj0l1QPts8tMjO7Bhpwu2pWS4iLSUSSBH8 Hfxy1jFM7SMrXsYDlbO5NAIDgPsSeVNi6udJa1W6uOu+KKBmK4izDiwlxtY1pPiOMonvUCzAk2Lzc ap0sI27BGRJIeADj120LPI8UtoWr9Rg3FVdvIp13nuSMY+H5PkaYv0NDvxu/clDD7HS30GOsjuwFO XnVdIm8d7mFF0i4JZBtOwSWFioujSdDhQ3npNP8VW2H1L6FkLi4179/K/I39031RVTOBBUXaj9w8/ xMO/ZW2EGDYJKA==; From: Ludovic =?UTF-8?Q?Court=C3=A8s?= In-Reply-To: <4665e2a478a63cf0bc6b8a18a2fb44687298bbd7.1728359428.git.suhail@bayesians.ca> (Suhail Singh's message of "Tue, 08 Oct 2024 00:16:54 -0400") References: <4665e2a478a63cf0bc6b8a18a2fb44687298bbd7.1728359428.git.suhail@bayesians.ca> Date: Sat, 12 Oct 2024 19:22:01 +0200 Message-ID: <87ldyts0cm.fsf_-_@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Spam-Score: -2.35 X-Spam-Score: -2.35 X-Migadu-Queue-Id: 3B96D1BBA5 X-Migadu-Scanner: mx10.migadu.com X-TUID: ORqMeiu4RZGn Suhail Singh skribis: > * gnu/packages/lisp.scm (jpm): Ensure jpm respects JANET_HEADERPATH and > JANET_LIBPATH if set by user. Ensure gcc/g++ is able to find header file= s and > compilation-related utilities. > > Change-Id: Ic7218dbd10e6fabddded50894b82492de8cabc88 [...] > + (wrap-program (string-append #$output "/bin/jpm= ") > + `("JANET_HEADERPATH" ":" prefix > + (,(string-append #$janet "/include/janet"))) > + `("JANET_LIBPATH" ":" prefix > + (,(string-append #$janet "/lib"))) > + `("C_INCLUDE_PATH" ":" prefix > + (,(string-append gcc-toolchain "/include"))) > + `("CPLUS_INCLUDE_PATH" ":" prefix > + (,(string-append gcc-toolchain "/include/c+= +") > + ,(string-append gcc-toolchain "/include"))) > + `("LIBRARY_PATH" ":" prefix > + (,(string-append gcc-toolchain "/lib") > + ,(string-append gcc-toolchain "/lib64"))) > + `("PATH" ":" prefix > + (,(string-append gcc-toolchain "/bin") > + ,(string-append #$coreutils "/bin"))))))))= )) > + (inputs (list bash-minimal > + ;; Lazily resolve the gcc-toolchain to avoid a circular > + ;; dependency. > + (module-ref (resolve-interface '(gnu packages commence= ment)) > + 'gcc-toolchain))) I suppose JPM shells out to GCC to compiler Janet (or C?) code, right? I=E2=80=99d recommend adding =E2=80=98gcc=E2=80=99, =E2=80=98glibc=E2=80=99= , =E2=80=98binutils=E2=80=99, and =E2=80=98ld-wrapper=E2=80=99 to =E2=80=98inputs=E2=80=99; that=E2=80=99d less us avoid the =E2=80=98gcc-too= lchain=E2=80=99 dance. Then in, the phase above, make sure to =E2=80=98search-input-file=E2=80=99 = rather than direct references to these variables. How does that sound? Alternatively, depending on how important this is for JPM, you could also leave it up to users to install =E2=80=98gcc-toolchain=E2=80=99 alongs= ide JPM when they need it. Thanks, Ludo=E2=80=99.