From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms13.migadu.com with LMTPS id eEAJEZD2Dme/FQEA62LTzQ:P1 (envelope-from ) for ; Tue, 15 Oct 2024 23:11:12 +0000 Received: from aspmx1.migadu.com ([2001:41d0:403:58f0::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1.migadu.com with LMTPS id eEAJEZD2Dme/FQEA62LTzQ (envelope-from ) for ; Wed, 16 Oct 2024 01:11:12 +0200 X-Envelope-To: larch@yhetil.org Authentication-Results: aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b="LzSqe/sH"; dkim=fail ("headers rsa verify failed") header.d=systemreboot.net header.s=default header.b=ab6Cua45; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=systemreboot.net (policy=none) ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=yhetil.org; s=key1; t=1729033872; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type:resent-cc:resent-from:resent-sender: resent-message-id:in-reply-to:in-reply-to:references:references: list-id:list-help:list-unsubscribe:list-subscribe:list-post: dkim-signature; bh=L3dALznpRyeSCFw5s2IvWtErGfgTih2C668rjwWDrvU=; b=Ht4TRJrjL4INOO7EhzflHBmPdo3hTL7zSSr2e4lGoJMobHUfQTaxodrORYCw+E1vE12Z0F NeS9Pt2SewnRw8N/gtbAP5oADQjKKZY4DJ9c1EcQGB44I7ckwzV0C1FirOCYmMrr+Uh4rp ZwHvNXOnBamcAMZllZrhUj5sc4eyaMFG+E63tGPjQGHJANIWK72WG2YJ/NnbFDz38qr7id lYxdbIaN9ZQWTGCbUK8SECvnmovhTVBlpIuiWOI+1e5D0hffyjqOhsNH8vPxR1iskujCoG /44LhStZUoVSc3Kmq27BZTQsm59hBlc5M/9UdUff9vuXEwwxMIQVlmvs6/Z0SQ== ARC-Authentication-Results: i=1; aspmx1.migadu.com; dkim=pass header.d=debbugs.gnu.org header.s=debbugs-gnu-org header.b="LzSqe/sH"; dkim=fail ("headers rsa verify failed") header.d=systemreboot.net header.s=default header.b=ab6Cua45; spf=pass (aspmx1.migadu.com: domain of "guix-patches-bounces+larch=yhetil.org@gnu.org" designates 209.51.188.17 as permitted sender) smtp.mailfrom="guix-patches-bounces+larch=yhetil.org@gnu.org"; dmarc=fail reason="SPF not aligned (relaxed), DKIM not aligned (relaxed)" header.from=systemreboot.net (policy=none) ARC-Seal: i=1; s=key1; d=yhetil.org; t=1729033872; a=rsa-sha256; cv=none; b=hj+Z0UUPLn1EkEiMI0P5CAz/f9RSxcIvj7q2VaoeNhMvoAczR7lScKzLl0S3uGToHKpo1z 2BQUIdEfx6XaQCsFV7UHbD1dHmdLsXNz+NqNbvFDkY1QCnOmLGCOeYzyLV8VP/zxavOj0E d3nZ9T1ua0piFrRv6Cfb8zL1ZNkSiA69uIqnqBE9/Euqt/zddIedeZ1QC5CB88PmtuyXSf /OxKmTf8cQdVCd6MCEnyU1i9thWJL9W4gG/HWc27lnlJvXzG3/FGoBidjY72/Luz+VZh7W DdcXIuqwIbjXKGg1lHTVONEczTU8dYo5lNYftzrG0HFctpu6TwYFY7HUTJimYA== Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 26D0640D43 for ; Wed, 16 Oct 2024 01:11:10 +0200 (CEST) Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1t0oHd-0000gw-HP; Tue, 15 Oct 2024 16:36:46 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1t0oHb-0000dv-UH for guix-patches@gnu.org; Tue, 15 Oct 2024 16:36:43 -0400 Received: from debbugs.gnu.org ([2001:470:142:5::43]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1t0oHb-0003VO-If for guix-patches@gnu.org; Tue, 15 Oct 2024 16:36:43 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=debbugs.gnu.org; s=debbugs-gnu-org; h=MIME-Version:Date:References:In-Reply-To:From:To:Subject; bh=L3dALznpRyeSCFw5s2IvWtErGfgTih2C668rjwWDrvU=; b=LzSqe/sH/lMZF86cgvkhwqekc7OUVVCTit2kxazgbVQvciNBLLn7J9RFf9XCqkvB6NHohOJsQ6YHDho5GqTk9FQBc5YUJykVCKMEmyLj6XIc4FWAHhMlvdwhcBeAsgiA5s0kYYID4t2IoEPBxQQEDTqT0Yw/PVtqyqpsdb6gNn/Njm+601EoT2s7S7OuxMoYTeDouiSNse1oZEUNk+FtRoHueLaARtLX1xjairA5C4RIuCeyJeMxAHs2jBqsJ8trkQ440fuenvMuqCk1UM9a7+utVj99D175dWWEi7HmroH8aBv3/tiikdk6stEwrrDVjVpJhUHjd7qCHtm1GnsuBw==; Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1t0oHu-0000dj-4a for guix-patches@gnu.org; Tue, 15 Oct 2024 16:37:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#72398] [PATCH v7] services: Add readymedia-service-type. Resent-From: Arun Isaac Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Tue, 15 Oct 2024 20:37:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 72398 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Fabio Natali , 72398@debbugs.gnu.org Cc: ludo@gnu.org, mirai@makinata.eu, Fabio Natali Received: via spool by 72398-submit@debbugs.gnu.org id=B72398.17290246192444 (code B ref 72398); Tue, 15 Oct 2024 20:37:02 +0000 Received: (at 72398) by debbugs.gnu.org; 15 Oct 2024 20:36:59 +0000 Received: from localhost ([127.0.0.1]:57663 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t0oHr-0000dM-JN for submit@debbugs.gnu.org; Tue, 15 Oct 2024 16:36:59 -0400 Received: from mugam.systemreboot.net ([139.59.75.54]:40874) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1t0oHn-0000d6-Ko for 72398@debbugs.gnu.org; Tue, 15 Oct 2024 16:36:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=systemreboot.net; s=default; h=Content-Type:MIME-Version:Message-ID:Date: References:In-Reply-To:Subject:Cc:To:From:Sender:Reply-To: Content-Transfer-Encoding:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id: List-Help:List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=L3dALznpRyeSCFw5s2IvWtErGfgTih2C668rjwWDrvU=; b=ab6Cua45bTr3Z/Zn8KS7kBj2dO 9148JB3IUhFjSzmh9MBQpLAhV7s0DkbcAf9Pdkqa0QkBWirVf+JHU/GlZk5G4Vu5zPerRJVBiRAwW Jc9wKZ3OJtXNrEHXulCOjcEMcyPQY4GyaE1qd1coY5LHsUVv4WajOvY5RvINPvXuOB9v7pG0H4oL8 GTaHufgyxs+GvNbBhx0DBgqwUm+9daGLoiX07dvvrWCihN4ZopxVuFaBqXpWjhQ8YODDoJqf57pGj sxQVjIPd68uH/9Y7l8Wk+QLHb9PBHkrRcy+wZL1+Y5WuzlnkzmJDTBQ29n5YvL/e1mMBsoYVSfXxz ePxIPW8A==; Received: from [192.168.2.1] (port=60958 helo=localhost) by systemreboot.net with esmtpsa (TLS1.3) tls TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384 (Exim 4.98) (envelope-from ) id 1t0oBZ-000000005S9-3Kdv; Tue, 15 Oct 2024 21:30:30 +0100 From: Arun Isaac In-Reply-To: <5259d0a6ad45dd789f677bd2daf1dc05c0424738.1729005784.git.me@fabionatali.com> References: <5259d0a6ad45dd789f677bd2daf1dc05c0424738.1729005784.git.me@fabionatali.com> Date: Tue, 15 Oct 2024 21:36:20 +0100 Message-ID: <87ldypp0hn.fsf@systemreboot.net> MIME-Version: 1.0 Content-Type: text/plain X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: guix-patches-bounces+larch=yhetil.org@gnu.org X-Migadu-Country: US X-Migadu-Flow: FLOW_IN X-Migadu-Scanner: mx11.migadu.com X-Migadu-Spam-Score: 3.15 X-Spam-Score: 3.15 X-Migadu-Queue-Id: 26D0640D43 X-TUID: jZFDPKJzYae0 Hi Fabio, > Are you sure you used v6 of the patch? Yep, I applied `mumi am -- -s'. > Could you please try v7 on a recent checkout and see if the above > works? I applied v7 and the cache file related tests failed. > + (test-assert "cache file exists" > + (marionette-eval > + '(begin > + ;; Allow some time for the file to be created. > + (sleep 2) > + (file-exists? #$%readymedia-cache-path)) > + marionette)) I found that the cache file related tests passed when increasing the sleep time. That's probably because my machine is just slower. This makes this test rather fragile. I say we remove these cache file related tests. It's also not important to test these things, because our goal isn't really to test the readymedia software package itself. WDYT? You don't have to provide a v8 patch. I'll make the change myself. I'd just like the green light from you. Thanks, Arun