unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
* [bug#74464] [PATCH] gnu: buildah: Update to 1.38.0.
@ 2024-11-21 14:08 Tomas Volf
  2024-11-23 21:24 ` [bug#74464] QA review for 74464 Aaron Covrig via Guix-patches via
  2024-11-24  1:12 ` bug#74464: [PATCH] gnu: buildah: Update to 1.38.0 Z572
  0 siblings, 2 replies; 5+ messages in thread
From: Tomas Volf @ 2024-11-21 14:08 UTC (permalink / raw)
  To: 74464; +Cc: Tomas Volf

* gnu/packages/containers.scm (buildah): Update to 1.38.0.
<native-inputs>: Use go-1.22.

Change-Id: I4a36345f91fde84fdbf5b4ef4cd5dc2749c90327
---
 gnu/packages/containers.scm | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/gnu/packages/containers.scm b/gnu/packages/containers.scm
index adae2f5bfc..c883592be6 100644
--- a/gnu/packages/containers.scm
+++ b/gnu/packages/containers.scm
@@ -606,7 +606,7 @@ (define-public podman-compose
 (define-public buildah
   (package
     (name "buildah")
-    (version "1.37.5")
+    (version "1.38.0")
     (source
      (origin
        (method git-fetch)
@@ -614,7 +614,7 @@ (define-public buildah
              (url "https://github.com/containers/buildah")
              (commit (string-append "v" version))))
        (sha256
-        (base32 "0m15pizivwwq2cnmsyhsz5h8zblcvpy06lj82vypg358spq3y0l4"))
+        (base32 "1lnl5v8d5p4g0rm4d90rw4hdh066w7v8r9g1h0v1z533mbgxgry8"))
        (file-name (git-file-name name version))))
     (build-system gnu-build-system)
     (arguments
@@ -684,7 +684,7 @@ (define-public buildah
                   lvm2))
     (native-inputs
      (list bats
-           go-1.21
+           go-1.22
            go-github-com-go-md2man
            pkg-config))
     (synopsis "Build @acronym{OCI, Open Container Initiative} images")
-- 
2.46.0





^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [bug#74464] QA review for 74464
  2024-11-21 14:08 [bug#74464] [PATCH] gnu: buildah: Update to 1.38.0 Tomas Volf
@ 2024-11-23 21:24 ` Aaron Covrig via Guix-patches via
  2024-11-24  1:12 ` bug#74464: [PATCH] gnu: buildah: Update to 1.38.0 Z572
  1 sibling, 0 replies; 5+ messages in thread
From: Aaron Covrig via Guix-patches via @ 2024-11-23 21:24 UTC (permalink / raw)
  To: control, 74464

[-- Attachment #1: Type: text/plain, Size: 288 bytes --]

user guix
usertag 74464 + reviewed-looks-good
thanks

Guix QA review form submission:
The package builds for me and doesn&apos;t show any signs of breaking
changes when building a couple simple Dockerfiles

Items marked as checked: Lint warnings, Package builds, Commit messages

[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 228 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* bug#74464: [PATCH] gnu: buildah: Update to 1.38.0.
  2024-11-21 14:08 [bug#74464] [PATCH] gnu: buildah: Update to 1.38.0 Tomas Volf
  2024-11-23 21:24 ` [bug#74464] QA review for 74464 Aaron Covrig via Guix-patches via
@ 2024-11-24  1:12 ` Z572
  2024-11-24 14:55   ` [bug#74464] " Tomas Volf
  1 sibling, 1 reply; 5+ messages in thread
From: Z572 @ 2024-11-24  1:12 UTC (permalink / raw)
  To: Tomas Volf; +Cc: 74464-done

[-- Attachment #1: Type: text/plain, Size: 1486 bytes --]

Tomas Volf <~@wolfsden.cz> writes:

> * gnu/packages/containers.scm (buildah): Update to 1.38.0.
> <native-inputs>: Use go-1.22.

[native-inputs]: Use go-1.22.

>
> Change-Id: I4a36345f91fde84fdbf5b4ef4cd5dc2749c90327
> ---
>  gnu/packages/containers.scm | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/gnu/packages/containers.scm b/gnu/packages/containers.scm
> index adae2f5bfc..c883592be6 100644
> --- a/gnu/packages/containers.scm
> +++ b/gnu/packages/containers.scm
> @@ -606,7 +606,7 @@ (define-public podman-compose
>  (define-public buildah
>    (package
>      (name "buildah")
> -    (version "1.37.5")
> +    (version "1.38.0")
>      (source
>       (origin
>         (method git-fetch)
> @@ -614,7 +614,7 @@ (define-public buildah
>               (url "https://github.com/containers/buildah")
>               (commit (string-append "v" version))))
>         (sha256
> -        (base32 "0m15pizivwwq2cnmsyhsz5h8zblcvpy06lj82vypg358spq3y0l4"))
> +        (base32 "1lnl5v8d5p4g0rm4d90rw4hdh066w7v8r9g1h0v1z533mbgxgry8"))
>         (file-name (git-file-name name version))))
>      (build-system gnu-build-system)
>      (arguments
> @@ -684,7 +684,7 @@ (define-public buildah
>                    lvm2))
>      (native-inputs
>       (list bats
> -           go-1.21
> +           go-1.22
>             go-github-com-go-md2man
>             pkg-config))
>      (synopsis "Build @acronym{OCI, Open Container Initiative} images")
pushed, closing.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [bug#74464] [PATCH] gnu: buildah: Update to 1.38.0.
  2024-11-24  1:12 ` bug#74464: [PATCH] gnu: buildah: Update to 1.38.0 Z572
@ 2024-11-24 14:55   ` Tomas Volf
  2024-11-24 16:03     ` Zheng Junjie
  0 siblings, 1 reply; 5+ messages in thread
From: Tomas Volf @ 2024-11-24 14:55 UTC (permalink / raw)
  To: Z572; +Cc: 74464-done

[-- Attachment #1: Type: text/plain, Size: 1004 bytes --]


Hi,

thank you for merging my patches.  I just have a question regarding the
following:

Z572 <zhengjunjie@iscas.ac.cn> writes:

> Tomas Volf <~@wolfsden.cz> writes:
>
>> * gnu/packages/containers.scm (buildah): Update to 1.38.0.
>> <native-inputs>: Use go-1.22.
>
> [native-inputs]: Use go-1.22.

I tried following the `(standards)Indicating the Part Changed' manual,
since Guix claims to follow the Change log format but I did not manage
to find its own documentation for it.  According to the info manual, the
`[..]'  should be used for conditional changes (which this is not).  The
`<..>' should be used to indicate part changed (which this is).

Could you please point me to a documentation where I could read more on
what Guix's deviations from the GNU Change Logs format are so that I can
adhere to it next time?

Thank you and have a nice day,
Tomas

-- 
There are only two hard things in Computer Science:
cache invalidation, naming things and off-by-one errors.

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 853 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [bug#74464] [PATCH] gnu: buildah: Update to 1.38.0.
  2024-11-24 14:55   ` [bug#74464] " Tomas Volf
@ 2024-11-24 16:03     ` Zheng Junjie
  0 siblings, 0 replies; 5+ messages in thread
From: Zheng Junjie @ 2024-11-24 16:03 UTC (permalink / raw)
  To: Tomas Volf; +Cc: 74464-done

[-- Attachment #1: Type: text/plain, Size: 1245 bytes --]

Tomas Volf <~@wolfsden.cz> writes:

> Hi,
>
> thank you for merging my patches.  I just have a question regarding the
> following:
>
> Z572 <zhengjunjie@iscas.ac.cn> writes:
>
>> Tomas Volf <~@wolfsden.cz> writes:
>>
>>> * gnu/packages/containers.scm (buildah): Update to 1.38.0.
>>> <native-inputs>: Use go-1.22.
>>
>> [native-inputs]: Use go-1.22.
>
> I tried following the `(standards)Indicating the Part Changed' manual,
> since Guix claims to follow the Change log format but I did not manage
> to find its own documentation for it.  According to the info manual, the
> `[..]'  should be used for conditional changes (which this is not).  The
> `<..>' should be used to indicate part changed (which this is).

see

https://mail.gnu.org/archive/html/guix-devel/2019-06/msg00092.html

and

https://mail.gnu.org/archive/html/guix-devel/2023-09/msg00124.html

>
> Could you please point me to a documentation where I could read more on
> what Guix's deviations from the GNU Change Logs format are so that I can
> adhere to it next time?

And Unfortunately there doesn't seem to be such a thing, I remember a
previous discussion at guix-devel about summarizing a document, but
there was no follow-up.

>
> Thank you and have a nice day,
> Tomas

[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2024-11-24 16:04 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2024-11-21 14:08 [bug#74464] [PATCH] gnu: buildah: Update to 1.38.0 Tomas Volf
2024-11-23 21:24 ` [bug#74464] QA review for 74464 Aaron Covrig via Guix-patches via
2024-11-24  1:12 ` bug#74464: [PATCH] gnu: buildah: Update to 1.38.0 Z572
2024-11-24 14:55   ` [bug#74464] " Tomas Volf
2024-11-24 16:03     ` Zheng Junjie

Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).