[bug#74225] [PATCH] lint: Check for more types of custom 'check phases.

[bug#74225] [PATCH] lint: Check for more types of custom 'check phases.

[Dariqq]

* guix/lint.scm (check-optional-tests): Also check for add-before and
add-after when adding custom 'check phases.

Change-Id: Idc959f90d7e9aa9d5001f34e00f88b41aa20fb2a
---
Hi,
Stumbled upon a test failure in u-boot-utils today which is not using #:tests? for its custom 'check phase but not being detected by the linter. Reason is that the 'check phase is added after 'install and not just replacing it.

This little patch makes it it possible to detect it and adds 38 more warnings.


 guix/lint.scm | 4 ++++
 1 file changed, 4 insertions(+)

diff --git a/guix/lint.scm b/guix/lint.scm
index 8c6c20c723..4ba728da33 100644
--- a/guix/lint.scm
+++ b/guix/lint.scm
@@ -1433,6 +1433,10 @@ (define (check-optional-tests package)
     (match delta
       (`(replace 'check ,expression)
        (check-check-procedure expression))
+      (`(add-after ,_ 'check ,expression)
+       (check-check-procedure expression))
+      (`(add-before ,_ 'check ,expression)
+       (check-check-procedure expression))
       (_ '())))
   (define (check-phases-deltas deltas)
     (append-map check-phases-delta deltas))

base-commit: 0c1a6db8094dc6b20762eceae369daae545fc5e4
-- 
2.46.0

[bug#74225] [PATCH] lint: Check for more types of custom 'check phases.

[Simon Tournier]

Hi,

On Wed, 06 Nov 2024 at 10:46, Dariqq <dariqq@posteo.net> wrote:

> diff --git a/guix/lint.scm b/guix/lint.scm
> index 8c6c20c723..4ba728da33 100644
> --- a/guix/lint.scm
> +++ b/guix/lint.scm
> @@ -1433,6 +1433,10 @@ (define (check-optional-tests package)
>      (match delta
>        (`(replace 'check ,expression)
>         (check-check-procedure expression))
> +      (`(add-after ,_ 'check ,expression)
> +       (check-check-procedure expression))
> +      (`(add-before ,_ 'check ,expression)
> +       (check-check-procedure expression))

Please note that 'check here is up to packagers.  They might pick the
symbol 'tests or 'run-check or 'adjusted-tests or 'custom-tests or
whatever else.  To my knowledge, there is no real convention.

Well, I do not know.

Cheers,
simon

[bug#74225] [PATCH] lint: Check for more types of custom 'check phases.

[Dariqq]

Hi Simon,

On 16.11.24 09:07, Simon Tournier wrote:
> Hi,
> 
> On Wed, 06 Nov 2024 at 10:46, Dariqq <dariqq@posteo.net> wrote:
> 
>> diff --git a/guix/lint.scm b/guix/lint.scm
>> index 8c6c20c723..4ba728da33 100644
>> --- a/guix/lint.scm
>> +++ b/guix/lint.scm
>> @@ -1433,6 +1433,10 @@ (define (check-optional-tests package)
>>       (match delta
>>         (`(replace 'check ,expression)
>>          (check-check-procedure expression))
>> +      (`(add-after ,_ 'check ,expression)
>> +       (check-check-procedure expression))
>> +      (`(add-before ,_ 'check ,expression)
>> +       (check-check-procedure expression))
> 
> Please note that 'check here is up to packagers.  They might pick the
> symbol 'tests or 'run-check or 'adjusted-tests or 'custom-tests or
> whatever else.  To my knowledge, there is no real convention.
> 

Of course this is not perfect because the name of the phase to run the 
tests is arbitrary but this (simple) change catches this problem in 38 
packages currently in guix (and 'check seems to be convention in guix)

This came out of a frustration with failing tests in u-boot-tools which 
implements a custom 'check phase after 'install which before 
e6ec657c497cdfe9130b7bf5bdfb717a823bf02b were unskipable but passed the 
lint check.



> Well, I do not know.
> 
> Cheers,
> simon

Dariqq

bug#74225: [PATCH] lint: Check for more types of custom 'check phases.

[Ludovic Courtès]

Dariqq <dariqq@posteo.net> skribis:

> * guix/lint.scm (check-optional-tests): Also check for add-before and
> add-after when adding custom 'check phases.
>
> Change-Id: Idc959f90d7e9aa9d5001f34e00f88b41aa20fb2a

Applied, thanks!