unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: Ian Eure <ian@retrospec.tv>
To: 75268@debbugs.gnu.org
Cc: liliana.prikler@gmail.com
Subject: [bug#75268] [PATCH emacs-team 0/2] Apply native-comp grafts to emacs-next as well
Date: Tue, 07 Jan 2025 20:48:19 -0800	[thread overview]
Message-ID: <87ldvlsygc.fsf@retrospec.tv> (raw)
In-Reply-To: <cover.1735766271.git.liliana.prikler@gmail.com>

Hi Liliana,

(Sorry if this reply is weird, I’m still ironing out some issues 
in my workflow)

This all looks good to me.  I compared the emacs and emacs-next 
versions of -native-comp-fix-filenames.patch, and your changes 
seem straightforward and minimal.

While I was reading your patches, I noticed this typo in 
emacs-disable-jit-compilation.patch:

> +Notably, Guix removes the hashes that prevent inadvertent 
> shadowing
> +frm the file names of compiled libraries in order to facilitate 
> grafts.

If you think it’s worth including in you patch series, it’d be 
nice to fix, but if you’re rather not, that’s also fine.

Thanks,
  -- Ian




  parent reply	other threads:[~2025-01-08  4:49 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2025-01-01 21:17 [bug#75268] [PATCH emacs-team 0/2] Apply native-comp grafts to emacs-next as well Liliana Marie Prikler
2025-01-01 21:15 ` [bug#75268] [PATCH emacs-team 1/2] gnu: emacs-next: Don't hash file names in native compilation Liliana Marie Prikler
2025-01-01 21:15 ` [bug#75268] [PATCH emacs-team v2 1/3] " Liliana Marie Prikler
2025-01-01 21:16   ` [bug#75268] [PATCH emacs-team v2 2/3] gnu: emacs-next: Pin natively compiled packages Liliana Marie Prikler
2025-01-06 16:31   ` [bug#75268] [PATCH emacs-team v2 3/3] gnu: emacs-next: Disable jit compilation Liliana Marie Prikler
2025-01-01 21:16 ` [bug#75268] [PATCH emacs-team 2/2] gnu: emacs-next: Pin natively compiled packages Liliana Marie Prikler
2025-01-08  4:48 ` Ian Eure [this message]
2025-01-08  5:16   ` [bug#75268] [PATCH emacs-team 0/2] Apply native-comp grafts to emacs-next as well Liliana Marie Prikler

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87ldvlsygc.fsf@retrospec.tv \
    --to=ian@retrospec.tv \
    --cc=75268@debbugs.gnu.org \
    --cc=liliana.prikler@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).