From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56733) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1cvsb0-0001W1-OE for guix-patches@gnu.org; Wed, 05 Apr 2017 17:36:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1cvsaw-0007ZN-Jo for guix-patches@gnu.org; Wed, 05 Apr 2017 17:36:06 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:35917) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1cvsaw-0007ZI-G1 for guix-patches@gnu.org; Wed, 05 Apr 2017 17:36:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1cvsaw-00038q-8O for guix-patches@gnu.org; Wed, 05 Apr 2017 17:36:02 -0400 Subject: bug#26341: [PATCH] build: vm: Add missing module. Resent-Message-ID: From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) References: <20170402150157.7149-1-m.othacehe@gmail.com> <8760iks5u4.fsf@gnu.org> <86bmsbrvsk.fsf@gmail.com> Date: Wed, 05 Apr 2017 23:35:15 +0200 In-Reply-To: <86bmsbrvsk.fsf@gmail.com> (Mathieu Othacehe's message of "Wed, 05 Apr 2017 12:30:35 +0200") Message-ID: <87k26yler0.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Mathieu Othacehe Cc: 26341@debbugs.gnu.org Hello! Mathieu Othacehe skribis: >> That said, we should improve this. Perhaps something along the lines of >> the attached patch would work. >> >> Could you try and send an updated patch? > > Well, I tried a "guix system vm ..." with just my patch and it worked. I > agree with you it shouldn't work because it is not possible to use FFI > in static Guile. > > I don't exactly what happend but it might be something like that : > > (gnu build vm) -- uses module ----> (guix build syscalls) (with my patch) > | | > | | > | -------- provides > | | | > | v v > | mount umount (FFI versions) > | > -------------> (gnu build linux-boot) > | > | uses > (gnu build file-systems) > | > | > overrides mount and > unount with libguile > versions if you're > using static Guile. > > So we end-up using libguile mount and umount in (gnu build vm) and not > FFI versions of (guix build syscalls). Yeah, I think there must have been a =E2=80=9C(guix build syscalls) overrid= es core binding =E2=80=98mount=E2=80=99=E2=80=9D warning, and Guile chose the = core binding over the other one so things turned out to work fine. > However, it is still a good idea to allow modules to use (guix build > syscalls) independently of the fact that they are running inside static > Guile or not. Agreed! Ludo=E2=80=99.