From: Roel Janssen <roel@gnu.org>
To: Ricardo Wurmus <rekado@elephly.net>
Cc: 25928-done@debbugs.gnu.org
Subject: bug#25928: [PATCH] gnu: Add darktable.
Date: Wed, 10 May 2017 19:51:42 +0200 [thread overview]
Message-ID: <87k25obnxm.fsf@gnu.org> (raw)
In-Reply-To: <87d1bghf1z.fsf@elephly.net>
Ricardo Wurmus writes:
> Roel Janssen <roel@gnu.org> writes:
>
>> > I wonder if it would be possible to augment LDFLAGS and CPATH in
>> > #:configure-flags or #:make-flags instead of using build phases (which I
>> > find a bit crude).
>> >
>> > If that’s too hard I promise I won’t complain about doing it with build
>> > phases :)
>
>> See attached patch. By adding the LDFLAGS part to either #:make-flags
>> or #:configure-flags, the run-path validation phase fails at the end of
>> the build process.
>
>> So, maybe we can settle half-way here? :-)
>
> Sure, looks good to me!
>
>> > Good to push with the change to the description.
>> > Thanks!
>
>> Is this then finally the moment we get to have darktable in Guix? :-)
>
> Yay! Thank you!
Pushed in 91a9c65c7bae73d999ccc2288833e909ce4a0871.
Thanks!
Kind regards,
Roel Janssen
prev parent reply other threads:[~2017-05-10 17:52 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <87zih4ee7i.fsf@gnu.org>
[not found] ` <20170313232428.0530762b@alma-ubu>
[not found] ` <20170314231326.3ac43a08@alma-ubu>
2017-03-30 13:19 ` bug#25928: [PATCH] gnu: Add darktable Ricardo Wurmus
2017-03-30 13:00 ` Roel Janssen
2017-05-10 14:08 ` Roel Janssen
2017-05-10 14:40 ` Ricardo Wurmus
2017-05-10 15:28 ` Roel Janssen
2017-05-10 16:06 ` Ricardo Wurmus
2017-05-10 17:51 ` Roel Janssen [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k25obnxm.fsf@gnu.org \
--to=roel@gnu.org \
--cc=25928-done@debbugs.gnu.org \
--cc=rekado@elephly.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).