From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51267) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1dANXC-0002b8-97 for guix-patches@gnu.org; Mon, 15 May 2017 17:28:10 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1dANX7-0005gH-Ts for guix-patches@gnu.org; Mon, 15 May 2017 17:28:06 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:44366) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1dANX7-0005g2-Q4 for guix-patches@gnu.org; Mon, 15 May 2017 17:28:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1dANX7-0000lL-JO for guix-patches@gnu.org; Mon, 15 May 2017 17:28:01 -0400 Subject: bug#26803: [PATCH 31/36] gnu: Add java-httpcomponents-httpclient. Resent-Message-ID: References: <20170506153617.3074-1-rekado@elephly.net> <20170506153617.3074-31-rekado@elephly.net> <877f1h7vmc.fsf@elephly.net> From: Roel Janssen In-reply-to: <877f1h7vmc.fsf@elephly.net> Date: Mon, 15 May 2017 23:26:51 +0200 Message-ID: <87k25hdd5w.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ricardo Wurmus Cc: 26803@debbugs.gnu.org Ricardo Wurmus writes: > Roel Janssen writes: > >> Ricardo Wurmus writes: >> >>> * gnu/packages/java.scm (java-httpcomponents-httpclient): New variable. >>> --- >>> gnu/packages/java.scm | 36 ++++++++++++++++++++++++++++++++++++ >>> 1 file changed, 36 insertions(+) >>> >>> diff --git a/gnu/packages/java.scm b/gnu/packages/java.scm >>> index 19642cbfc..ee3a2bd2b 100644 >>> --- a/gnu/packages/java.scm >>> +++ b/gnu/packages/java.scm >>> @@ -2113,6 +2113,42 @@ NIO."))) >>> (description "This package provides the HttpCore benchmarking tool. It is >>> an Apache AB clone based on HttpCore."))) >>> >>> +(define-public java-httpcomponents-httpclient >>> + (package >>> + (name "java-httpcomponents-httpclient") >>> + (version "4.5.3") >>> + (source (origin >>> + (method url-fetch) >>> + (uri (string-append "mirror://apache/httpcomponents/httpclient/" >>> + "source/httpcomponents-client-" >>> + version "-src.tar.gz")) >>> + (sha256 >>> + (base32 >>> + "1428399s7qy3cim5wc6f3ks4gl9nf9vkjpfmnlap3jflif7g2pj1")))) >>> + (build-system ant-build-system) >>> + (arguments >>> + `(#:jar-name "httpcomponents-httpclient.jar" >>> + #:phases >>> + (modify-phases %standard-phases >>> + (add-after 'unpack 'chdir >>> + (lambda _ (chdir "httpclient") #t))))) >>> + (inputs >>> + `(("java-commons-logging-minimal" ,java-commons-logging-minimal) >>> + ("java-commons-codec" ,java-commons-codec) >>> + ("java-hamcrest-core" ,java-hamcrest-core) >>> + ("java-httpcomponents-httpcore" ,java-httpcomponents-httpcore) >>> + ("java-mockito" ,java-mockito-1) >>> + ("java-junit" ,java-junit))) >>> + (home-page "https://hc.apache.org/httpcomponents-client-ga/") >>> + (synopsis "HTTP client library for Java") >>> + (description "Although the @code{java.net} package provides basic >> >> I thought package names weren't supposed to be @code{}ed. > > This is a Java namespace, not a Guix package. It is only used in import > statements, so it’s code. “java.net” belongs to the standard library, > so it also doesn’t have a separate project name (unlike these Apache > projects). Maybe the "... @code{java.net} >>>package<<<" should be rephrased to "... @code{java.net} namespace provided by this package ...". Either way is fine though, this is nitpicking at its finest.. ;) Kind regards, Roel Janssen