From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52742)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dcCe6-0006EP-2C
	for guix-patches@gnu.org; Mon, 31 Jul 2017 11:30:19 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dcCdw-000553-FJ
	for guix-patches@gnu.org; Mon, 31 Jul 2017 11:30:14 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:32859)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1dcCdw-00054w-Bc
	for guix-patches@gnu.org; Mon, 31 Jul 2017 11:30:04 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1dcCdw-0004sU-55
	for guix-patches@gnu.org; Mon, 31 Jul 2017 11:30:04 -0400
Subject: [bug#27848] guix: build-system: gnu: Avoid warnings from "libtool
	finish"
Resent-Message-ID: <handler.27848.B27848.150151495018599@debbugs.gnu.org>
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <874ltyhrj2.fsf@i-ulialbion.it.manchester.ac.uk>
Date: Mon, 31 Jul 2017 17:28:55 +0200
In-Reply-To: <874ltyhrj2.fsf@i-ulialbion.it.manchester.ac.uk> (Dave Love's
	message of "Thu, 27 Jul 2017 15:40:33 +0100")
Message-ID: <87k22o39s8.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Dave Love <fx@gnu.org>
Cc: 27848@debbugs.gnu.org

Dave Love <fx@gnu.org> skribis:

> --- a/guix/build/gnu-build-system.scm
> +++ b/guix/build/gnu-build-system.scm
> @@ -271,9 +271,15 @@ makefiles."
>      ;; Call `configure' with a relative path.  Otherwise, GCC's build sy=
stem
>      ;; (for instance) records absolute source file names, which typically
>      ;; contain the hash part of the `.drv' file, leading to a reference =
leak.
> -    (zero? (apply system* bash
> -                  (string-append srcdir "/configure")
> -                  flags))))
> +    (and (zero? (apply system* bash
> +                       (string-append srcdir "/configure")
> +                       flags))
> +         ;; Avoid warnings about from "libtool finish" about not finding
> +         ;; ldconfig.
> +         (if (file-exists? "libtool")
> +             (begin (substitute* "libtool" (("ldconfig") ":"))
> +                    #t)
> +             #t))))
>=20=20

I=E2=80=99m not too keen on this approach, in large part because I=E2=80=99=
ve got used
to the =E2=80=9Cldconfig not found=E2=80=9D messages, but also because a si=
mple change
like this can create more problems than what it solves: packages where
the =E2=80=9Clibtool=E2=80=9D script lives in a different directory, packag=
es where
=E2=80=9Clibtool=E2=80=9D is a different thing, packages where it=E2=80=99s=
 read-only or where
it=E2=80=99s a directory, etc.

Since this is a rebuild-the-world change, we have to make sure it=E2=80=99s
really worth it.

WDYT?

Thanks,
Ludo=E2=80=99.