From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:52147)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1e0w0x-00019p-EB
	for guix-patches@gnu.org; Sat, 07 Oct 2017 16:48:04 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1e0w0w-0005VI-Ag
	for guix-patches@gnu.org; Sat, 07 Oct 2017 16:48:03 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:46424)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1e0w0w-0005V1-6l
	for guix-patches@gnu.org; Sat, 07 Oct 2017 16:48:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1e0w0v-00051W-SN
	for guix-patches@gnu.org; Sat, 07 Oct 2017 16:48:01 -0400
Subject: [bug#28558] [PATCH] gnu: Add atool.
Resent-Message-ID: <handler.28558.B28558.150740927519296@debbugs.gnu.org>
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <150611695436.21286.7179341499419388884.stgit@sandburg>
	<bb546080-8a63-824e-43a6-24d62abc9c07@uq.edu.au>
	<87o9q12sbz.fsf@xsteve.at>
Date: Sat, 07 Oct 2017 22:47:44 +0200
In-Reply-To: <87o9q12sbz.fsf@xsteve.at> ("Stefan
	\=\?utf-8\?Q\?Reich\=C3\=B6r\=22\?\=
	\=\?utf-8\?Q\?'s\?\= message of "Sat, 23 Sep 2017 20:16:48 +0200")
Message-ID: <87k206it1r.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Stefan =?UTF-8?Q?Reich=C3=B6r?= <stefan@xsteve.at>
Cc: 28558@debbugs.gnu.org

Hi Stefan,

Stefan Reich=C3=B6r <stefan@xsteve.at> skribis:

>> On 23/09/17 07:49, Stefan Reich=C3=B6r wrote:
>>> * gnu/packages/compression.scm (atool): New variable.
>> Thanks for the patch. While adding all compression programs supported
>> (e.g. tar) as inputs is probably too much given their large number, I
>> think it would be good to add "file" and patch in the path to "file"
>> in bin/atool. WDYT?
>
> Thanks for your feedback. I don't think that file is an important tool
> for atool. At least I use only archives with the correct file extension.
> And all the archives that I remember that I downloaded from some site
> also provided the correct file extension. In that case file is not needed=
 to
> detect the archive type.
>
> However, if you think that hard coding the full path to file is a good
> thing I will update my patch. It should be doable for me...

As discussed earlier in another thread, I think it=E2=80=99s a good idea to
hard-code absolute file names.  Could you update the patch accordingly?

TIA,
Ludo=E2=80=99.