unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: nee <nee@cock.li>
Cc: 28960@debbugs.gnu.org
Subject: [bug#28960] [PATCH] services: Add murmur.
Date: Tue, 31 Oct 2017 01:02:06 +0100	[thread overview]
Message-ID: <87k1zcyykh.fsf@gnu.org> (raw)
In-Reply-To: <7d7f4e40-c12b-e9a6-b84d-9e6d1fc9fdf1@cock.li> (nee@cock.li's message of "Mon, 30 Oct 2017 23:38:06 +0100")

Heya!

nee <nee@cock.li> skribis:

> Am 24.10.2017 um 23:34 schrieb Ludovic Courtès:

[...]

>> If the above macro is good enough, we can add it to (guix records) with
>> a TODO comment.  That would already be better than the other options.
>> 
>
> I added it for now. Personally I don't like having functions with big
> TODOs like this. What would be the solution for thunked delayed fields?
> Force them as they are bound in the let?

The solution would be to do what the accessors do, which is to
transparently force the promise or call the thunk.  Well, for later!

>> This makes me think that it would be good to have a unit test.  Would
>> you like to try writing one now (see the examples in gnu/tests/*.scm),
>> or do you prefer to leave it for later?
> I would like to write some tests, but right now I need to setup my guix
> development environment on a different computer first. On my current
> setup I have 15 gigabytes of free hard drive space and when I run `make
> check-system` it fails with some 'no space left on device' message.

You should probably just run the test you want, as in:

  make check-system TESTS=basic

This is much more reasonable in terms of disk space usage.  See
<https://www.gnu.org/software/guix/manual/html_node/Running-the-Test-Suite.html>.

I’ll take another look soonish and apply the patches if everything’s
alright!

Thanks,
Ludo’.

  reply	other threads:[~2017-10-31  0:03 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-10-23 21:34 [bug#28960] [PATCH] services: Add murmur nee
2017-10-24  4:32 ` ng0
2017-10-24  5:04 ` Ludovic Courtès
2017-10-24 17:19   ` nee
2017-10-24 21:34     ` Ludovic Courtès
2017-10-30 22:38       ` nee
2017-10-31  0:02         ` Ludovic Courtès [this message]
2017-11-05 10:42         ` bug#28960: " Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k1zcyykh.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=28960@debbugs.gnu.org \
    --cc=nee@cock.li \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).