From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51393)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1eBSAF-0001Mt-HE
	for guix-patches@gnu.org; Sun, 05 Nov 2017 16:09:08 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1eBSAA-00011z-Ii
	for guix-patches@gnu.org; Sun, 05 Nov 2017 16:09:07 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:44028)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1eBSAA-00011r-FR
	for guix-patches@gnu.org; Sun, 05 Nov 2017 16:09:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1eBSAA-0000o0-9L
	for guix-patches@gnu.org; Sun, 05 Nov 2017 16:09:02 -0500
Subject: [bug#29100] [PATCH 1/3] build: Use overlayfs instead of unionfs.
Resent-Message-ID: <handler.29100.B29100.15099161353081@debbugs.gnu.org>
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <20171101083307.5214-1-h.goebel@crazy-compilers.com>
	<20171101083952.5376-1-h.goebel@crazy-compilers.com>
Date: Sun, 05 Nov 2017 22:08:49 +0100
In-Reply-To: <20171101083952.5376-1-h.goebel@crazy-compilers.com> (Hartmut
	Goebel's message of "Wed, 1 Nov 2017 09:39:50 +0100")
Message-ID: <87k1z4mo0u.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Hartmut Goebel <h.goebel@crazy-compilers.com>
Cc: 29100@debbugs.gnu.org

Heya,

Hartmut Goebel <h.goebel@crazy-compilers.com> skribis:

> Overlayfs is part of the kernel, while unionfs needs FUSE.  This also red=
uces
> the size of the initrd by ca. 4.3% (487K).

Awesome!  It=E2=80=99s definitely an improvement, and I=E2=80=99m happy tha=
t it fixes
<http://bugs.gnu.org/23056>.

> * gnu/build/linux-boot.scm (mount-root-file-system): Remove optional para=
meter
>   "unionfs"; mount using overlayfs instead of unionfs; new directory layo=
ut
>   requied by overlayfs; update documentation;
>   [mark-as-not-killable]: remove now unused function
>
> * gnu/system/linux-intrd.scm (file-system-packages): Remove now unused
                     ^^^
Typo.

>   packages "unionfs-fuse/static".
>   (linux-modules): Replace "fuse" by "overlay".

Nitpick: please capitalize sentences, add missing periods.

> +        ;; Make /root a overlay of the tmpfs and the actual root.

s/a/an/

> --- a/gnu/system/linux-initrd.scm
> +++ b/gnu/system/linux-initrd.scm
> @@ -236,7 +236,7 @@ FILE-SYSTEMS."
>            (list btrfs-progs/static)
>            '())
>      ,@(if volatile-root?
> -          (list unionfs-fuse/static)
> +          (list ) ;; nothing requierd in this case
>            '())))

You can remove the whole =E2=80=98if=E2=80=99 here.

OK with these changes, thank you!

Ludo=E2=80=99.