unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: Hartmut Goebel <h.goebel@crazy-compilers.com>
Cc: 29100@debbugs.gnu.org
Subject: [bug#29100] [PATCH 1/3] build: Use overlayfs instead of unionfs.
Date: Sun, 05 Nov 2017 22:08:49 +0100	[thread overview]
Message-ID: <87k1z4mo0u.fsf@gnu.org> (raw)
In-Reply-To: <20171101083952.5376-1-h.goebel@crazy-compilers.com> (Hartmut Goebel's message of "Wed, 1 Nov 2017 09:39:50 +0100")

Heya,

Hartmut Goebel <h.goebel@crazy-compilers.com> skribis:

> Overlayfs is part of the kernel, while unionfs needs FUSE.  This also reduces
> the size of the initrd by ca. 4.3% (487K).

Awesome!  It’s definitely an improvement, and I’m happy that it fixes
<http://bugs.gnu.org/23056>.

> * gnu/build/linux-boot.scm (mount-root-file-system): Remove optional parameter
>   "unionfs"; mount using overlayfs instead of unionfs; new directory layout
>   requied by overlayfs; update documentation;
>   [mark-as-not-killable]: remove now unused function
>
> * gnu/system/linux-intrd.scm (file-system-packages): Remove now unused
                     ^^^
Typo.

>   packages "unionfs-fuse/static".
>   (linux-modules): Replace "fuse" by "overlay".

Nitpick: please capitalize sentences, add missing periods.

> +        ;; Make /root a overlay of the tmpfs and the actual root.

s/a/an/

> --- a/gnu/system/linux-initrd.scm
> +++ b/gnu/system/linux-initrd.scm
> @@ -236,7 +236,7 @@ FILE-SYSTEMS."
>            (list btrfs-progs/static)
>            '())
>      ,@(if volatile-root?
> -          (list unionfs-fuse/static)
> +          (list ) ;; nothing requierd in this case
>            '())))

You can remove the whole ‘if’ here.

OK with these changes, thank you!

Ludo’.

  parent reply	other threads:[~2017-11-05 21:09 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-11-01  8:33 [bug#29100] [PATCH 0/3] Use overlayfs instead of unionfs Hartmut Goebel
2017-11-01  8:39 ` [bug#29100] [PATCH 1/3] build: " Hartmut Goebel
2017-11-01  8:39   ` [bug#29100] [PATCH 2/3] install: " Hartmut Goebel
2017-11-02 17:44     ` Danny Milosavljevic
2017-11-02 18:20       ` Hartmut Goebel
2017-11-05 21:05         ` Ludovic Courtès
2017-11-06  9:33           ` Hartmut Goebel
2017-11-01  8:39   ` [bug#29100] [PATCH 3/3] gnu: service: Update comment Hartmut Goebel
2017-11-05 21:09     ` Ludovic Courtès
2017-11-05 21:08   ` Ludovic Courtès [this message]
2017-11-06  9:40     ` [bug#29100] [PATCH 1/3] build: Use overlayfs instead of unionfs Hartmut Goebel
2017-11-06 10:30       ` Ludovic Courtès
2017-11-08 17:26 ` bug#29100: Updated, tested again and merged Hartmut Goebel

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k1z4mo0u.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=29100@debbugs.gnu.org \
    --cc=h.goebel@crazy-compilers.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).