From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:50876)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1eOS5e-0006J4-F9
	for guix-patches@gnu.org; Mon, 11 Dec 2017 12:42:08 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1eOS5a-0000QY-He
	for guix-patches@gnu.org; Mon, 11 Dec 2017 12:42:06 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:48481)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1eOS5a-0000Q4-DL
	for guix-patches@gnu.org; Mon, 11 Dec 2017 12:42:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1eOS5a-0007CC-19
	for guix-patches@gnu.org; Mon, 11 Dec 2017 12:42:02 -0500
Subject: [bug#29409] [PATCH 3/4] build: vm: Adapt qemu command to ARM.
Resent-Message-ID: <handler.29409.B29409.151301410527631@debbugs.gnu.org>
References: <1512565193-3234-1-git-send-email-m.othacehe@gmail.com>
	<1512565193-3234-4-git-send-email-m.othacehe@gmail.com>
	<87d13lw77m.fsf@gnu.org>
From: Mathieu Othacehe <m.othacehe@gmail.com>
In-reply-to: <87d13lw77m.fsf@gnu.org>
Date: Mon, 11 Dec 2017 18:41:32 +0100
Message-ID: <87k1xt9n77.fsf@gmail.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 8bit
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
Cc: 29409@debbugs.gnu.org


> Do we really need this new parameter and could we use the
> ‘target-arm32?’ procedure that you added directly?

The problem is "target-arm32" is defined in (guix utils) which is not
included at build time. Because it is supposed to be superseded by
"let-system" in a near future, I tought it would be better than moving
"target-arm32" in (guix build utils), am I right ?

> Could you add a short comment explaining this?

Sure.

> For clarity, it might be best to collect all the platform-specific
> options separately, like:
>
>   (define arch-specific-flags
>     `(,@(if target-arm32? '("-M" "virt") '())
>       ,@(if (and (file-exists? "/dev/kvm") …) …)
>       …))
>
> WDYT?

Seems better, I'll propose an updated patch.

Thanks,

Mathieu