Arun Isaac <arunisaac@systemreboot.net> writes:

> Marius Bakke <mbakke@fastmail.com> writes:
>
>> Arun Isaac <arunisaac@systemreboot.net> writes:
>>
>>> * gnu/packages/mail.scm (notmuch)[arguments]: Move elisp files to
>>> share/emacs/site-lisp/guix.d/notmuch-<version>.
>>> Add make-autoloads phase.
>>
>> I had to dive into emacs-build-system to understand what this patch
>> does.  AFAICT the purpose is to move the emacs files to a versioned
>> subdirectory instead of "polluting" site-lisp
>
> Yes, this is what the configure flags do. And, all other emacs packages
> in Guix follow this convention. So, I thought it appropriate for notmuch
> to do the same.

Makes sense.

>> and that's why the make-autoloads phase is necessary?
>
> The make-autoloads phase generates autoloads for notmuch commands so
> that the full elisp files are loaded only at the last moment when some
> notmuch command is actually invoked. This reduces the emacs startup
> time. Again, all emacs packages in Guix have autoloads.

Neat.

>> I haven't tested it, but LGTM.
>
> Shall I push?

SGTM!