From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:43148)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ejuCj-0007Sm-2u
	for guix-patches@gnu.org; Thu, 08 Feb 2018 16:58:07 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ejuCg-0003Gb-1G
	for guix-patches@gnu.org; Thu, 08 Feb 2018 16:58:05 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:54718)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1ejuCf-0003GX-Ts
	for guix-patches@gnu.org; Thu, 08 Feb 2018 16:58:01 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1ejuCf-0007Q8-MG
	for guix-patches@gnu.org; Thu, 08 Feb 2018 16:58:01 -0500
Subject: [bug#30196] [PATCH 2/2] gnu: services: Add wesnothd service.
Resent-Message-ID: <handler.30196.B30196.151812703928471@debbugs.gnu.org>
From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=)
References: <20180121183348.29317-1-arunisaac@systemreboot.net>
	<20180122121104.11149-1-arunisaac@systemreboot.net>
	<87372e6t6s.fsf@gnu.org> <cu7d11f8ytl.fsf@systemreboot.net>
Date: Thu, 08 Feb 2018 22:57:04 +0100
In-Reply-To: <cu7d11f8ytl.fsf@systemreboot.net> (Arun Isaac's message of "Thu,
	08 Feb 2018 17:42:38 +0530")
Message-ID: <87k1vntaa7.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Arun Isaac <arunisaac@systemreboot.net>
Cc: 30196@debbugs.gnu.org

Arun Isaac <arunisaac@systemreboot.net> skribis:

>>> * gnu/services/games.scm: New file.
>>> * gnu/local.mk (GNU_SYSTEM_MODULES): Add it.
>>> * doc/guix.texi (Game Services): Document the service.
>>
>> LGTM, thanks!
>
> Thanks, I'll push with the changes you mentioned.
>
>> You=E2=80=99d get bonus points by writing a system test, but perhaps the=
re=E2=80=99s not
>> much that could easily be tested.  So, no big deal.
>
> I might be able to write a simple test that checks if the server has
> started successfully and is listening on port 15000. But, this seems too
> trivial a test to me. Is it worth it? WDYT?

Yeah I thought about it, probably not worth it.

Thanks,
Ludo=E2=80=99.