From: ludo@gnu.org (Ludovic Courtès)
To: Marius Bakke <mbakke@fastmail.com>
Cc: 30761@debbugs.gnu.org
Subject: [bug#30761] [PATCH staging 1/9] gnu: meson: Don't wrap the meson executable.
Date: Mon, 12 Mar 2018 15:00:34 +0100 [thread overview]
Message-ID: <87k1uhpf5p.fsf@gnu.org> (raw)
In-Reply-To: <876061jw9o.fsf@fastmail.com> (Marius Bakke's message of "Mon, 12 Mar 2018 13:47:31 +0100")
Marius Bakke <mbakke@fastmail.com> skribis:
> Ludovic Courtès <ludo@gnu.org> writes:
>
>> Hello!
>>
>> Marius Bakke <mbakke@fastmail.com> skribis:
>>
>>> * gnu/packages/build-tools.scm (meson)[arguments]: Delete WRAP-PHASE.
>>> ---
>>> gnu/packages/build-tools.scm | 5 +++++
>>> 1 file changed, 5 insertions(+)
>>>
>>> diff --git a/gnu/packages/build-tools.scm b/gnu/packages/build-tools.scm
>>> index 2abb44fdb..1ebccca43 100644
>>> --- a/gnu/packages/build-tools.scm
>>> +++ b/gnu/packages/build-tools.scm
>>> @@ -81,6 +81,11 @@ makes a few sacrifices to acquire fast full and incremental build times.")
>>> (base32
>>> "06r8limj38mv884s5riiz6lpzw37cvhbf9jd0smzcbi7fwmv3yah"))))
>>> (build-system python-build-system)
>>> + (arguments
>>> + `(#:phases (modify-phases %standard-phases
>>> + ;; Meson runs itself through the Python interpreter, so
>>> + ;; we cannot use the shell wrapper.
>>> + (delete 'wrap))))
>>
>> I’m not sure what this means. The ‘wrap’ phase is precisely for things
>> with #!/…/python, right?
>>
>> What problem does it solve?
>
> The problem is that at some point after 0.42 (the current
> meson-for-build), Meson does the equivalent of `python $(which meson)`
> at runtime. Which ends up tripping over the shell wrapper.
>
> I don't remember exactly where I saw the problem, it could have been
> with "mesontest" which also resides in "meson/bin". The only downside
> to deleting the wrapper is that you cannot call meson directly from the
> store; it works fine as long as PYTHONPATH is set (e.g. in a profile).
>
> I'll try to clarify the comment.
Yes, that’s a good idea. :-)
It does mean that people installing meson in their profile will get
something missing-python-module errors, right?
Should we do the wrapping differently?
Thanks,
Ludo’.
next prev parent reply other threads:[~2018-03-12 14:01 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-09 18:09 [bug#30761] [PATCH staging 0/9] Meson fixes (and some updates) Marius Bakke
2018-03-09 18:11 ` [bug#30761] [PATCH staging 1/9] gnu: meson: Don't wrap the meson executable Marius Bakke
2018-03-09 18:11 ` [bug#30761] [PATCH staging 2/9] gnu: meson-for-build: Update to 0.44.0 Marius Bakke
2018-03-11 22:18 ` Ludovic Courtès
2018-03-09 18:11 ` [bug#30761] [PATCH staging 3/9] gnu: meson: Update to 0.45.0 Marius Bakke
2018-03-11 22:18 ` Ludovic Courtès
2018-03-09 18:11 ` [bug#30761] [PATCH staging 4/9] build-system/meson: Add the output directory to RUNPATH Marius Bakke
2018-03-11 22:23 ` Ludovic Courtès
2018-03-12 13:04 ` Marius Bakke
2018-03-09 18:11 ` [bug#30761] [PATCH staging 5/9] build-system/meson: Skip the 'fix-runpath' phase on armhf Marius Bakke
2018-03-11 22:24 ` Ludovic Courtès
2018-03-12 13:05 ` Marius Bakke
2018-03-09 18:11 ` [bug#30761] [PATCH staging 6/9] gnu: libinput: Update to 1.10.2 Marius Bakke
2018-03-11 22:25 ` Ludovic Courtès
2018-03-09 18:11 ` [bug#30761] [PATCH staging 7/9] gnu: libinput: Correct inputs Marius Bakke
2018-03-11 22:25 ` Ludovic Courtès
2018-03-12 13:20 ` Marius Bakke
2018-03-09 18:11 ` [bug#30761] [PATCH staging 8/9] gnu: libwacom: Update to 0.29 Marius Bakke
2018-03-11 22:26 ` Ludovic Courtès
2018-03-09 18:11 ` [bug#30761] [PATCH staging 9/9] gnu: xf86-input-wacom: Update to 0.36.0 Marius Bakke
2018-03-11 22:26 ` Ludovic Courtès
2018-05-07 9:54 ` Ludovic Courtès
2018-05-07 14:21 ` bug#30761: " Marius Bakke
2018-03-09 18:16 ` [bug#30761] [PATCH staging 1/9] gnu: meson: Don't wrap the meson executable Marius Bakke
2018-03-11 22:17 ` Ludovic Courtès
2018-03-12 12:47 ` Marius Bakke
2018-03-12 13:08 ` Marius Bakke
2018-03-12 14:01 ` Ludovic Courtès
2018-03-12 14:00 ` Ludovic Courtès [this message]
2018-03-12 14:44 ` Marius Bakke
2018-03-12 16:16 ` Ludovic Courtès
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k1uhpf5p.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=30761@debbugs.gnu.org \
--cc=mbakke@fastmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).