From: Oleg Pykhalov <go.wigust@gmail.com>
To: Konrad Hinsen <konrad.hinsen@fastmail.net>
Cc: 30797-done@debbugs.gnu.org, 30797@debbugs.gnu.org
Subject: bug#30797: [PATCH 1/2] gnu: Add emacs-exec-path-from-shell
Date: Fri, 16 Mar 2018 17:13:45 +0300 [thread overview]
Message-ID: <87k1ucrtuu.fsf@gmail.com> (raw)
In-Reply-To: <m13710z0de.fsf@fastmail.net> (Konrad Hinsen's message of "Fri, 16 Mar 2018 13:11:09 +0100")
[-- Attachment #1: Type: text/plain, Size: 1917 bytes --]
Hello Konrad,
Konrad Hinsen <konrad.hinsen@fastmail.net> writes:
> * gnu/packages/emacs.scm (emacs-exec-path-from-shell): New variable.
> ---
> gnu/packages/emacs.scm | 25 +++++++++++++++++++++++++
> 1 file changed, 25 insertions(+)
>
> diff --git a/gnu/packages/emacs.scm b/gnu/packages/emacs.scm
> index c2c162c75..35acfdd20 100644
> --- a/gnu/packages/emacs.scm
> +++ b/gnu/packages/emacs.scm
> @@ -7361,3 +7361,28 @@ highlighting and indentation support.")
> @uref{https://www.terraform.io/, Terraform} configuration files. Most of the
> functionality is inherited from @code{hcl-mode}.")
> (license license:gpl3+)))
> +
[…]
> + (description
> + "This library allows the user to set Emacs' @code{exec-path} and
I still think this apostrophe is unnecessary. I removed it if you don't
mind. ;-)
- "This library allows the user to set Emacs' @code{exec-path} and
+ "This library allows the user to set Emacs @code{exec-path} and
[…]
In addition, according to Bash documentation [1] variables don't have
‘$’ in their description.
- (synopsis "Get environment variables such as $PATH from the shell")
+ (synopsis "Get environment variables such as @var{PATH} from the shell")
- [1] https://www.gnu.org/software/bash/manual/html_node/Bash-Variables.html
And in the description, we could use ‘@var’ instead of ‘@code’:
-This library allows the user to set Emacs @code{exec-path} and
+This library allows the user to set Emacs @var{exec-path} and
-@code{$PATH} from the shell path, so that @code{shell-command},
+@var{PATH} from the shell @var{PATH}, so that @code{shell-command},
Also don't forget a dot at end the in commit message.
gnu: Add emacs-exec-path-from-shell.
Pushed with changes above as 22d628148ce857b620f5b8e48dc7cabe004313c5
I'll close the bug report.
Thanks,
Oleg.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
next prev parent reply other threads:[~2018-03-16 14:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-13 15:47 [bug#30797] [PATCH 1/2] gnu: Add emacs-exec-path-from-shell Konrad Hinsen
2018-03-15 8:50 ` Oleg Pykhalov
2018-03-16 12:11 ` Konrad Hinsen
2018-03-16 14:13 ` Oleg Pykhalov [this message]
2018-03-16 14:42 ` Konrad Hinsen
2018-03-16 15:05 ` Clément Lassieur
2018-03-16 15:28 ` Konrad Hinsen
2018-03-16 16:16 ` Oleg Pykhalov
2018-03-16 16:16 ` Oleg Pykhalov
2018-03-17 11:46 ` Andreas Enge
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k1ucrtuu.fsf@gmail.com \
--to=go.wigust@gmail.com \
--cc=30797-done@debbugs.gnu.org \
--cc=30797@debbugs.gnu.org \
--cc=konrad.hinsen@fastmail.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).