unofficial mirror of guix-patches@gnu.org 
 help / color / mirror / code / Atom feed
From: ludo@gnu.org (Ludovic Courtès)
To: Marius Bakke <mbakke@fastmail.com>
Cc: 31102@debbugs.gnu.org
Subject: [bug#31102] [PATCH] gnu: wpa-supplicant: Install wpa_gui.
Date: Mon, 09 Apr 2018 22:39:39 +0200	[thread overview]
Message-ID: <87k1tgglmc.fsf@gnu.org> (raw)
In-Reply-To: <20180408202241.10285-1-mbakke@fastmail.com> (Marius Bakke's message of "Sun, 8 Apr 2018 22:22:41 +0200")

Hi Marius,

Marius Bakke <mbakke@fastmail.com> skribis:

> * gnu/packages/admin.scm (wpa-supplicant)[inputs]: Add QTBASE and QTSVG.
> [native-inputs]: Add IMAGEMAGICK and INKSCAPE.
> [outputs]: New field.
> [arguments]: Add phases 'build-wpa-gui' and 'install-wpa-gui'.

The patch LGTM, but I wonder if we should make it a separate package.

Since it uses a separate output, that should be fine *if* you get
substitutes.  If you don’t, then you end up building Qt.

Since wpa_supplicant is a requirement for most GuixSD configs, that
could be an issue.

From the patch, it seems that the GUI is well isolated, in a separate
directory, with a different build system and all.  Do you think it would
work to make a separate “wpa-supplicant-gui” package?  WDYT?

Thanks,
Ludo’.

  reply	other threads:[~2018-04-09 20:40 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-08 20:22 [bug#31102] [PATCH] gnu: wpa-supplicant: Install wpa_gui Marius Bakke
2018-04-09 20:39 ` Ludovic Courtès [this message]
2018-04-23 18:19   ` bug#31102: " Marius Bakke
2018-04-25 22:11     ` [bug#31102] " Ludovic Courtès

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

  List information: https://guix.gnu.org/

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=87k1tgglmc.fsf@gnu.org \
    --to=ludo@gnu.org \
    --cc=31102@debbugs.gnu.org \
    --cc=mbakke@fastmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
Code repositories for project(s) associated with this public inbox

	https://git.savannah.gnu.org/cgit/guix.git

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).