From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51133) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fF3lp-0006Vf-7W for guix-patches@gnu.org; Sat, 05 May 2018 16:27:08 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fF3lm-00013h-2w for guix-patches@gnu.org; Sat, 05 May 2018 16:27:05 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:42957) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fF3lm-00013J-08 for guix-patches@gnu.org; Sat, 05 May 2018 16:27:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fF3ll-0000O3-Kf for guix-patches@gnu.org; Sat, 05 May 2018 16:27:01 -0400 Subject: [bug#31346] [PATCH] gnu: gnuzilla: Add mozjs-52. Resent-Message-ID: From: ludo@gnu.org (Ludovic =?UTF-8?Q?Court=C3=A8s?=) References: <87fu39oiwb.fsf@gnu.org> Date: Sat, 05 May 2018 22:26:12 +0200 In-Reply-To: <87fu39oiwb.fsf@gnu.org> (Roel Janssen's message of "Wed, 02 May 2018 23:19:16 +0200") Message-ID: <87k1shrgrf.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Roel Janssen Cc: 31346@debbugs.gnu.org Hello Roel, Roel Janssen skribis: >>>From ce8b4e85b03ed76fb671a4d554f966b7eac00b8d Mon Sep 17 00:00:00 2001 > From: Roel Janssen > Date: Wed, 2 May 2018 22:11:34 +0200 > Subject: [PATCH] gnu: gnuzilla: Add mozjs-52. > > * gnu/packages/gnuzilla.scm (mozjs-52): New variable. [...] > +(define-public mozjs-52 > + (package > + (inherit mozjs) > + (name "mozjs") You can omit =E2=80=98name=E2=80=99. Also, would it be simpler to inherit from =E2=80=98mozjs-38=E2=80=99? > + (source (origin > + (method url-fetch) > + (uri (string-append > + "https://queue.taskcluster.net/v1/task/" > + "YqG2fjJJSTGzGX090FjDYg/runs/0/artifacts/" > + "public/build/mozjs-" version ".tar.bz2")) Could we use ftp.mozilla.org instead? > + (arguments > + `(#:tests? #f ; Needs Mercurial or Git repository to be avalable. > + #:phases > + (modify-phases %standard-phases > + (replace 'configure > + (lambda* (#:key inputs outputs #:allow-other-keys) > + (let ((out (assoc-ref outputs "out"))) > + (chdir "js/src") > + (setenv "SHELL" (which "sh")) > + (setenv "CONFIG_SHELL" (which "sh")) > + (setenv "AUTOCONF" (string-append > + (assoc-ref inputs "autoconf") > + "/bin/autoreconf")) > + (zero? (system* "./configure" > + (string-append "--prefix=3D" out) > + "--enable-ctypes" > + "--enable-optimize" > + "--enable-pie" > + "--enable-readline" > + "--enable-shared-js" > + "--enable-system-ffi" > + "--with-system-icu" > + "--with-system-nspr" > + "--with-system-zlib" > + > + ;; Intl API requires bundled ICU. > + "--without-intl-api")))))))) This seems to be (almost) the same as for =E2=80=98mozjs-38=E2=80=99. Perh= aps with =E2=80=98inherit=E2=80=99 we don=E2=80=99t need to duplicate all this? Could you look into this? Thank you! Ludo=E2=80=99.