[bug#29819] gnu: virtuoso-ose: Enable fct, isparql, and ods plugins.

[bug#29819] gnu: virtuoso-ose: Enable fct, isparql, and ods plugins.

[Roel Janssen]

[-- Attachment #1: Type: text/plain, Size: 485 bytes --]

Dear Guix,

I'd like to squeeze the most performance out of virtuoso, as well as add
some of the VAD packages to extend its functionality.

I attached the patch, but I have a question about the -m64 flag.  My
impression is that this flag will force a 64-bit build.  Since only
64-bit architectures are supported for this package anyway, I think this
should be fine.  Now, my question is: Does this flag have any effect on
the build?

Thanks for your time!

Kind regards,
Roel Janssen


[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: 0001-gnu-virtuoso-ose-Enable-fct-isparql-and-ods-plugins.patch --]
[-- Type: text/x-patch, Size: 1516 bytes --]

From ffab36dc96d7c17ab699b1e5fa641386ae87f681 Mon Sep 17 00:00:00 2001
From: Roel Janssen <roel@gnu.org>
Date: Fri, 22 Dec 2017 23:03:36 +0100
Subject: [PATCH] gnu: virtuoso-ose: Enable fct, isparql, and ods plugins.

* gnu/packages/databases.scm (virtuoso-ose): Enable fct, isparql, and ods
  plugins.  Also compile with optimization level 2, and compile 64-bit only.
---
 gnu/packages/databases.scm | 10 ++++++++--
 1 file changed, 8 insertions(+), 2 deletions(-)

diff --git a/gnu/packages/databases.scm b/gnu/packages/databases.scm
index a6a7c3178..d802a35c7 100644
--- a/gnu/packages/databases.scm
+++ b/gnu/packages/databases.scm
@@ -1962,10 +1962,16 @@ implementation for Python.")
         (base32 "12dqam1gc1v93l0bj0vlpvjqppki6y1hqrlznywxnw0rrz9pb002"))))
     (build-system gnu-build-system)
     (arguments
-     `(#:tests? #f)) ; Tests require a network connection.
+     `(#:tests? #f ; Tests require a network connection.
+       #:configure-flags '("--with-readline"
+                           "--enable-fct-vad"
+                           "--enable-isparql-vad"
+                           "--enable-ods-vad"
+                           "CFLAGS=-O2 -m64")))
     (inputs
      `(("openssl" ,openssl)
-       ("net-tools" ,net-tools)))
+       ("net-tools" ,net-tools)
+       ("readline" ,readline)))
     (home-page "http://vos.openlinksw.com/owiki/wiki/VOS/")
     (synopsis "Multi-model database system")
     (description "Virtuoso is a scalable cross-platform server that combines
-- 
2.15.1

[bug#29819] gnu: virtuoso-ose: Enable fct, isparql, and ods plugins.

[Danny Milosavljevic]

In my limited understanding "-m64" and "-m32" are for multiarch gccs and we don't support that anyway in Guix gcc, so I don't think it does anything for us.

[bug#29819] gnu: virtuoso-ose: Enable fct, isparql, and ods plugins.

[Ludovic Courtès]

Danny Milosavljevic <dannym@scratchpost.org> skribis:

> In my limited understanding "-m64" and "-m32" are for multiarch gccs and we don't support that anyway in Guix gcc, so I don't think it does anything for us.

Indeed.  Using -m32 on x86_64-linux won't work with our toolchain.

Ludo’.

[bug#29819] gnu: virtuoso-ose: Enable fct, isparql, and ods plugins.

[Ludovic Courtès]

Hi Roel,

Roel Janssen <roel@gnu.org> skribis:

>>From ffab36dc96d7c17ab699b1e5fa641386ae87f681 Mon Sep 17 00:00:00 2001
> From: Roel Janssen <roel@gnu.org>
> Date: Fri, 22 Dec 2017 23:03:36 +0100
> Subject: [PATCH] gnu: virtuoso-ose: Enable fct, isparql, and ods plugins.
>
> * gnu/packages/databases.scm (virtuoso-ose): Enable fct, isparql, and ods
>   plugins.  Also compile with optimization level 2, and compile 64-bit only.
> ---
>  gnu/packages/databases.scm | 10 ++++++++--
>  1 file changed, 8 insertions(+), 2 deletions(-)
>
> diff --git a/gnu/packages/databases.scm b/gnu/packages/databases.scm
> index a6a7c3178..d802a35c7 100644
> --- a/gnu/packages/databases.scm
> +++ b/gnu/packages/databases.scm
> @@ -1962,10 +1962,16 @@ implementation for Python.")
>          (base32 "12dqam1gc1v93l0bj0vlpvjqppki6y1hqrlznywxnw0rrz9pb002"))))
>      (build-system gnu-build-system)
>      (arguments
> -     `(#:tests? #f)) ; Tests require a network connection.
> +     `(#:tests? #f ; Tests require a network connection.
> +       #:configure-flags '("--with-readline"
> +                           "--enable-fct-vad"
> +                           "--enable-isparql-vad"
> +                           "--enable-ods-vad"
> +                           "CFLAGS=-O2 -m64")))
>      (inputs
>       `(("openssl" ,openssl)
> -       ("net-tools" ,net-tools)))
> +       ("net-tools" ,net-tools)
> +       ("readline" ,readline)))

This patch without the CFLAGS bit would be fine, if you still need it.

Thoughts?

Ludo’.

[bug#29819] gnu: virtuoso-ose: Enable fct, isparql, and ods plugins.

[Roel Janssen]

Ludovic Courtès <ludo@gnu.org> writes:

> Hi Roel,
>
> Roel Janssen <roel@gnu.org> skribis:
>
>>>From ffab36dc96d7c17ab699b1e5fa641386ae87f681 Mon Sep 17 00:00:00 2001
>> From: Roel Janssen <roel@gnu.org>
>> Date: Fri, 22 Dec 2017 23:03:36 +0100
>> Subject: [PATCH] gnu: virtuoso-ose: Enable fct, isparql, and ods plugins.
>>
>> * gnu/packages/databases.scm (virtuoso-ose): Enable fct, isparql, and ods
>>   plugins.  Also compile with optimization level 2, and compile 64-bit only.
>> ---
>>  gnu/packages/databases.scm | 10 ++++++++--
>>  1 file changed, 8 insertions(+), 2 deletions(-)
>>
>> diff --git a/gnu/packages/databases.scm b/gnu/packages/databases.scm
>> index a6a7c3178..d802a35c7 100644
>> --- a/gnu/packages/databases.scm
>> +++ b/gnu/packages/databases.scm
>> @@ -1962,10 +1962,16 @@ implementation for Python.")
>>          (base32 "12dqam1gc1v93l0bj0vlpvjqppki6y1hqrlznywxnw0rrz9pb002"))))
>>      (build-system gnu-build-system)
>>      (arguments
>> -     `(#:tests? #f)) ; Tests require a network connection.
>> +     `(#:tests? #f ; Tests require a network connection.
>> +       #:configure-flags '("--with-readline"
>> +                           "--enable-fct-vad"
>> +                           "--enable-isparql-vad"
>> +                           "--enable-ods-vad"
>> +                           "CFLAGS=-O2 -m64")))
>>      (inputs
>>       `(("openssl" ,openssl)
>> -       ("net-tools" ,net-tools)))
>> +       ("net-tools" ,net-tools)
>> +       ("readline" ,readline)))
>
> This patch without the CFLAGS bit would be fine, if you still need it.
>
> Thoughts?

In commit 6d09a7b5e I added --with-readline.  I couldn't find the bug
report, but I believe the extra plugins (ODS and facetted browser
(FCT)) cannot be activated due to a bug in Virtuoso's plugin loading
function.  This bug has been resolved, but the fix isn't present in this
released version.

So I guess we can close this one and wait for the next release to
re-evaluate whether we can build these extra plugins.

WDYT?

Kind regards,
Roel Janssen

[bug#29819] gnu: virtuoso-ose: Enable fct, isparql, and ods plugins.

[Ludovic Courtès]

Roel Janssen <roel@gnu.org> skribis:

> So I guess we can close this one and wait for the next release to
> re-evaluate whether we can build these extra plugins.
>
> WDYT?

Sounds good.  I just wanted to make sure we weren’t forgetting about
it.  :-)

Ludo’.

bug#29819: gnu: virtuoso-ose: Enable fct, isparql, and ods plugins.

[Roel Janssen]

Ludovic Courtès <ludo@gnu.org> writes:

> Roel Janssen <roel@gnu.org> skribis:
>
>> So I guess we can close this one and wait for the next release to
>> re-evaluate whether we can build these extra plugins.
>>
>> WDYT?
>
> Sounds good.  I just wanted to make sure we weren’t forgetting about
> it.  :-)
>
> Ludo’.

Marked this as done as all *working* changes that I wanted to apply here
have been applied in another patch.

Thanks for bringing this to my attention!

Kind regards,
Roel Janssen