From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:51469) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fXpXi-0001tv-6r for guix-patches@gnu.org; Tue, 26 Jun 2018 11:06:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fXpXe-00062d-V7 for guix-patches@gnu.org; Tue, 26 Jun 2018 11:06:06 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:56703) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fXpXe-00062H-Rg for guix-patches@gnu.org; Tue, 26 Jun 2018 11:06:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fXpXe-0001By-IO for guix-patches@gnu.org; Tue, 26 Jun 2018 11:06:02 -0400 Subject: bug#31969: [PATCH] bootloader: grub-efi: Identify as "GuixSD" instead of "grub". Resent-To: guix-patches@gnu.org Resent-Message-ID: From: Marius Bakke In-Reply-To: <87woul3aqq.fsf@gnu.org> References: <20180625205015.2811-1-mbakke@fastmail.com> <87woul3aqq.fsf@gnu.org> Date: Tue, 26 Jun 2018 17:05:42 +0200 Message-ID: <87k1qly4e1.fsf@fastmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 31969-done@debbugs.gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable ludo@gnu.org (Ludovic Court=C3=A8s) writes: > Marius Bakke skribis: > >> * gnu/bootloader/grub.scm (install-grub-efi): Pass "--bootloader-id" to = grub-install. >> --- >> gnu/bootloader/grub.scm | 1 + >> 1 file changed, 1 insertion(+) >> >> diff --git a/gnu/bootloader/grub.scm b/gnu/bootloader/grub.scm >> index 8f45995ca..538ddc37a 100644 >> --- a/gnu/bootloader/grub.scm >> +++ b/gnu/bootloader/grub.scm >> @@ -403,6 +403,7 @@ submenu \"GNU system, old configurations...\" {~%") >> ;; root partition. >> (setenv "GRUB_ENABLE_CRYPTODISK" "y") >> (unless (zero? (system* grub-install "--boot-directory" install= -dir >> + "--bootloader-id=3DGuixSD" > > What does it do? I can=E2=80=99t even find it in the manual. UEFI firmwares contain a list of boot entries that looks roughly like "foo: uuid,partnum,/path/to/loader". Try `efibootmgr -v` on an EFI system for a more practical example. If nothing is specified, GRUB will identify as "grub". With this patch, when you look through the possible boot entries in UEFI, there will be no doubt which one is GuixSD :-) However there is one other practical consequence: the GRUB EFI blob will now be installed to "/boot/efi/EFI/GuixSD/grubx64.efi". So current UEFI GuixSD users will have a stale "/boot/efi/EFI/grub" folder that is no longer needed. > Otherwise no objections from me. Great, I'll push this shortly. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlsyVkcACgkQoqBt8qM6 VPp+AwgArqv5nZW2S4f9TU/Cf7AoPKRDsFrvmBvqa9ivH8V4aJ3voDs23zfSSgPE m6CkFWiOQG8DNsv4Y55iviUz5fY0OSJAmeh02pWpnroyLwnitx0BLgyGnnM2g2ei zqTSYxpU7RMts9EtkM8TGrHZoj4oMLOglz+njrwX5G0XVn0/NiPVjEarmS00JJMQ Y1Ihgubvljq5aj4t08pKlcCP4kfagMhmMffIvubYrGtJYA3sfyXolKNLLFp59a6a sAIFBUwyGyQ0K0IJEPsUUWhu2gHMmYPj9ywDcPf+tDevBlten3uCXX982TfRbl5v jQaw8dR+1lpda/2q2jHB4xrpaCVFug== =hb1y -----END PGP SIGNATURE----- --=-=-=--