From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:42576)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fcQiN-0003Og-If
	for guix-patches@gnu.org; Mon, 09 Jul 2018 03:36:08 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fcQiH-0007Ij-Vi
	for guix-patches@gnu.org; Mon, 09 Jul 2018 03:36:07 -0400
Received: from debbugs.gnu.org ([208.118.235.43]:43781)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1fcQiH-0007If-Rn
	for guix-patches@gnu.org; Mon, 09 Jul 2018 03:36:01 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1fcQiH-0002F5-Kq
	for guix-patches@gnu.org; Mon, 09 Jul 2018 03:36:01 -0400
Subject: [bug#32102] [PATCH] utils: Fix wrap-program filename generation.
Resent-Message-ID: <handler.32102.B32102.15311217158564@debbugs.gnu.org>
References: <20180709013103.26091-1-arunisaac@systemreboot.net>
From: =?UTF-8?Q?Cl=C3=A9ment?= Lassieur <clement@lassieur.org>
In-reply-to: <20180709013103.26091-1-arunisaac@systemreboot.net>
Date: Mon, 09 Jul 2018 09:35:11 +0200
Message-ID: <87k1q4j1zk.fsf@lassieur.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Arun Isaac <arunisaac@systemreboot.net>
Cc: 32102@debbugs.gnu.org

Hi Arun,

Arun Isaac <arunisaac@systemreboot.net> writes:

> * guix/build/utils.scm (wrap-program): While generating a new filename fo=
r the
> wrapped program, trim dots from the left of the basename. This prevents
> already wrapped files being wrapped again with two or more dots prepended=
 to
> them.

Why is it a problem that two or more dots are prepended to them?

It means that 'foo' and '.foo' will have the same generated file name
'.foo-real'.  Wrapping a hidden file and its non-hidden counterpart is
something that probably shouldn't happen, but if for some reason it must
happen, we'll face an annoying bug.  WDYT?

Cl=C3=A9ment