From: Oleg Pykhalov <go.wigust@gmail.com>
To: "Ludovic Courtès" <ludo@gnu.org>
Cc: 32094@debbugs.gnu.org, 32094-done@debbugs.gnu.org
Subject: bug#32094: [PATCH] git: Call 'url-cache-directory' outside 'update-cached-checkout' body.
Date: Fri, 13 Jul 2018 16:26:27 +0300 [thread overview]
Message-ID: <87k1pzgtbw.fsf@gmail.com> (raw)
In-Reply-To: <87in5mnl9y.fsf@gnu.org> ("Ludovic \=\?utf-8\?Q\?Court\=C3\=A8s\=22'\?\= \=\?utf-8\?Q\?s\?\= message of "Wed, 11 Jul 2018 12:01:45 +0200")
[-- Attachment #1: Type: text/plain, Size: 1226 bytes --]
Hello Ludovic,
ludo@gnu.org (Ludovic Courtès) writes:
[…]
>> I'm not sure it's possible to call ‘url-cache-directory’ in argument of
>> ‘update-cached-checkout’, because ‘url-cache-directory’ requires ‘url’
>> argument which itself is the argument of ‘update-cached-checkout’.
>
> Yes, you can do that:
>
> (define* (update-cached-checkout url
> #:key
> (ref '(branch . "origin/master"))
> (cache-directory
> (url-cache-directory
> url (%repository-cache-directory))))
> …)
>
> (You’d get a warning about ‘url’ being unbound if it didn’t work.)
Ah, thank you for pointing it out.
> Could you make this last change? And then I think we’re all set.
OK, added. I tested second time successfully with:
--8<---------------cut here---------------start------------->8---
./pre-inst-env env GUIX_PACKAGE_PATH= guix pull
--8<---------------cut here---------------end--------------->8---
Pushed as ffc3fcade3f7d2c7d26b2fe5245902e6407f9c93
Thanks,
Oleg.
[-- Attachment #2: signature.asc --]
[-- Type: application/pgp-signature, Size: 832 bytes --]
prev parent reply other threads:[~2018-07-13 13:27 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-07-08 10:19 [bug#32094] [PATCH] git: Call 'url-cache-directory' outside 'update-cached-checkout' body Oleg Pykhalov
2018-07-08 10:24 ` Oleg Pykhalov
2018-07-09 14:43 ` Ludovic Courtès
2018-07-10 3:39 ` Oleg Pykhalov
2018-07-11 10:01 ` Ludovic Courtès
2018-07-13 13:26 ` Oleg Pykhalov [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k1pzgtbw.fsf@gmail.com \
--to=go.wigust@gmail.com \
--cc=32094-done@debbugs.gnu.org \
--cc=32094@debbugs.gnu.org \
--cc=ludo@gnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).