From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:45127) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1fjucc-0000IU-Fc for guix-patches@gnu.org; Sun, 29 Jul 2018 18:57:07 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1fjucY-0006o8-Hq for guix-patches@gnu.org; Sun, 29 Jul 2018 18:57:06 -0400 Received: from debbugs.gnu.org ([208.118.235.43]:57403) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1fjucY-0006o2-DP for guix-patches@gnu.org; Sun, 29 Jul 2018 18:57:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1fjucY-0003jy-0l for guix-patches@gnu.org; Sun, 29 Jul 2018 18:57:02 -0400 Subject: [bug#31999] [PATCH 6/7] gnu: Add libblockdev. Resent-Message-ID: From: Marius Bakke In-Reply-To: <20180628213527.23318-5-ambrevar@gmail.com> References: <20180628213527.23318-1-ambrevar@gmail.com> <20180628213527.23318-5-ambrevar@gmail.com> Date: Mon, 30 Jul 2018 00:56:14 +0200 Message-ID: <87k1pd3b3l.fsf@fastmail.com> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Pierre Neidhardt , 31999@debbugs.gnu.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Pierre Neidhardt writes: > * gnu/package/disk.scm (libblockdev): New variable. [...] > +(define-public libblockdev > + (package > + (name "libblockdev") > + (version "2.17") > + (source (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/rhinstaller/libblockdev") > + (commit (string-append version "-1")))) > + (file-name (string-append name "-" version "-checkout")) > + (sha256 > + (base32 > + "14f52cj2qcnm8i2zb57qfpdk3kij2gb3xgqkbvidmf6sjicq84z2"))= )) This project also provides uploaded releases. Please use those when available. Also, 2.18 is out! > + (build-system gnu-build-system) > + (native-inputs > + `(("python" ,python) > + ("gobject-introspection" ,gobject-introspection) > + ("automake" ,automake) > + ("autocont" ,autoconf) > + ("libtool" ,libtool) > + ("glib" ,glib) > + ("util-linux" ,util-linux) > + ("nss" ,nss) > + ("cryptsetup" ,cryptsetup) > + ("eudev" ,eudev) > + ("pkg-config" ,pkg-config))) That's a lot of native dependencies! I would assume glib, cryptsetup and eudev at least were "normal" inputs, I guess they are needed for tests? Can you add a comment about it? > + (inputs > + `(("btrfs-progs" ,btrfs-progs) > + ("dosfstools" ,dosfstools) > + ("dmraid" ,dmraid) > + ("libbytesize" ,libbytesize) > + ("lvm2" ,lvm2) > + ("mdadm" ,mdadm) > + ("ndctl" ,ndctl) > + ("mdadm" ,mdadm) > + ("parted" ,parted) > + ("volume-key" ,volume-key) > + ;; ("xfsprogs" ,xfsprogs) ; TODO: Package? > + ("kmod" ,kmod) > + )) These parenthesis feel lonely ;-) > + (arguments > + `(#:phases > + (modify-phases %standard-phases > + (add-after 'unpack 'autogen > + (lambda _ > + (invoke "sh" "autogen.sh")))))) Try removing this phase here too, or replace 'bootstrap' :-) > + (home-page "https://github.com/rhinstaller/libblockdev") > + (synopsis "A library for manipulating block devices") s/A library/C library/ to please `guix lint` :-) =20 > + (description > + "libblockdev is a C library supporting GObject introspection for > +manipulation of block devices. It has a plugin-based architecture where = each > +technology (like LVM, Btrfs, MD RAID, Swap,...) is implemented in a sepa= rate > +plugin, possibly with multiple implementations (e.g. using LVM CLI or th= e new > +LVM DBus API).") Remember two spaces between sentences (guix lint should warn about this too= ). Also s/DBus/D-Bus/ > + (license license:lgpl2.1+))) Most of the source files are GPL2+, actually. Not a single source file includes the LGPL header, though some are missing licensing information. I'd write this as: ;; XXX: Copying says LGPL2.1, but the source files with license ;; information are GPL2+. (license license:gpl2+))) --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAlteRg4ACgkQoqBt8qM6 VPpCzAgAso92+JuA3RNuNAnVpraMrUtYdB2izrUj7TVa4RCpo2cqc9KMIjvP4BYK tybxnSDUCEAzmt4i6fUd63XlX5SojYiV4hXZaPT04daooezmdDaZNLT+BPSao1XM AwVMhr6qmvF4bowxwzQAOItGMMrD/AssejFESMir2g2YGLihoW1SYX/M1A4KaQWZ 2IYUJBERKgvyjbbZ2dPj0g1MVKzapJnA3PkwwflvxMzivudhulNcmsiznJf8aa8i TK9Ku1l1GgMAnKxyMNuIVloFphXCfxS16TTWaLYgWR11U6bwNEa2+P3ER+CACk2T 04rkwU68tyeU58g2PhwQ1FRej1buzA== =v+T4 -----END PGP SIGNATURE----- --=-=-=--