From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:51849)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gZjbP-0005pw-TN
	for guix-patches@gnu.org; Wed, 19 Dec 2018 16:42:05 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gZjbO-00013W-Ou
	for guix-patches@gnu.org; Wed, 19 Dec 2018 16:42:03 -0500
Received: from debbugs.gnu.org ([208.118.235.43]:50903)
	by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
	(Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
	id 1gZjbO-00013O-KX
	for guix-patches@gnu.org; Wed, 19 Dec 2018 16:42:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
	(envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1gZjbO-0004Yj-GP
	for guix-patches@gnu.org; Wed, 19 Dec 2018 16:42:02 -0500
Subject: [bug#33800] [PATCH] gnu: Add grim.
Resent-Message-ID: <handler.33800.B33800.154525566217437@debbugs.gnu.org>
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
References: <20181219103851.7cbbd4f2@mykolab.com>
Date: Wed, 19 Dec 2018 22:40:48 +0100
In-Reply-To: <20181219103851.7cbbd4f2@mykolab.com> (Rutger Helling's message
	of "Wed, 19 Dec 2018 10:38:51 +0100")
Message-ID: <87k1k5tctb.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <http://lists.gnu.org/archive/html/guix-patches/>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
	<mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Rutger Helling <rhelling@mykolab.com>
Cc: 33800@debbugs.gnu.org

Hi,

Rutger Helling <rhelling@mykolab.com> skribis:

> From a55c2fedeca18627e8f0aa23efc0c78e846e40ee Mon Sep 17 00:00:00 2001
> From: Rutger Helling <rhelling@mykolab.com>
> Date: Wed, 19 Dec 2018 10:27:28 +0100
> Subject: [PATCH 1/2] gnu: Add scdoc.
>
> * gnu/packages/man.scm (scdoc): New variable.

[...]

> +   (home-page "https://git.sr.ht/~sircmpwn/scdoc")
> +   (synopsis "Simple man page generator")
> +   (description "scdoc is a simple man page generator written for POSIX =
systems
> +written in C99.")

s/written in C99/in C99/

> +   ;; MIT license, see /share/doc/scdoc-1.6.0/COPYING.
> +   (license (x11-style "file://COPYING"))))

Should be =E2=80=98license:expat=E2=80=99.

> From 793ae79c8bbd68b981f4c4b94b43784011776ede Mon Sep 17 00:00:00 2001
> From: Rutger Helling <rhelling@mykolab.com>
> Date: Wed, 19 Dec 2018 10:31:50 +0100
> Subject: [PATCH 2/2] gnu: Add grim.
>
> * gnu/packages/image.scm (grim): New variable.

[...]

> +(define-public grim
> +  (package
> +  (name "grim")
> +  (version "1.0")
> +  (source
> +   (origin
> +    (method url-fetch)
> +    (uri (string-append "https://github.com/emersion/grim/archive/v" ver=
sion
> +                        ".tar.gz"))
> +    (file-name (string-append name "-" version ".tar.gz"))
> +    (sha256
> +     (base32 "0xkk5nqyp1px0sxz4asmchznc0q39wdx1b67ql741k8aj815km0f"))))
> +  (build-system meson-build-system)
> +  (native-inputs `(("pkg-config" ,pkg-config)))
> +  (inputs `(("cairo" ,cairo)
> +            ("libjpeg-turbo" ,libjpeg-turbo)
> +            ("scdoc" ,scdoc)
> +            ("wayland" ,wayland)
> +            ("wayland-protocols" ,wayland-protocols)))
> +  (home-page "https://github.com/emersion/grim")
> +  (synopsis "Grab images from a Wayland compositor")
> +  (description "grim can grab images from a Wayland compositor.")

s/grab images/create screenshots/ ?  That would make it easier to find
via =E2=80=98guix package -s=E2=80=99.  :-)

> +  ;; MIT license.
> +  (license (license:x11-style
> +"https://raw.githubusercontent.com/emersion/grim/master/LICENSE"))))

=E2=80=98license:expat=E2=80=99 as well, AFAICS:

  https://directory.fsf.org/wiki/License:Expat

OK with these changes, thanks!

Ludo=E2=80=99.