From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:37456) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1h0v2C-0001D1-HE for guix-patches@gnu.org; Mon, 04 Mar 2019 16:22:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1h0v2B-0005Ir-N3 for guix-patches@gnu.org; Mon, 04 Mar 2019 16:22:04 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:46754) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1h0v2A-0005H8-Kd for guix-patches@gnu.org; Mon, 04 Mar 2019 16:22:03 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1h0v2A-0000ZA-C7 for guix-patches@gnu.org; Mon, 04 Mar 2019 16:22:02 -0500 Subject: [bug#34650] [PATCH 3/7] gnu: Add ruby-mustermann. Resent-Message-ID: References: <87ftsa24ts.fsf@ambrevar.xyz> <20190228174435.14499-1-mail@ambrevar.xyz> <20190228174435.14499-3-mail@ambrevar.xyz> From: Christopher Baines In-reply-to: <20190228174435.14499-3-mail@ambrevar.xyz> Date: Mon, 04 Mar 2019 21:20:57 +0000 Message-ID: <87k1hefi9y.fsf@cbaines.net> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Pierre Neidhardt Cc: 34650@debbugs.gnu.org --=-=-= Content-Type: text/plain Pierre Neidhardt writes: > * gnu/packages/ruby.scm (ruby-mustermann): New variable. > --- > gnu/packages/ruby.scm | 22 ++++++++++++++++++++++ > 1 file changed, 22 insertions(+) > > diff --git a/gnu/packages/ruby.scm b/gnu/packages/ruby.scm > index f6b6a19d5..1c10a16c2 100644 > --- a/gnu/packages/ruby.scm > +++ b/gnu/packages/ruby.scm > @@ -7708,3 +7708,25 @@ systems that support multiple template engines but don't want to code for each > of them individually.") > (home-page "https://github.com/rtomayko/tilt/") > (license license:expat))) > + > +(define-public ruby-mustermann > + (package > + (name "ruby-mustermann") > + (version "1.0.3") > + (source > + (origin > + (method url-fetch) > + (uri (rubygems-uri "mustermann" version)) > + (sha256 > + (base32 > + "0lycgkmnyy0bf29nnd2zql5a6pcf8sp69g9v4xw0gcfcxgpwp7i1")))) > + (build-system ruby-build-system) > + (arguments > + ;; TODO: Fix tests. > + `(#:tests? #f)) Could you include some details of what is broken about the tests? Even just a bit of the error message if there is one. Also, I'd usually use a single quote unless a backtick is necessary. > + (synopsis "Library implementing patterns that behave like regular expressions") > + (description "Given a string pattern, Mustermann will turn it into an > +object that behaves like a regular expression and has comparable performance > +characteristics.") > + (home-page "https://github.com/sinatra/mustermann") > + (license license:expat))) I'd recommend trying to avoid inserting packages at the end of modules, or generally in the same place. This can make rebases difficult, and increase the chances of conflicts when going to apply patches. I generally try to fit patches in to modules somewhat alphabetically. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQKTBAEBCgB9FiEEPonu50WOcg2XVOCyXiijOwuE9XcFAlx9lrlfFIAAAAAALgAo aXNzdWVyLWZwckBub3RhdGlvbnMub3BlbnBncC5maWZ0aGhvcnNlbWFuLm5ldDNF ODlFRUU3NDU4RTcyMEQ5NzU0RTBCMjVFMjhBMzNCMEI4NEY1NzcACgkQXiijOwuE 9Xfvvw//ak6SNDwOK3N3G4qiOjrvErodQwmxVfIpoa9VOT5C4gaheZsmzK/55XjW iqAeFL1kmy/sWoJoMtbYzjS3MPQrVBB86pB7R+1MMjr3ZLa4uliFg/iqGOmmoehh k96cLpBCbq5bXi3POwCAlSdVWr+Yag1wXFjx2bjoup3f1EAssANPbzMmXEHIf7QD p8XfOymZkuufLRT3vq0pwOFrV1kLeEh33KBs9plJ+HhQ1XlSkPW0LSQDoUkn7dJz kiZviM7QmPOO6qGhgkEm0D9+4D4/s2Itk8+/nprKEJd+9VJCRuQOkRWQLVm+bFnR kNZa8EnSSrD2IcPX+EphFgbTvTZmOOfVkkmX4/oZeMxrZrWFLvY5+i7fMphW8nn7 pabZZhZzrOZyu3JctnOfyUzUr62bTf0jcezpDMBq8kmsqsf1hITTuuDDrYVSq1hw 4LoeuHBMEG18NA5wlKxfFr1RiXq3BuYsD67XC0kOVR6i3Jl3qx4Ql5eupc+uAmtJ ifZiR1rJOmJnvhLOyx92VCEw4nwtk6KnYgZnMIEgFf5iLrm35tZLPEhIvgj70Ml5 PPXy7Yq30USdaomQnprCSG/8NNmwl4TQff9RGevtEBiqiKUgehG8SzjKwwHQqF8s CqSXcdiRkPxn6PEDpLn3TgPrhYuZ72jTEt3OqDw1LeuGO8oInGw= =WHq5 -----END PGP SIGNATURE----- --=-=-=--