From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:56377) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hJJjk-0003Ps-4i for guix-patches@gnu.org; Wed, 24 Apr 2019 11:23:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hJJji-0003H7-GR for guix-patches@gnu.org; Wed, 24 Apr 2019 11:23:04 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:42672) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hJJji-0003Gc-5v for guix-patches@gnu.org; Wed, 24 Apr 2019 11:23:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hJJjh-000556-TI for guix-patches@gnu.org; Wed, 24 Apr 2019 11:23:01 -0400 Subject: [bug#35411] [PATCH] Add hedgewars Resent-Message-ID: References: <87y33zrfyu.fsf@nicolasgoaziou.fr> <87mukf65wr.fsf@elephly.net> <87sgu7r5ca.fsf@nicolasgoaziou.fr> From: Ricardo Wurmus In-reply-to: <87sgu7r5ca.fsf@nicolasgoaziou.fr> Date: Wed, 24 Apr 2019 17:20:45 +0200 Message-ID: <87k1fj5t0y.fsf@elephly.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Nicolas Goaziou Cc: 35411@debbugs.gnu.org Hi Nicolas, >> What is this Pascal to C translator? Does this mean that we=E2=80=99re = using >> generated C files here? > > It is a Haskell program, named pas2c, bundled with hedgewars. See > . AFAIU, it > turns ".pas" files into ".c", and the build process compiles those. IOW, > it looks good enough. Oh neat, this is great! Let me go through the rest of the patch: > +(define-public hedgewars > + (package > + (name "hedgewars") > + (version "0.9.25") > + (source (origin > + (method hg-fetch) > + (uri (hg-reference > + (url "https://hg.hedgewars.org/hedgewars/") > + (changeset (string-append version "-release")))) Is there no release tarball? [=E2=80=A6] > + (add-after 'unpack 'remove-failing-test > + ;; XXX: Remove single failing test. > + (lambda _ > + (delete-file "tests/lua/staticmines.lua") > + #t)) Do you know why it fails? Is this an upstream problem or likely something to do with Guix? > + (add-after 'unpack 'fix-compiler > + ;; XXX: Flag BUILD_ENGINE_C, as set above, implies using Clan= g to > + ;; compile files. However, using `clang' globally leads to t= he > + ;; following issue: > + ;; "qtbase-5.11.3/include/qt5/QtCore/qglobal.h:45:12: fatal e= rror: > + ;; 'type_traits' file not found". Is it really necessary to compile with Clang at all? What happens if you compile with GCC? > + (inputs > + `(("clang" ,clang) Is this not actually a native input? > + ("ffmpeg" ,ffmpeg) > + ("freeglut" ,freeglut) > + ("ghc" ,ghc) I think this also might be a native input. > + (synopsis "Funny turn-based artillery game, featuring fighting hedge= hogs!") Please remove the final exclamation point and the comma. Maybe remove =E2=80=9CFunny=E2=80=9D because that=E2=80=99s subjective, but feel free to= ignore me. > + "Each player controls a team of several hedgehogs. During the cour= se of > +the game, players take turns with one of their hedgehogs. They then use > +whatever tools and weapons are available to attack and kill the opponent= s' > +hedgehogs, thereby winning the game. > + > +Hedgehogs may move around the terrain in a variety of ways, normally by > +walking and jumping but also by using particular tools such as the ``Rop= e'' or > +``Parachute'', to move to otherwise inaccessible areas. Each turn is > +time-limited to ensure that players do not hold up the game with excessi= ve > +thinking or moving. A large variety of tools and weapons are available = for > +players during the game: Grenade, Cluster Bomb, Bazooka, UFO, Homing Bee, > +Shotgun, Desert Eagle, Fire Punch, Baseball Bat, Dynamite, Mine, Rope, > +Pneumatic pick, Parachute. Most weapons, when used, cause explosions th= at > +deform the terrain, removing circular chunks. > + > +The landscape is an island floating on a body of water, or a restricted = cave > +with water at the bottom. A hedgehog dies when it enters the water (eit= her by > +falling off the island, or through a hole in the bottom of it), it is th= rown > +off either side of the arena or when its health is reduced, typically fr= om > +contact with explosions, to zero (the damage dealt to the attacked hedge= hog or > +hedgehogs after a player's or CPU turn is shown only when all movement o= n the > +battlefield has ceased).") The description is a bit long. We don=E2=80=99t need a list of weapons or = the rules of the game (=E2=80=9Cdies when it enters the water=E2=80=9D). Could= you try to shorten it and make sure that the first sentence describes what this is all about? Thanks for packaging it! -- Ricardo