From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([209.51.188.92]:58317) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1hVXlA-0007L1-0T for guix-patches@gnu.org; Tue, 28 May 2019 04:47:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hVXl8-0004Xf-Po for guix-patches@gnu.org; Tue, 28 May 2019 04:47:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:41486) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hVXl8-0004XY-NZ for guix-patches@gnu.org; Tue, 28 May 2019 04:47:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hVXl8-0003ow-Kl for guix-patches@gnu.org; Tue, 28 May 2019 04:47:02 -0400 Subject: [bug#35880] [PATCH 1/7] lzlib: Add 'make-lzip-input-port/compressed'. Resent-Message-ID: From: Pierre Neidhardt In-Reply-To: <877eab3tjq.fsf@gnu.org> References: <20190524134238.22802-1-ludo@gnu.org> <87d0k6o3am.fsf@ambrevar.xyz> <87ftp1m1te.fsf@gnu.org> <87blznsxym.fsf@gnu.org> <87ef4jlvbr.fsf@ambrevar.xyz> <87lfyrr554.fsf@gnu.org> <87sgszk3ev.fsf@ambrevar.xyz> <877eab3tjq.fsf@gnu.org> Date: Tue, 28 May 2019 10:46:23 +0200 Message-ID: <87k1ebj7a8.fsf@ambrevar.xyz> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Ludovic =?UTF-8?Q?Court=C3=A8s?= Cc: 35880-done@debbugs.gnu.org --=-=-= Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Ludovic Court=C3=A8s writes: >> Bigger oops! This comes from a copy-paste of the gzip docstring which I >> forgot to update properly (I did for the decompression functions, but >> not for the compression functions). The docstrings should be fixed. > > I fixed this one in e13354a7ca5a0d5e28e02c4cfce6fecb1ab770e4. Thanks! >> The thing is that we are not using lzlib as it is meant to be used >> (i.e. with the finish* functions) because of the functional approach of >> the binary ports which don't really play well with the procedural >> approach of the C library. > > I think we=E2=80=99re using it the way it=E2=80=99s meant to be used, rou= ghly along the > lines of the examples of its manual (info "(lzlib) Examples"). > > (I/O ports are not very =E2=80=9Cfunctional=E2=80=9D.) In the sense that we define "read!" and "write!" functions which don't allow us to call the "finish" functions properly. So maybe we are following the doc too "roughly" :p This has multiple implications, e.g. it impedes support for multiple members, (which is OK as long as we don't accept archives produced by a third-party) and more importantly it lifts the guarantee that the library is going to work as per the documentation. >>> And I pushed the whole thing! :-) >> >> Hurray! Can't wait to say lz-compressed archives coming to Guix! :) > > I=E2=80=99ve updated the =E2=80=98guix=E2=80=99 package so people can sta= rt using > =E2=80=98guix publish -C lzip=E2=80=99 and fetch substitute from there. > > Thanks for making it possible! And thanks for doing most of the work! :D =2D-=20 Pierre Neidhardt https://ambrevar.xyz/ --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEUPM+LlsMPZAEJKvom9z0l6S7zH8FAlzs9V8ACgkQm9z0l6S7 zH9g/wf/W8poG5k/FJeEiNVfNW/FLFHiYB+NB5gv3IE0ElpgOe3Y/GyX0J4J5D5E UjHqng7N+uy1eTS6BU2PEE4G4w8JQdXGC4pcHkZzdT+rfT8l/GQfI79fcyfRQE/d 491T8CN3AzWnJz4a/WcZct58RIsML4WRyaL52gnmKJzFfCc6RJd5wb1rqBO5LUjK rGgBdPsbnqpImrJlINDKxPu9mSfwUEI5wLiDB7uVyywsZTlT7nhb0dOCkXbdgqWZ +7oxKlIsYawKjdCfZKE6cb60baYeOCjBvVWtMxuhVKTU1dFVKJT26tIc0tOGcSKL ga2s26/cBDZIx6xxLDjzhoLVfe1tvQ== =U6r2 -----END PGP SIGNATURE----- --=-=-=--