From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:49678) by lists.gnu.org with esmtp (Exim 4.86_2) (envelope-from ) id 1hmxAN-0007zP-8r for guix-patches@gnu.org; Mon, 15 Jul 2019 05:21:04 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1hmxAM-0004e4-5d for guix-patches@gnu.org; Mon, 15 Jul 2019 05:21:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:37555) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1hmxAL-0004ci-VG for guix-patches@gnu.org; Mon, 15 Jul 2019 05:21:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1hmxAL-00068R-QJ for guix-patches@gnu.org; Mon, 15 Jul 2019 05:21:01 -0400 Subject: [bug#35790] [PATCH 1/2] lint: Move the linting code to a different module. Resent-Message-ID: From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <87a7dyoryh.fsf@gnu.org> <20190702192542.16179-1-mail@cbaines.net> <87pnmfgw03.fsf@gnu.org> <87wogkh4s0.fsf@cbaines.net> Date: Mon, 15 Jul 2019 11:20:36 +0200 In-Reply-To: <87wogkh4s0.fsf@cbaines.net> (Christopher Baines's message of "Sun, 14 Jul 2019 19:03:59 +0100") Message-ID: <87k1cjr6vv.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Christopher Baines Cc: 35790@debbugs.gnu.org Hi Chris! Christopher Baines skribis: > Ludovic Court=C3=A8s writes: > >> Christopher Baines skribis: >> >>> To try and move towards making programatic access to the linting code e= asier, >>> this commit separates out the linting script, from the linting function= ality >>> that it uses. >> >> For the final version, please write a change log. > > Sure, any suggestions about how to write it? I wasn't sure whether to > list everything that had been moved from (guix scripts lint) to (guix > lint), or say that the file has moved, and list the things that have > been moved back. Maybe something like: * guix/scripts/lint.scm (check-foo, check-bar): Move to=E2=80=A6 * guix/lint.scm: =E2=80=A6 here. and also mention things that go beyond simply moving things around (if applicable). But again, don=E2=80=99t spend a whole day on this, it=E2=80=99s mostly so = the future us have an easily searchable log. > Actually, now that I've run make, that's spotted some problems in some > checks. > > guix/lint.scm:198:17: warning: possibly unbound variable `texi->plain-tex= t' > guix/lint.scm:406:8: warning: possibly unbound variable `texi->plain-text' > guix/lint.scm:737:36: warning: possibly unbound variable `fill-paragraph' > guix/lint.scm:738:36: warning: possibly unbound variable `fill-paragraph' > guix/lint.scm:743:20: warning: possibly unbound variable `fill-paragraph' > > I don't think these are as easy to solve, as these functions come from > (guix ui). Ah yes, indeed.=20=20 In that case it=E2=80=99s OK because (guix ui) is used as part of the linte= r=E2=80=99s job. Perhaps for clarity we should write: #:use-module ((guix ui) #:select (texi->plain-text fill-paragraph)) Uses of the =E2=80=98warning=E2=80=99 procedure or similar UI functionality= should be left to (guix scripts lint), though. Thanks, Ludo=E2=80=99.