From: "Ludovic Courtès" <ludo@gnu.org>
To: Konrad Hinsen <konrad.hinsen@fastmail.net>
Cc: 37978@debbugs.gnu.org
Subject: [bug#37978] [PATCH 1/2] guix: new command "guix time-machine"
Date: Sun, 10 Nov 2019 13:00:33 +0100 [thread overview]
Message-ID: <87k1883pr2.fsf@gnu.org> (raw)
In-Reply-To: <m1mud65ucj.fsf@fastmail.net> (Konrad Hinsen's message of "Fri, 08 Nov 2019 15:13:48 +0100")
Hi Konrad,
Thanks for the updated patch!
Konrad Hinsen <konrad.hinsen@fastmail.net> skribis:
> * guix/scripts/time-machine.scm: New file.
> * Makefile.am: (MODULES): Add it.
> * guix/scripts/pull.scm: Export function channel-list.
> * guix/inferior.scm: New function cached-guix-filetree-for-channels.
> * doc/guix.texi: Document "guix time-machine"
[...]
> +(define* (cached-guix-filetree-for-channels channels
> + #:key
> + (cache-directory (%inferior-cache-directory))
> + (ttl (* 3600 24 30)))
> + "Return a directory containing a guix filetree defined by CHANNELS, a list of channels.
> +The directory is a subdirectory of CACHE-DIRECTORY, where entries can be reclaimed after TTL seconds.
> +This procedure opens a new connection to the build daemon."
> (with-store store
It’s the same as in v1, right?
How about (1) calling it ‘cached-channel-instance’ (or similar; as a
rule of thumb, I try to avoid “guix” in identifiers as well as
neologisms), and (2) not opening a connection to the daemon? :-)
As it stands, this procedure opens a connection unconditionally anyway,
so it’s fine IMO to just move that ‘with-store’ to time-machine.scm and
to ‘inferior-for-channels’.
I also think it would be preferable to make it a separate patch
(separate from the one that adds time-machine.scm), if it’s OK for you.
Thoughts?
Thank you!
Ludo’.
next prev parent reply other threads:[~2019-11-10 12:01 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-25 15:42 [bug#37978] [PATCH] guix: new command "guix time-machine" Konrad Hinsen
2019-10-25 15:42 ` [bug#37978] [PATCH 1/3] " Konrad Hinsen
2019-11-06 13:53 ` [bug#37978] [PATCH] " Ludovic Courtès
2019-11-06 14:27 ` Tobias Geerinckx-Rice via Guix-patches via
2019-11-07 13:11 ` Konrad Hinsen
2019-11-06 14:30 ` Ludovic Courtès
2019-11-07 19:40 ` Konrad Hinsen
2019-11-07 21:10 ` Ludovic Courtès
2019-11-08 7:14 ` Konrad Hinsen
2019-11-08 14:13 ` [bug#37978] [PATCH 1/2] " Konrad Hinsen
2019-11-10 12:00 ` Ludovic Courtès [this message]
2019-11-12 15:52 ` Konrad Hinsen
2019-11-08 14:15 ` [bug#37978] [PATCH 2/2] news: Add entry for " Konrad Hinsen
2019-11-08 20:43 ` pelzflorian (Florian Pelz)
2019-11-10 12:02 ` Ludovic Courtès
2019-11-08 14:16 ` [bug#37978] [PATCH] guix: new command " Konrad Hinsen
2019-11-15 22:35 ` bug#37978: " Ludovic Courtès
2019-11-16 9:06 ` [bug#37978] " Konrad Hinsen
2019-11-08 20:09 ` Ludovic Courtès
2019-11-08 10:16 ` [bug#37978] [PATCH 3/3] news: Add entry for " Konrad Hinsen
2019-11-08 14:15 ` [bug#37978] [PATCH 2/2] " Konrad Hinsen
2019-11-12 15:39 ` [bug#37978] [PATCH 2/3] guix: don't connect to daemon in cached-channel-instance Konrad Hinsen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k1883pr2.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=37978@debbugs.gnu.org \
--cc=konrad.hinsen@fastmail.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).