From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:38041) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iTvz5-0001Bg-Hm for guix-patches@gnu.org; Sun, 10 Nov 2019 17:47:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iTvz4-0006xI-JG for guix-patches@gnu.org; Sun, 10 Nov 2019 17:47:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:44018) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iTvz4-0006xE-Fv for guix-patches@gnu.org; Sun, 10 Nov 2019 17:47:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iTvz4-0008CM-47 for guix-patches@gnu.org; Sun, 10 Nov 2019 17:47:02 -0500 Subject: [bug#38115] [PATCH] gnu: Add dpf-plugins. Resent-Message-ID: From: Marius Bakke In-Reply-To: References: Date: Sun, 10 Nov 2019 23:45:54 +0100 Message-ID: <87k187jqot.fsf@devup.no> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Alexandros Theodotou , 38115@debbugs.gnu.org --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Alexandros Theodotou writes: > From aebc4cded75e51f6c453a52cae10c9224d9e7df9 Mon Sep 17 00:00:00 2001 > From: Alexandros Theodotou > Date: Fri, 8 Nov 2019 08:55:22 +0000 > Subject: [PATCH] gnu: Add dpf-plugins. > > * gnu/packages/music.scm: (dpf-plugins): New variable. [...] > + (arguments > + `(#:tests? #f ; no "check" target > + #:make-flags > + (list (string-append "PREFIX=3D" (assoc-ref %outputs "out"))) > + #:phases > + (modify-phases %standard-phases > + (add-after 'unpack 'skip-dssi-binaries > + (lambda _ > + (substitute* "Makefile" > + (("cp -r bin.*-dssi.*$") ":;\n")) > + #t)) Can you expand on this comment? What are these binaries, and why do we need to prevent them from being installed? > + (license `(license:isc license:gpl3 license:lgpl3 license:mit=20 > license:gpl2)))) Does this work? I would expect each of the license entries to have to be 'unquoted', i.e. `(,license:isc). Alternatively you can use (list ...) here. When a package has multiple licenses like here, please add a comment about it. Is there a "main" license, (roughly) which files are under what license? Apart from that LGTM. --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl3IkyIACgkQoqBt8qM6 VPr2ggf/eCZ2tAyyyKkDgKZKujtJ4NcsYSeJuoZ9cmjTBZw7rq6GGotC9xg/rNDU dNAkyF4DcNp0SCkLN10elaXgqWoZE+qSxNLkUoNmF6JP07rLUrILFrP0WZ5crWlf 1zWGXA9gG2ekF/KEJjA96uVy1BRWfYoPo0f50mo6zqieL/ZdDAanifFypTPAvBxB md8kFiF1cWLCzbyvtqvv4qJGAJnJPaLHiGEyJ8AQv4jRwDdR/phFatFL3rdhTfrQ WuuctU9Dr4hbnKw7iri3JbkK7ix609/us6b0YFC0tOwrCAAtehPPVEjEYxY5Jtya U+r/2RD72Rq1yYLxHFoojDMJQhxVJA== =olNE -----END PGP SIGNATURE----- --=-=-=--