From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:60242) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ieX64-0003Lf-BE for guix-patches@gnu.org; Mon, 09 Dec 2019 23:26:05 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ieX63-0003rB-1a for guix-patches@gnu.org; Mon, 09 Dec 2019 23:26:04 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:48705) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ieX62-0003r3-LP for guix-patches@gnu.org; Mon, 09 Dec 2019 23:26:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ieX62-0004As-HT for guix-patches@gnu.org; Mon, 09 Dec 2019 23:26:02 -0500 Subject: [bug#38554] [PATCH 0/5] Update python-hy to 0.17.0 Resent-Message-ID: From: Brett Gilio References: <660a10a1f02b4818a28dfea58b544956437d4b66.camel@gmail.com> Date: Mon, 09 Dec 2019 22:25:34 -0600 In-Reply-To: <660a10a1f02b4818a28dfea58b544956437d4b66.camel@gmail.com> (Jesse Gibbons's message of "Mon, 09 Dec 2019 19:29:58 -0700") Message-ID: <87k174n6wx.fsf@posteo.net> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Jesse Gibbons Cc: 38554@debbugs.gnu.org Jesse Gibbons writes: > The next five patches: > - add dependencies for python-hy 0.17.0 (patches 1,2) > - update python-hy from 0.13.0 to 0.17.0 (patch 3) > - add dependencies for python2-hy 0.17.0 (patches 4,5) > > > This will be the last version of python-hy to support python 2. If it is > better to drop python2-hy now, simply omit patches 4 and 5, and remove > python2-hy. Hy Jesse! (Haha.) Thank you for your patch series. I am sorry for the delay and the lack of communication regarding your bug report. I could imagine this is really frustrating. There are some corrections that I think need to be made before we go forward, and for the sake of education I would like to propose some revisions. Once we get these revisions, I think we will be golden for a push to master! So bare with me. First off, _USUALLY_ we have the package-for-python2 derivatives in the same commits as the package indicating the original. Thus, your python2-* patches (4 & 5) can be squashed into their originating commits (1 & 2) respectively. In patch 1: You indicate your copyright email as such: --8<---------------cut here---------------start------------->8--- ;;; Copyright =C2=A9 2019 Jesse Gibbons --8<---------------cut here---------------end--------------->8--- Is this correct? Just seems odd to me. Also in that patch you have too many white space return indications between= the preceeding package, and you have white space return at the EOF. This should= be reduced to one and none, respectively. Next, if you could run `guix lint` on this package. Your synopsis and description sections are identical and do not conform to our guidelines. I suspect this was just the default from running `guix import pypi`. If you need help with making synopsis and descriptions, here is the relevant documentation: https://guix.gnu.org/manual/en/html_node/Synopses-and-Descriptions.html In patch 2: There should be a white space return before the package in this case, but was likely cut off from the improper EOF return in patch 1. Otherwise, this package looks okay aside from the issue with the synopsis and description. Lastly, all of the commit messages need a period at the end. And the sub-header message for the patch which bumps Hy to 0.17 needs a period as well. You could also remove the redundant [inputs] section and simply make a comma-separated-list of new inputs. Also, if you could add something like, --8<---------------cut here---------------start------------->8--- Fixes: . --8<---------------cut here---------------end--------------->8--- to the patch that updates Hy, that way we can know where this patch series is predicated from. That would be superb! Once we get these easy changes done we will push! If you could send your revisions with something like: --8<---------------cut here---------------start------------->8--- [PATCH v2 x/3] --8<---------------cut here---------------end--------------->8--- Again, I apologize for the radio silence. --=20 Brett M. Gilio Homepage -- https://scm.pw/ GNU Guix -- https://guix.gnu.org/