From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:39574)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1igGqO-0003uq-LX
 for guix-patches@gnu.org; Sat, 14 Dec 2019 18:29:05 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1igGqM-0008HE-Hd
 for guix-patches@gnu.org; Sat, 14 Dec 2019 18:29:04 -0500
Received: from debbugs.gnu.org ([209.51.188.43]:58124)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1igGqM-0008Gs-E2
 for guix-patches@gnu.org; Sat, 14 Dec 2019 18:29:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1igGqM-0007JC-BH
 for guix-patches@gnu.org; Sat, 14 Dec 2019 18:29:02 -0500
Subject: [bug#38480] [PATCH] gnu: Add lolcat
Resent-Message-ID: <handler.38480.B38480.157636612728070@debbugs.gnu.org>
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
References: <20191204014644.1491-1-leo.prikler@student.tugraz.at>
 <877e3ciylo.fsf@posteo.net>
 <fa8f7a346d9f190892f49e1538ed909d184c1412.camel@student.tugraz.at>
Date: Sun, 15 Dec 2019 00:28:34 +0100
In-Reply-To: <fa8f7a346d9f190892f49e1538ed909d184c1412.camel@student.tugraz.at>
 (Leo Prikler's message of "Thu, 05 Dec 2019 18:41:40 +0100")
Message-ID: <87k16ywkpp.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Leo Prikler <leo.prikler@student.tugraz.at>
Cc: 38480@debbugs.gnu.org, Brett Gilio <brettg@posteo.net>

Hello!

Leo Prikler <leo.prikler@student.tugraz.at> skribis:

> From: Leo Prikler <leo.prikler@student.tugraz.at>
> Date: Wed,  4 Dec 2019 02:46:44 +0100
> Subject: [PATCH] gnu: Add lolcat
>
> * gnu/packages/games.scm (lolcat): New package.

[...]

> +           (replace 'install
> +             (lambda* (#:key outputs #:allow-other-keys)
> +               (let ((dest (map (lambda (path) (string-append path "/bin=
"))
> +                                (list (assoc-ref outputs "out")
> +                                      (assoc-ref outputs "censor")))))
> +                 (for-each mkdir-p dest)
> +                 (install-file "lolcat" (car dest))
> +                 (install-file "censor" (cadr dest))
> +                 #t))))))
> +      (outputs (list "out" "censor"))

Can=E2=80=99t we keep them both in the same output?  Separate outputs are
normally only used when it helps save space, but I don=E2=80=99t think that=
=E2=80=99s a
concern here.  :-)

> +      (home-page "https://github.com/jaseg/lolcat")
> +      (synopsis "Rainbow coloring effect for text console display")
> +      (description "Lolcat concatenates files and streams like regular c=
at,
                       ^                                                  ^
Maybe @command{cat} and @command{lolcat}.

Could you send an updated patch?

Thanks,
Ludo=E2=80=99.