From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:39819) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1ilhCF-0001UL-Nw for guix-patches@gnu.org; Sun, 29 Dec 2019 17:38:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1ilhCE-0003sT-RP for guix-patches@gnu.org; Sun, 29 Dec 2019 17:38:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:54350) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1ilhCE-0003sC-OC for guix-patches@gnu.org; Sun, 29 Dec 2019 17:38:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1ilhCE-0006He-Db for guix-patches@gnu.org; Sun, 29 Dec 2019 17:38:02 -0500 Subject: [bug#38612] Pass system and target arguments to gexp->file. Resent-Message-ID: From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <87a77ug6vv.fsf@gmail.com> <8736dl8wxq.fsf@gmail.com> <87d0cipt6z.fsf@gnu.org> <87r20t7r0j.fsf@gmail.com> <87imm468rr.fsf@gmail.com> <87d0cbhsk1.fsf@gnu.org> <87mubej4sq.fsf@gmail.com> <87a77dhce4.fsf@gnu.org> <878smvtr1b.fsf@gmail.com> Date: Sun, 29 Dec 2019 23:36:52 +0100 In-Reply-To: <878smvtr1b.fsf@gmail.com> (Mathieu Othacehe's message of "Sun, 29 Dec 2019 10:33:20 +0100") Message-ID: <87k16e92t7.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Mathieu Othacehe Cc: 38612@debbugs.gnu.org Hi! Mathieu Othacehe skribis: > Then, here's a patch that set the default target to 'current in > lower-object, gexp->file and gexp->script. Then, (current-target-system) > is used at bind time if target is 'current (same way as gexp->derivation > and lower-gexp). > > An additionnal patch is needed because lower-object is called without a > default target in lower-gexp, when lowering extensions. > > WDYT? > > Mathieu > > From f5d773dc0a627ba6059f1025189d33a9e0d083b5 Mon Sep 17 00:00:00 2001 > From: Mathieu Othacehe > Date: Sat, 28 Dec 2019 21:29:06 +0100 > Subject: [PATCH 1/2] gexp: Default to current target. > > * guix/gexp.scm (lower-object): Set target argument to 'current by defaul= t and > look for the current target system at bind time if needed, > (gexp->file): ditto, > (gexp->script): ditto. Uh, it=E2=80=99s =E2=80=9Cthe right thing=E2=80=9D but it=E2=80=99s getting= ugly. :-/ If we take a step back, what=E2=80=99s the minimal change that would solve = the problem you=E2=80=99re looking at? Apologies for the back-and-forth, it=E2=80=99s a tricky area! Thanks, Ludo=E2=80=99.