From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:48314) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1inb7X-0000dM-J1 for guix-patches@gnu.org; Fri, 03 Jan 2020 23:33:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1inb7W-0006Bh-8s for guix-patches@gnu.org; Fri, 03 Jan 2020 23:33:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:36369) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1inb7W-0006B6-4l for guix-patches@gnu.org; Fri, 03 Jan 2020 23:33:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1inb7W-00014r-2K for guix-patches@gnu.org; Fri, 03 Jan 2020 23:33:02 -0500 Subject: [bug#38877] [PATCH] gnu: Add xcur2png. Resent-Message-ID: From: Brett Gilio References: <20200102202336.20617-1-leo.prikler@student.tugraz.at> Date: Fri, 03 Jan 2020 22:32:31 -0600 In-Reply-To: <20200102202336.20617-1-leo.prikler@student.tugraz.at> (Leo Prikler's message of "Thu, 2 Jan 2020 21:23:36 +0100") Message-ID: <87k167zvs0.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Leo Prikler Cc: 38877@debbugs.gnu.org Leo Prikler writes: > * gnu/packages/xorg.scm (xcur2png): New variable. > --- > gnu/packages/xorg.scm | 26 ++++++++++++++++++++++++++ > 1 file changed, 26 insertions(+) > > diff --git a/gnu/packages/xorg.scm b/gnu/packages/xorg.scm > index fda61aff67..1c21a1cf86 100644 > --- a/gnu/packages/xorg.scm > +++ b/gnu/packages/xorg.scm > @@ -6425,3 +6425,29 @@ Thai).") > ;; by simple permissive licenses. See the 'COPYRIGHT' file. > (license (list license:gpl2+ > license:expat)))) > + > +(define-public xcur2png > + (package > + (name "xcur2png") > + (version "0.7.1") > + (source (origin > + (method git-fetch) > + (uri (git-reference > + (url "https://github.com/eworm-de/xcur2png.git") > + (commit version))) > + (file-name (git-file-name name version)) > + (sha256 > + (base32 > + "0858wn2p14bxpv9lvaz2bz1rk6zk0g8zgxf8iy595m8fqv4q2fya")))) > + (build-system gnu-build-system) > + (synopsis "Decode X cursors") > + (description > + "xcur2png is a program decomposes an X cursor into a set of PNG images and > +a configuration file reusable by xcursorgen.") > + (native-inputs > + `(("pkg-config" ,pkg-config))) > + (inputs > + `(("libpng" ,libpng) > + ("libxcursor" ,libxcursor))) > + (home-page "https://github.com/eworm-de/xcur2png") > + (license license:gpl3+))) Hey Leo! It doesn't really matter all that much, but I am curious about the ordering of the package declaration. Why did you put the inputs /after/ the synopsis and description? It's a fine looking package otherwise! -- Brett M. Gilio GNU Guix, Contributor | GNU Project, Webmaster [DFC0 C7F7 9EE6 0CA7 AE55 5E19 6722 43C4 A03F 0EEE]