From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:56056) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1iqWyi-0005I5-1w for guix-patches@gnu.org; Sun, 12 Jan 2020 01:44:04 -0500 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1iqWyg-00021n-Ll for guix-patches@gnu.org; Sun, 12 Jan 2020 01:44:03 -0500 Received: from debbugs.gnu.org ([209.51.188.43]:51007) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1iqWyg-00020x-Cb for guix-patches@gnu.org; Sun, 12 Jan 2020 01:44:02 -0500 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1iqWyg-00020x-AZ for guix-patches@gnu.org; Sun, 12 Jan 2020 01:44:02 -0500 Subject: [bug#38679] [PATCH] gnu: add geary. Resent-Message-ID: References: <87d0ciqnxw.fsf@gnu.org> In-reply-to: <87d0ciqnxw.fsf@gnu.org> Date: Sun, 12 Jan 2020 07:43:16 +0100 Message-ID: <87k15xqinv.fsf@nckx> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" Reply-to: Tobias Geerinckx-Rice , Tobias Geerinckx-Rice via Guix-patches From: Tobias Geerinckx-Rice via Guix-patches via To: Kasperi =?UTF-8?Q?Ker=C3=A4nen?= , 38679@debbugs.gnu.org --=-=-= Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: quoted-printable Kasperi, Thank you for packaging Geary! Unfortunately I can't test it=20 right now, but here are two general points to help you apply=20 Brett's suggestions. Brett Gilio =E5=86=99=E9=81=93=EF=BC=9A >> + (arguments `(#:tests? #f ;; Client tests require a=20 >> wayland/X11 >> display. > > A single ; comment will suffice here since it exists on the same=20 > line. I > also wonder if it is possible to spoof that display variable in=20 > the > tests or just remove that singular test? I might look into this=20 > if I > have some time. Maybe mark this as a TODO:? You can start a =E2=80=98virtual frame buffer=E2=80=99 (Xvfb) X server in t= he=20 build environment: (add-before 'check 'start-xserver (lambda* (#:key inputs #:allow-other-keys) (let ((xorg-server (assoc-ref inputs "xorg-server")) (display ":1")) (setenv "DISPLAY" display) (system (format #f "~a/bin/Xvfb ~a &" xorg-server=20 display)) #t))) You'll find many other examples with =E2=80=98grep Xvfb=20 gnu/packages/*scm=E2=80=99. > In the mean time, I would also look over some of the inputs some > more, because I wonder if things like "vala" should be=20 > native-inputs > instead? Just a thought, I could be wrong. A rule of thumb is that inputs missing from $ guix gc --references $(guix build geary) should probably be native. It's likely that vala will be so=20 missing. Kind regards, T G-R --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQIzBAEBCgAdFiEEfo+u0AlEeO9y5k0W2Imw8BjFSTwFAl4awAQACgkQ2Imw8BjF STzYXg/+IasYFy3z8i2uZBl28FP4+4DMJipwMFGZJW/UoWUOO7/8vPoRckH9rWVl YITlbEuJ5nG5LefMnJe4K3KXxtCEGV4TLNtHxKnmWpzV8REUbPW5B0VJbOunvs3V SkBT48UaT9E43EERBAQXRECbLe9G4zDX1+CrB9EF1hG/8hBSBhQ3RdnCqjDNdDYY X/CjsZq68d5blfsiOq9DTVDJii35wziKXu47YyPFPSCDh4hoNcbY8/uZM9FVyybr rqE1vTyoTV8pJi8DWg35o98Ddsv3lbEmQA25AzNhjBFS1Dpbq1WMqOpHzEZzEOYG 62stTPv87jXL9nnMwRTb0n6ic/ZQ2sEE5ewBrElfqJM3XDs5+BB8Ip/VHlty+gS1 RkQ+OAWeq6YOrAIVOIFT+s5UI/FBsXoggtgxMIt6EN+svasBACjmIX19wi1Qinwf qCt+iaCApACLO5fvrdqCwel7tsbegiIK/Trmo4krx+N+GUADd6y3PrMnnx8Y14AB Ub22YdbsT/VSCn2fY2YCmXwSEgJLlyuqHBWsnfb0CSM+G4hpxFz0Ee5SN+YDMbon brWbEHaTU08f7XeGdMwFCeOJTEt7SDc6PoRSK501knmKVtUpw0mImqZJ7RT3nr1L ZeWn/0YCFnEd11qBzPgoJlPZs8YQLHpzVwFaIVuwz6EEC2fSp/c= =8r1O -----END PGP SIGNATURE----- --=-=-=--