From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:41796)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jAAtf-0006Yt-Q0
 for guix-patches@gnu.org; Fri, 06 Mar 2020 06:12:04 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jAAte-0000qx-Qi
 for guix-patches@gnu.org; Fri, 06 Mar 2020 06:12:03 -0500
Received: from debbugs.gnu.org ([209.51.188.43]:38203)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1jAAte-0000q5-N3
 for guix-patches@gnu.org; Fri, 06 Mar 2020 06:12:02 -0500
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jAAte-0008BV-Gt
 for guix-patches@gnu.org; Fri, 06 Mar 2020 06:12:02 -0500
Subject: bug#39694: [SHEPHERD] [PATCH] build: Adjust clean targets.
Resent-To: guix-patches@gnu.org
Resent-Message-ID: <handler.39694.D39694.158349306731388.done@debbugs.gnu.org>
From: Ludovic =?UTF-8?Q?Court=C3=A8s?= <ludo@gnu.org>
References: <20200220154221.22104-1-efraim@flashner.co.il>
Date: Fri, 06 Mar 2020 12:10:52 +0100
In-Reply-To: <20200220154221.22104-1-efraim@flashner.co.il> (Efraim Flashner's
 message of "Thu, 20 Feb 2020 17:42:21 +0200")
Message-ID: <87k13xoi0z.fsf@gnu.org>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: Efraim Flashner <efraim@flashner.co.il>
Cc: 39694-done@debbugs.gnu.org

Hi Efraim,

Efraim Flashner <efraim@flashner.co.il> skribis:

> Makefile.am: Add man pages to the 'make clean' target.
> ---
> Currently 'man shepherd' shows version 0.6.1, 'man herd' 0.6.0, 'man
> halt' and 'man reboot' 0.3.2. With this patch these 4 manpages are added
> to the 'make clean' list and are deleted. The manpage creation works as
> expected.

[...]

> +CLEANFILES +=3D $(dist_man1_MANS) $(dist_man8_MANS)

This would remove man pages upon =E2=80=9Cmake clean=E2=80=9D, whereas they=
 should only
be removed upon =E2=80=9Cmake distclean=E2=80=9D, per GNU conventions.

I went with a different fix in Shepherd commit
f32a2ff8ad329f224b2f693ad7e9fefac142a459.

Thank you!

Ludo=E2=80=99.