From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:470:142:3::10]:48737)
 by lists.gnu.org with esmtp (Exim 4.90_1)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jKDlP-0005d5-Sn
 for guix-patches@gnu.org; Fri, 03 Apr 2020 00:17:05 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jKDlO-0005Mt-O7
 for guix-patches@gnu.org; Fri, 03 Apr 2020 00:17:03 -0400
Received: from debbugs.gnu.org ([209.51.188.43]:57736)
 by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16)
 (Exim 4.71) (envelope-from <Debian-debbugs@debbugs.gnu.org>)
 id 1jKDlO-0005MM-CX
 for guix-patches@gnu.org; Fri, 03 Apr 2020 00:17:02 -0400
Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2)
 (envelope-from <Debian-debbugs@debbugs.gnu.org>) id 1jKDlO-0005dF-7W
 for guix-patches@gnu.org; Fri, 03 Apr 2020 00:17:02 -0400
Subject: [bug#40281] [PATCH v2] gnu: Add mtpaint.
Resent-Message-ID: <handler.40281.B40281.158588739021526@debbugs.gnu.org>
References: <20200329172136.GA23111@tulip> <20200331093956.GA8435@tulip>
From: Ricardo Wurmus <rekado@elephly.net>
In-reply-to: <20200331093956.GA8435@tulip>
Date: Fri, 03 Apr 2020 06:15:57 +0200
Message-ID: <87k12xw6f6.fsf@elephly.net>
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: quoted-printable
List-Id: <guix-patches.gnu.org>
List-Unsubscribe: <https://lists.gnu.org/mailman/options/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=unsubscribe>
List-Archive: <https://lists.gnu.org/archive/html/guix-patches>
List-Post: <mailto:guix-patches@gnu.org>
List-Help: <mailto:guix-patches-request@gnu.org?subject=help>
List-Subscribe: <https://lists.gnu.org/mailman/listinfo/guix-patches>,
 <mailto:guix-patches-request@gnu.org?subject=subscribe>
Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org
Sender: "Guix-patches" <guix-patches-bounces+kyle=kyleam.com@gnu.org>
To: R Veera Kumar <vkor@vkten.in>
Cc: 40281@debbugs.gnu.org


R Veera Kumar <vkor@vkten.in> writes:

> * gnu/packages/image.scm (mtpaint): New variable.

Thank you for the patch!

> +
> +(define-public mtpaint
> +  (let ((commit "03b1b0938067b88d86d9f1b1088730f1934d411e")
> +        (revision "1"))

Why is this particular commit needed?  Can=E2=80=99t we use the latest rele=
ase?

> +    (package
> +      (name "mtpaint")
> +      (version (git-version "3.49.25" revision commit))
> +      (source
> +       (origin
> +         (method git-fetch)
> +         (uri (git-reference
> +               (url "https://github.com/wjaguar/mtPaint/")
> +               (commit commit)))
> +         (file-name (git-file-name name version))
> +         (sha256
> +          (base32 "0izm2wvj26566fd8mqvypr7bmv7jnq8qhp4760m7z2wrc4y8pjn1"=
))))
> +      (build-system gnu-build-system)
> +      (native-inputs
> +       `(("gettext" ,gettext-minimal)
> +         ("pkg-config" ,pkg-config)
> +         ("pkg-config" ,pkg-config)

You have this line twice.

> +         ("which" ,which)))
> +      (inputs
> +       `(("imlib2" ,imlib2)
> +         ("libtiff" ,libtiff)
> +         ("libpng" ,libpng)
> +         ("libungif", libungif)
> +         ("libjpeg", libjpeg)
> +         ("libwebp" ,libwebp)
> +         ("openjpeg" ,openjpeg)
> +         ("lcms" ,lcms)
> +         ("zlib", zlib)
> +         ("glib" ,glib)
> +         ("gtk+" ,gtk+-2)))

Could you please build with gtk+ (i.e. version 3).  You probably need to
add =E2=80=9Cgtk3=E2=80=9D to the configure flags.

> +      (arguments
> +       `(#:configure-flags
> +         (list
> +          "intl") ;; internationalized support

Please remove the line break.
For margin comments (at the end of a line) use just one semicolon please.

> +         ;; no check target
> +         #:tests? #f))
> +      (home-page "http://mtpaint.sourceforge.net/")
> +      (synopsis "Create pixel art and manipulate digital images")
> +      (description
> +       "Mtpaint is a graphic editing program which uses the GTK+ toolkit.
> +It can create and edit indexed pallete or 24bit RGB images, offers
> basic

=E2=80=9Cpallete=E2=80=9D =E2=80=93> =E2=80=9Cpalette=E2=80=9D

> +painting and palette manipulation tools.

Same here.

--
Ricardo