From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:470:142:3::10]:44142) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jRJfJ-0001yr-Ew for guix-patches@gnu.org; Wed, 22 Apr 2020 14:00:05 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.90_1) (envelope-from ) id 1jRJfI-0006MQ-Ud for guix-patches@gnu.org; Wed, 22 Apr 2020 14:00:05 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:41629) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jRJfI-0006KX-GR for guix-patches@gnu.org; Wed, 22 Apr 2020 14:00:04 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jRJfH-0001Y0-FJ for guix-patches@gnu.org; Wed, 22 Apr 2020 14:00:03 -0400 Subject: [bug#40753] gnu: spacefm: Add missing dependencies. Resent-Message-ID: From: Jan Nieuwenhuizen References: <20200421172812.6227b2eb.raghavgururajan@disroot.org> <87ftcw81bl.fsf@gnu.org> <20200422122833.076c8a60.raghavgururajan@disroot.org> Date: Wed, 22 Apr 2020 19:59:41 +0200 In-Reply-To: <20200422122833.076c8a60.raghavgururajan@disroot.org> (Raghav Gururajan's message of "Wed, 22 Apr 2020 12:28:33 -0400") Message-ID: <87k127o0z6.fsf@gnu.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+kyle=kyleam.com@gnu.org Sender: "Guix-patches" To: Raghav Gururajan Cc: 40753@debbugs.gnu.org Raghav Gururajan writes: Hello Raghav, >> > BLOCKERS: #40630 and #40752.=20=20 >>=20 >> ...what does this mean? > > They are dependencies of this patch, that needs to be pushed before > this patch. Right. So we'll have to wait for those then, right? >> It builds OK without this patch; it does not seem that any dependencies >> are missing. Could it be that these dependencies change or amend its >> behaviour? > > It is to change and amend the behaviour. It adds missing features and fix= es > icons+privilege-management+disk-management. Okay, it would be nice to say something about that in the commit message. What about gnu: spacefm: Add dependencies for extra functionality. Adding these inputs provides adds icons, privilege-management and disk-management. Other than that, LGTM (assuming that it builds). I'm not really able to test it, I assume it works for you as you expected? >> I am feeling a bit uncomfortable about the fact that you pinged me to >> "push" this patch, it seems it needs a bit more attention than that. > > I apologize. I spent whole day to create these patches and throughly test= ing > them. If I missed anything, please understand it would not have been > intentional. Also, there is a v2 patch in #40753 thread that has 3 blocke= rs. > > Thank you for considering my request. No worries! I did not have much time this morning and from your ping assumed a trivial task. Teaches me not to assume things. I would suggest that when you get an OK on the last dependency for this one, you mention this patch again. Please consider sending patches that depend on eachother in one bug report if that makes sense. Greetings, janneke --=20 Jan Nieuwenhuizen | GNU LilyPond http://lilypond.org Freelance IT http://JoyofSource.com | Avatar=C2=AE http://AvatarAcademy.com