From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp0 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id qNoRIHtNwl4nOQAA0tVLHw (envelope-from ) for ; Mon, 18 May 2020 08:55:23 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp0 with LMTPS id gCoCHHtNwl5vaAAA1q6Kng (envelope-from ) for ; Mon, 18 May 2020 08:55:23 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 029E294042B for ; Mon, 18 May 2020 08:55:22 +0000 (UTC) Received: from localhost ([::1]:52272 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jabYO-00069y-CW for larch@yhetil.org; Mon, 18 May 2020 04:55:20 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:48386) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jabY6-00061C-Ie for guix-patches@gnu.org; Mon, 18 May 2020 04:55:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:34269) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jabY6-0002zP-9N for guix-patches@gnu.org; Mon, 18 May 2020 04:55:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jabY6-0001Qw-6N for guix-patches@gnu.org; Mon, 18 May 2020 04:55:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#37305] [PATCH v3] Allow booting from a Btrfs subvolume Resent-From: Pierre Neidhardt Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Mon, 18 May 2020 08:55:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 37305 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Maxim Cournoyer Cc: Ludovic =?UTF-8?Q?Court=C3=A8s?= , 37305@debbugs.gnu.org Received: via spool by 37305-submit@debbugs.gnu.org id=B37305.15897920975497 (code B ref 37305); Mon, 18 May 2020 08:55:02 +0000 Received: (at 37305) by debbugs.gnu.org; 18 May 2020 08:54:57 +0000 Received: from localhost ([127.0.0.1]:45815 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jabY1-0001Qa-0G for submit@debbugs.gnu.org; Mon, 18 May 2020 04:54:57 -0400 Received: from relay3-d.mail.gandi.net ([217.70.183.195]:33889) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jabXy-0001QO-OC for 37305@debbugs.gnu.org; Mon, 18 May 2020 04:54:55 -0400 X-Originating-IP: 78.199.129.170 Received: from mimimi (moi44-1-78-199-129-170.fbx.proxad.net [78.199.129.170]) (Authenticated sender: mail@ambrevar.xyz) by relay3-d.mail.gandi.net (Postfix) with ESMTPSA id 9CC8460015; Mon, 18 May 2020 08:54:47 +0000 (UTC) From: Pierre Neidhardt In-Reply-To: <87r1vi9h5q.fsf@gmail.com> References: <875zg2xtsb.fsf@gmail.com> <87lfoxbn2e.fsf@gnu.org> <87v9n1pts1.fsf@raisin.i-did-not-set--mail-host-address--so-tickle-me> <87o8qmheqm.fsf@ambrevar.xyz> <874ksebkup.fsf_-_@gmail.com> <878shqh61b.fsf@ambrevar.xyz> <87367ygz5c.fsf@ambrevar.xyz> <87y2pqfkfa.fsf@ambrevar.xyz> <87v9kufim7.fsf@ambrevar.xyz> <87r1vi9h5q.fsf@gmail.com> Date: Mon, 18 May 2020 10:54:46 +0200 Message-ID: <87k119fwrt.fsf@ambrevar.xyz> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha256; protocol="application/pgp-signature" X-Spam-Score: -0.2 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -0.2 (/) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -0.61 X-TUID: IFkfzjn1ZB+F --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Hi Maxim! >> I won't have access to this computer in 24 hours. Let me know if there >> is anything else you'd like me to test before then! :) > > Any comments above the implementation (code) or documentation? Was > something unclear/missing? I had a cursory look. The code looks good to me as far as I can tell (which is little, considering my limited knowledge of the file system code). The documentation examples are good. The paragraphs are a little bit harder to grasp for me, but I am not sure how to make it clearer; besides, the examples really help clarifying everything, so it's good enoug= h. Thanks! =2D-=20 Pierre Neidhardt https://ambrevar.xyz/ --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCAAdFiEEUPM+LlsMPZAEJKvom9z0l6S7zH8FAl7CTVYACgkQm9z0l6S7 zH+Idgf/b+HzE7WWaqkP+4D/vrYUNw4KGCA1VieeHSZDyR3pu6FHgUTufalVhE5s YWw6v/TDtVfY/T2/TIVqUmzbTsA81HUkV22PmF3+tN1eV4hBq957wyU7UFmOOLtg uur7jB1VmnmR3vdZwHD2s6ExIYortwRKvPB/HYnZylbXVYP2zIlox8iiczA57b7v y+yb1V9MVzJphiHij2L6sgTsRLzPPPM2kwYFYkyBz85KblRSS+nVIteMPAV3P407 UBbeq1HZLAR5aYgJrA0BpPbaUKUkTYP5xV3ap5WL0EjVlYDJAy3pciUxp4zBPU6E Ja0lJeZ+jVGzW/POoopVqLkRpSooIw== =fpn2 -----END PGP SIGNATURE----- --=-=-=--