From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id UBkJH2IsyV7yAgAA0tVLHw (envelope-from ) for ; Sat, 23 May 2020 14:00:02 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id iJXvGmIsyV7RMAAAB5/wlQ (envelope-from ) for ; Sat, 23 May 2020 14:00:02 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 03964940276 for ; Sat, 23 May 2020 14:00:02 +0000 (UTC) Received: from localhost ([::1]:56486 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jcUgz-0007lL-0T for larch@yhetil.org; Sat, 23 May 2020 10:00:01 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:59102) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jcUg2-0006w3-NU for guix-patches@gnu.org; Sat, 23 May 2020 09:59:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:51903) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jcUg2-0002s6-EI for guix-patches@gnu.org; Sat, 23 May 2020 09:59:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jcUg2-0007XF-EP for guix-patches@gnu.org; Sat, 23 May 2020 09:59:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#41360] [PATCH 01/12] gnu: java-openjfx-build: Add helpful patch. Resent-From: Ludovic =?UTF-8?Q?Court=C3=A8s?= Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sat, 23 May 2020 13:59:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41360 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Alexey Abramov Cc: 41360@debbugs.gnu.org Received: via spool by 41360-submit@debbugs.gnu.org id=B41360.159024232528941 (code B ref 41360); Sat, 23 May 2020 13:59:02 +0000 Received: (at 41360) by debbugs.gnu.org; 23 May 2020 13:58:45 +0000 Received: from localhost ([127.0.0.1]:35216 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jcUff-0007Wd-GO for submit@debbugs.gnu.org; Sat, 23 May 2020 09:58:45 -0400 Received: from eggs.gnu.org ([209.51.188.92]:51602) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jcUfa-0007WM-7y for 41360@debbugs.gnu.org; Sat, 23 May 2020 09:58:38 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:43363) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jcUfU-0002oE-QP; Sat, 23 May 2020 09:58:28 -0400 Received: from [2a01:e0a:1d:7270:af76:b9b:ca24:c465] (port=52234 helo=ribbon) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jcUfS-0000Xi-56; Sat, 23 May 2020 09:58:27 -0400 From: Ludovic =?UTF-8?Q?Court=C3=A8s?= References: <20200517132829.1553311-1-levenson@mmer.org> <20200517135138.1651512-1-levenson@mmer.org> Date: Sat, 23 May 2020 15:58:24 +0200 In-Reply-To: <20200517135138.1651512-1-levenson@mmer.org> (Alexey Abramov's message of "Sun, 17 May 2020 15:51:30 +0200") Message-ID: <87k1127ny7.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -1.01 X-TUID: W3irYxS5sxIc Hi Alexey, Thanks for the patch series! Alexey Abramov skribis: > * gnu/packages/java.scm (java-openjfx-build)[source]: Use it. > * gnu/packages/patches/java-openjfx-build-get_guix_jdk_version.patch: New= file. > * gnu/local.mk (dist_patch_DATA): Add it. [...] > +++ b/gnu/packages/patches/java-openjfx-build-get_guix_jdk_version.patch > @@ -0,0 +1,37 @@ Could you shorten this file name a bit? (=E2=80=98guix lint=E2=80=99 proba= bly complains.) > +From d156313340d3edcd78751ea8ed5e66c7668275c3 Mon Sep 17 00:00:00 2001 > +From: Alexey Abramov > +Date: Sun, 8 Mar 2020 20:07:22 +0100 > +Subject: [PATCH] openjfx: Determine the version of Java in JDK_HOME In general I think you can omit the first three lines and just keep the subject. > +Icedtea contains guix in its version, so build.gradle failes to run. Ope= njfx > +packaging is not trivial, so you will probably need to try build it with > +gradlew. Otherwise LGTM.