From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id aJzpKlov715SVwAA0tVLHw (envelope-from ) for ; Sun, 21 Jun 2020 09:58:50 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id EtGxJlov714OAgAAB5/wlQ (envelope-from ) for ; Sun, 21 Jun 2020 09:58:50 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 4BC98940655 for ; Sun, 21 Jun 2020 09:58:50 +0000 (UTC) Received: from localhost ([::1]:40226 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jmwkT-0000sG-9t for larch@yhetil.org; Sun, 21 Jun 2020 05:58:49 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:52392) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jmwji-0008Gy-0E for guix-patches@gnu.org; Sun, 21 Jun 2020 05:58:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:47713) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jmwjh-00052L-NS for guix-patches@gnu.org; Sun, 21 Jun 2020 05:58:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jmwjh-0002XS-L9 for guix-patches@gnu.org; Sun, 21 Jun 2020 05:58:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#41873] [PATCH] gnu: Add ebusd. Resent-From: Mathieu Othacehe Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Sun, 21 Jun 2020 09:58:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 41873 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Danny Milosavljevic Cc: 41873@debbugs.gnu.org Received: via spool by 41873-submit@debbugs.gnu.org id=B41873.15927334439710 (code B ref 41873); Sun, 21 Jun 2020 09:58:01 +0000 Received: (at 41873) by debbugs.gnu.org; 21 Jun 2020 09:57:23 +0000 Received: from localhost ([127.0.0.1]:59259 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jmwj4-0002WY-RJ for submit@debbugs.gnu.org; Sun, 21 Jun 2020 05:57:23 -0400 Received: from eggs.gnu.org ([209.51.188.92]:37884) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jmwj2-0002WK-TW for 41873@debbugs.gnu.org; Sun, 21 Jun 2020 05:57:21 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:51609) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jmwix-0004xA-JW; Sun, 21 Jun 2020 05:57:15 -0400 Received: from [2a01:e0a:fa:a50:34a1:eac3:9800:4a6e] (port=53336 helo=meru) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jmwiv-0002mI-Fa; Sun, 21 Jun 2020 05:57:13 -0400 From: Mathieu Othacehe References: <20200615154243.22617-1-dannym@scratchpost.org> Date: Sun, 21 Jun 2020 11:57:11 +0200 In-Reply-To: <20200615154243.22617-1-dannym@scratchpost.org> (Danny Milosavljevic's message of "Mon, 15 Jun 2020 17:42:43 +0200") Message-ID: <87k1004u88.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/26.3 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -1.01 X-TUID: +0zyns49EDJs Hey Danny, > + (uri (git-reference > + (url "https://github.com/john30/ebusd.git") > + (commit (string-append "v" version)))) Indentation is off here and a bit below. > + (copy-recursively (string-append (assoc-ref inputs "config") > + "/ebusd-2.1.x") Maybe you could use the "latest" file here? > + (synopsis "Daemon for communicating with eBUS devices") > + (description "This package provides @command{ebusd}, a daemon for > +handling communication with eBUS devices connected to a 2-wire bus system > +(\"energy bus\" used by numerous heating systems).") I think you can turn this into a full sentence. Otherwise, it look fine. Thanks, Mathieu