From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id CIfnGi5gHF9yHAAA0tVLHw (envelope-from ) for ; Sat, 25 Jul 2020 16:39:10 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id iD7XFi5gHF8BIwAAB5/wlQ (envelope-from ) for ; Sat, 25 Jul 2020 16:39:10 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 9EA3C94050A for ; Sat, 25 Jul 2020 16:39:09 +0000 (UTC) Received: from localhost ([::1]:52404 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jzNCV-0007CX-5U for larch@yhetil.org; Sat, 25 Jul 2020 12:39:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34994) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1jzNCQ-0007Ai-Hn for guix-patches@gnu.org; Sat, 25 Jul 2020 12:39:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:39446) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1jzNCQ-0007Sr-9B for guix-patches@gnu.org; Sat, 25 Jul 2020 12:39:02 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1jzNCQ-0005a9-7t for guix-patches@gnu.org; Sat, 25 Jul 2020 12:39:02 -0400 Subject: bug#42082: [PATCH v2 6/6] gnu: Add python-pre-commit. Resent-From: Marius Bakke Original-Sender: "Debbugs-submit" Resent-To: guix-patches@gnu.org Resent-Date: Sat, 25 Jul 2020 16:39:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: cc-closed 42082 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Vinicius Monego , 42082-done@debbugs.gnu.org Cc: Vinicius Monego Mail-Followup-To: 42082@debbugs.gnu.org, marius@gnu.org, monego@posteo.net Received: via spool by 42082-done@debbugs.gnu.org id=D42082.159569513621439 (code D ref 42082); Sat, 25 Jul 2020 16:39:02 +0000 Received: (at 42082-done) by debbugs.gnu.org; 25 Jul 2020 16:38:56 +0000 Received: from localhost ([127.0.0.1]:50991 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jzNCJ-0005Zj-TA for submit@debbugs.gnu.org; Sat, 25 Jul 2020 12:38:56 -0400 Received: from eggs.gnu.org ([209.51.188.92]:41494) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1jzNCH-0005ZS-Ih for 42082-done@debbugs.gnu.org; Sat, 25 Jul 2020 12:38:54 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:46843) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1jzNCC-0007S9-AB; Sat, 25 Jul 2020 12:38:48 -0400 Received: from 84-52-226.102.3p.ntebredband.no ([84.52.226.102]:44250 helo=localhost) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1jzNCB-0008Ue-T4; Sat, 25 Jul 2020 12:38:48 -0400 From: Marius Bakke In-Reply-To: <20200724120144.500-6-monego@posteo.net> References: <20200627154645.64264-1-monego@posteo.net> <20200724120144.500-1-monego@posteo.net> <20200724120144.500-6-monego@posteo.net> Date: Sat, 25 Jul 2020 18:38:31 +0200 Message-ID: <87k0yrsg6w.fsf@gnu.org> MIME-Version: 1.0 Content-Type: multipart/signed; boundary="=-=-="; micalg=pgp-sha512; protocol="application/pgp-signature" X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -0.61 X-TUID: r33jNdWCa9Fn --=-=-= Content-Type: text/plain Content-Transfer-Encoding: quoted-printable Vinicius Monego writes: > * gnu/packages/version-control.scm (pre-commit): New variable. > --- > Enable tests. Update to 2.6.0. > > Language tests require interpreters/compilers and build systems as inputs > and downloading packages online (e.g. 'go get'), hence disabled. Makes sense. [...] =20=20 > + (replace 'check > + (lambda* (#:key inputs outputs #:allow-other-keys) > + (add-installed-pythonpath inputs outputs) > + (invoke "pytest" "tests" "-k" > + (string-append > + ;; Disable conda tests. > + "not test_conda_hook" > + " and not test_conda_with_additional_dependencies_= hook" > + " and not test_local_conda_additional_dependencies" > + ;; Disable cpan tests. > + " and not test_local_perl_additional_dependencies" > + " and not test_perl_hook" > + ;; Disable Ruby tests. > + " and not test_additional_ruby_dependencies_instal= led" > + " and not test_install_rbenv" > + " and not test_install_rbenv_with_version" > + " and not test_run_a_ruby_hook" > + " and not test_run_ruby_hook_with_disable_shared_g= ems" > + " and not test_run_versioned_ruby_hook" > + ;; Disable Cargo tests > + " and not test_additional_rust_cli_dependencies_in= stalled" > + " and not test_additional_rust_lib_dependencies_in= stalled" > + " and not test_local_rust_additional_dependencies" > + " and not test_rust_hook" > + ;; Disable python2 test. > + " and not test_switch_language_versions_doesnt_clo= bber" > + ;; These tests try to open a network socket. > + " and not test_additional_golang_dependencies_inst= alled" > + " and not test_additional_node_dependencies_instal= led" > + " and not test_golang_hook" > + " and not test_golang_hook_still_works_when_gobin_= is_set" > + " and not test_local_golang_additional_dependencie= s" > + " and not test_main" > + " and not test_node_hook_with_npm_userconfig_set" > + " and not test_run_a_node_hook" > + " and not test_run_versioned_node_hook" > + ;; Tests failing with a permission error. > + ;; They try to write to the filesystem. > + " and not test_autoupdate_hook_disappearing_repo" > + " and not test_hook_disppearing_repo_raises" > + " and not test_img_conflict" > + " and not test_img_something_unstaged" > + " and not test_installed_from_venv" > + " and not test_too_new_version" > + " and not test_try_repo_uncommitted_changes" > + " and not test_versions_ok" > + ;; This test tries to activate a virtualenv > + " and not test_healthy_venv_creator" > + ;; Fatal error: Not a Git repository. > + " and not test_all_cmds" > + " and not test_try_repo" > + ;; No module named 'pip._internal.cli.main' > + " and not test_additional_dependencies_roll_forwar= d" > + ; Assertion errors > + " and not test_install_existing_hooks_no_overwrite" > + " and not test_uninstall_restores_legacy_hooks")))) Wooooow, nice work! I've applied this and the other patches in the series. Thanks again! :-) --=-=-= Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- iQEzBAEBCgAdFiEEu7At3yzq9qgNHeZDoqBt8qM6VPoFAl8cYAcACgkQoqBt8qM6 VPrhmQf+KJ9paOV61b8HSU0SunOfxgsNj6nfdhBXWpeRoYeCVrudiPsuM73CCwOr 7pVoWVO7W6lruaaFB6PIem92dbvGjbJOi1jO52wUSwtMNoG7DUo0DSiEtapBfZoM NICk3w9gTXNN7cRX4k5cZCEN6Ozyj56sixeLrQWfaHn919g5LZkf+e1ZSS6Uf5w5 7cnwWWm5i1d4fkglqtzyAEvDAk5DnAvYQeTmiT9ebUWbrxrGZmVtoe9Wqbywjt8b Kr9ZOlqpFXepEdc3dQVgwmDje5iLqQNdz/hEa5SOijdaLhFM96fryX3SPTa4Fx9N Rwbv16y9pbSq9LMNWzqmZ2d9Od3l7Q== =kQsq -----END PGP SIGNATURE----- --=-=-=--