From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp1 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id GDfhBjziUV8XXwAA0tVLHw (envelope-from ) for ; Fri, 04 Sep 2020 06:44:12 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp1 with LMTPS id CO3pAjziUV/CJgAAbx9fmQ (envelope-from ) for ; Fri, 04 Sep 2020 06:44:12 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 4437A940415 for ; Fri, 4 Sep 2020 06:44:11 +0000 (UTC) Received: from localhost ([::1]:57022 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kE5SB-0006oX-Ex for larch@yhetil.org; Fri, 04 Sep 2020 02:44:07 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:55858) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kE5S7-0006oL-TU for guix-patches@gnu.org; Fri, 04 Sep 2020 02:44:03 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:53773) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kE5S6-0000KR-CP for guix-patches@gnu.org; Fri, 04 Sep 2020 02:44:03 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kE5S6-00056h-89 for guix-patches@gnu.org; Fri, 04 Sep 2020 02:44:02 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#43183] [PATCH] gnu: Add loko-scheme. Resent-From: Mathieu Othacehe Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Fri, 04 Sep 2020 06:44:02 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43183 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: patch To: Martin Becze Cc: 43183@debbugs.gnu.org Received: via spool by 43183-submit@debbugs.gnu.org id=B43183.159920182919602 (code B ref 43183); Fri, 04 Sep 2020 06:44:02 +0000 Received: (at 43183) by debbugs.gnu.org; 4 Sep 2020 06:43:49 +0000 Received: from localhost ([127.0.0.1]:37086 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kE5Rs-000565-Sr for submit@debbugs.gnu.org; Fri, 04 Sep 2020 02:43:49 -0400 Received: from eggs.gnu.org ([209.51.188.92]:45708) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kE5Rr-00055r-Cf for 43183@debbugs.gnu.org; Fri, 04 Sep 2020 02:43:47 -0400 Received: from fencepost.gnu.org ([2001:470:142:3::e]:53798) by eggs.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kE5Rl-0000Jc-V7; Fri, 04 Sep 2020 02:43:41 -0400 Received: from [2a01:e0a:19b:d9a0:9d9d:97cc:d92a:8ac0] (port=59298 helo=cervin) by fencepost.gnu.org with esmtpsa (TLS1.2:RSA_AES_256_CBC_SHA1:256) (Exim 4.82) (envelope-from ) id 1kE5Ri-0000aJ-PZ; Fri, 04 Sep 2020 02:43:41 -0400 From: Mathieu Othacehe References: <20200903150243.27796-1-mjbecze@riseup.net> Date: Fri, 04 Sep 2020 08:43:37 +0200 In-Reply-To: <20200903150243.27796-1-mjbecze@riseup.net> (Martin Becze's message of "Thu, 3 Sep 2020 10:02:43 -0500") Message-ID: <87k0xaqbxi.fsf@gnu.org> User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/27.1 (gnu/linux) MIME-Version: 1.0 Content-Type: text/plain X-Spam-Score: -2.3 (--) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -3.3 (---) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=none; dmarc=none; spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: -1.01 X-TUID: gBnhkmFksUit Hello Martin, Thanks for this patch. > +(define pfds > + (let ((name "pfds") > + (version "0.3")) > + (origin > + (method git-fetch) There's a space/tab indentation mix here and in the other origin declarations. > + (uri (git-reference > + (url "https://github.com/ijp/pfds.git") > + (commit (string-append "v" version)))) This could be useful not only for Loko but also for other scheme implementations. Thus, it would be nice to define it as a proper package rather than a simple origin. > + (sha256 (base32 "019jlh3lywy912cfz689c9fxgf4bi5700i9k04g7sl5w5gchj36m")) This is usually wrapped to stay under the 78 columns limit. > + (file-name (git-file-name name version)))) > + (build-system gnu-build-system) > + (arguments > + `(#:tests? #f You should add a comment explaining why tests are disabled. Thanks, Mathieu