From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mp2 ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by ms11 with LMTPS id EJVkD/cudl/jdgAA0tVLHw (envelope-from ) for ; Thu, 01 Oct 2020 19:33:11 +0000 Received: from aspmx1.migadu.com ([2001:41d0:2:4a6f::]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) by mp2 with LMTPS id MCkeC/cudl/SRgAAB5/wlQ (envelope-from ) for ; Thu, 01 Oct 2020 19:33:11 +0000 Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by aspmx1.migadu.com (Postfix) with ESMTPS id 9C9F5940222 for ; Thu, 1 Oct 2020 19:33:10 +0000 (UTC) Received: from localhost ([::1]:44988 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1kO4KC-0001PK-KZ for larch@yhetil.org; Thu, 01 Oct 2020 15:33:08 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34030) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1kO4K6-0001P7-8B for guix-patches@gnu.org; Thu, 01 Oct 2020 15:33:02 -0400 Received: from debbugs.gnu.org ([209.51.188.43]:55114) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.90_1) (envelope-from ) id 1kO4K5-0003gy-VP for guix-patches@gnu.org; Thu, 01 Oct 2020 15:33:01 -0400 Received: from Debian-debbugs by debbugs.gnu.org with local (Exim 4.84_2) (envelope-from ) id 1kO4K5-0005H7-Rr for guix-patches@gnu.org; Thu, 01 Oct 2020 15:33:01 -0400 X-Loop: help-debbugs@gnu.org Subject: [bug#43722] Add emacs-gcmh package Resent-From: Niklas Eklund Original-Sender: "Debbugs-submit" Resent-CC: guix-patches@gnu.org Resent-Date: Thu, 01 Oct 2020 19:33:01 +0000 Resent-Message-ID: Resent-Sender: help-debbugs@gnu.org X-GNU-PR-Message: followup 43722 X-GNU-PR-Package: guix-patches X-GNU-PR-Keywords: To: Nicolas Goaziou Cc: 43722@debbugs.gnu.org Received: via spool by 43722-submit@debbugs.gnu.org id=B43722.160158073220212 (code B ref 43722); Thu, 01 Oct 2020 19:33:01 +0000 Received: (at 43722) by debbugs.gnu.org; 1 Oct 2020 19:32:12 +0000 Received: from localhost ([127.0.0.1]:38427 helo=debbugs.gnu.org) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kO4JI-0005Fv-28 for submit@debbugs.gnu.org; Thu, 01 Oct 2020 15:32:12 -0400 Received: from mout02.posteo.de ([185.67.36.66]:36723) by debbugs.gnu.org with esmtp (Exim 4.84_2) (envelope-from ) id 1kO4JF-0005Fh-C5 for 43722@debbugs.gnu.org; Thu, 01 Oct 2020 15:32:10 -0400 Received: from submission (posteo.de [89.146.220.130]) by mout02.posteo.de (Postfix) with ESMTPS id 0DDB22400FB for <43722@debbugs.gnu.org>; Thu, 1 Oct 2020 21:32:02 +0200 (CEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=posteo.net; s=2017; t=1601580723; bh=wVQWLdJPRei+3NGuUfeyKCMUOrSx6TGlSH1GgnIzI0I=; h=From:To:Cc:Subject:Date:From; b=EKFU10gFmi45iutQ6EAodOyC1nh3uQHUox7mGZh6t6NpSIstJWlsYJr+0yibwNe0T qCY2zNe9Ar1CnYeWc8YADpnQSRQTXkKFndfrxD2whslTH24kuVkCjYs0pDaqPM4Nak 5DIMuNkhtIhp8HaQnLubkXNczMtTkj51zztED+5WzZF21JSqqG5R440IZVN9Z22UzS F7QgwhLW1PkntCc2H4XMFujuGblxrtMyt0LCnbiP+7pA/YYy7L/5GvXbd5n2in3mV2 /7+WOX2cRusEipCGW9zdbYK1Im/7Gv9DVYRjNQZrr7Q3tMZQ90Phkug/U5UixM8/Gu PiInzjmdp2iog== Received: from customer (localhost [127.0.0.1]) by submission (posteo.de) with ESMTPSA id 4C2NYG2g5gz9rxN; Thu, 1 Oct 2020 21:32:02 +0200 (CEST) From: Niklas Eklund In-Reply-To: <87v9fu15z9.fsf@nicolasgoaziou.fr> References: <87sgazgzao.fsf@posteo.net> <87v9fu15z9.fsf@nicolasgoaziou.fr> Date: Thu, 01 Oct 2020 21:32:02 +0200 Message-ID: <87k0w9d9ot.fsf@posteo.net> MIME-Version: 1.0 Content-Type: multipart/mixed; boundary="=-=-=" X-Spam-Score: -0.7 (/) X-BeenThere: debbugs-submit@debbugs.gnu.org X-Mailman-Version: 2.1.18 Precedence: list X-Spam-Score: -1.7 (-) X-BeenThere: guix-patches@gnu.org List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: guix-patches-bounces+larch=yhetil.org@gnu.org Sender: "Guix-patches" X-Scanner: scn0 Authentication-Results: aspmx1.migadu.com; dkim=fail (rsa verify failed) header.d=posteo.net header.s=2017 header.b=EKFU10gF; dmarc=fail reason="SPF not aligned (strict)" header.from=posteo.net (policy=none); spf=pass (aspmx1.migadu.com: domain of guix-patches-bounces@gnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom=guix-patches-bounces@gnu.org X-Spam-Score: 0.09 X-TUID: JRe7/WV2ZmsZ --=-=-= Content-Type: text/plain Nicolas Goaziou writes: > Hello, > > Niklas Eklund writes: > >> * gnu/packages/emacs-xyz.scm (emacs-gcmh): New variable. > > Thank you. > > Some comments follow. > >> +(define-public emacs-gcmh >> + (let ((commit "84c43a4c0b41a595ac6e299fa317d2831813e580") >> + (revision "0")) > > Could you add a comment explaining why we're providing a specific commit > instead of a tagged release? I couldn't find a taged release on gitlab so I picked the most recent commit. Upon looking closer there is not official tag to be found but in the package it says version 0.1. What is the proper way of naming the git version in this case? I changed it in this new patch to 0.0.0. Feel free to change if it doesn't make sense. >> + (package >> + (name "emacs-gcmh") >> + (version (git-version "0.1" revision commit)) >> + (source >> + (origin >> + (method git-fetch) >> + (uri (git-reference >> + (url "https://gitlab.com/koral/gcmh") >> + (commit commit))) >> + (sha256 >> + (base32 "1r3wiqhrzh7wvqy484nl031fd4bn4cpvkv9646s4cjgvnnnv7jz3")) >> + (file-name (git-file-name name version)))) >> + (build-system emacs-build-system) >> + (home-page "https://gitlab.com/koral/gcmh") >> + (synopsis >> + "The GNU Emacs Garbage Collector Magic Hack") > > The string should be moved on the same line as `synopsis'. Also: > > Emacs Garbage Collector Magic Hack > > is enough. > >> + (description >> + "This package enforces a sneaky Garbage Collection strategy to minimize > > I suggest > > ... a sneaky @dfn{garbage collector} (GC) strategy to minimize... > > Could you send an updated patch? Good suggestions, I have addressed them and here is a new patch. --=-=-= Content-Type: text/x-patch Content-Disposition: attachment; filename=v2-0001-gnu-Add-emacs-gcmh.patch Content-Description: Content >From 0feb4bd289c7bab7b82e4d2f37fc7247acda6f6e Mon Sep 17 00:00:00 2001 From: Niklas Eklund Date: Wed, 30 Sep 2020 15:34:36 +0200 Subject: [PATCH v2] gnu: Add emacs-gcmh. * gnu/packages/emacs-xyz.scm (emacs-gcmh): New variable. --- gnu/packages/emacs-xyz.scm | 25 +++++++++++++++++++++++++ 1 file changed, 25 insertions(+) diff --git a/gnu/packages/emacs-xyz.scm b/gnu/packages/emacs-xyz.scm index 13471f77d1..575ee25308 100644 --- a/gnu/packages/emacs-xyz.scm +++ b/gnu/packages/emacs-xyz.scm @@ -1768,6 +1768,31 @@ always indented. It reindents after every change, making it more reliable than @code{electric-indent-mode}.") (license license:gpl2+))) +(define-public emacs-gcmh + (let ((commit "84c43a4c0b41a595ac6e299fa317d2831813e580") + (revision "0")) + (package + (name "emacs-gcmh") + (version (git-version "0.0.0" revision commit)) + (source + (origin + (method git-fetch) + (uri (git-reference + (url "https://gitlab.com/koral/gcmh") + (commit commit))) + (sha256 + (base32 "1r3wiqhrzh7wvqy484nl031fd4bn4cpvkv9646s4cjgvnnnv7jz3")) + (file-name (git-file-name name version)))) + (build-system emacs-build-system) + (home-page "https://gitlab.com/koral/gcmh") + (synopsis "Emacs Garbage Collector Magic Hack") + (description + "This package enforces a sneaky @dfn{garbage collector} (GC) strategy +to minimize GC interference with the activity. During normal use a high GC +threshold is set. When idling GC is immediately triggered and a low threshold +is set.") + (license license:gpl3+)))) + (define-public emacs-ctrlf (package (name "emacs-ctrlf") -- 2.28.0 --=-=-=--