Nicolas Goaziou <mail@nicolasgoaziou.fr> writes:

> Hello,
>
> Niklas Eklund <niklas.eklund@posteo.net> writes:
>
>> * gnu/packages/emacs-xyz.scm (emacs-gcmh): New variable.
>
> Thank you.
>
> Some comments follow.
>
>> +(define-public emacs-gcmh
>> +  (let ((commit "84c43a4c0b41a595ac6e299fa317d2831813e580")
>> +        (revision "0"))
>
> Could you add a comment explaining why we're providing a specific commit
> instead of a tagged release?

I couldn't find a taged release on gitlab so I picked the most recent
commit. Upon looking closer there is not official tag to be found but in
the package it says version 0.1. What is the proper way of naming the
git version in this case? I changed it in this new patch to 0.0.0. Feel
free to change if it doesn't make sense.

>> +    (package
>> +      (name "emacs-gcmh")
>> +      (version (git-version "0.1" revision commit))
>> +      (source
>> +       (origin
>> +         (method git-fetch)
>> +         (uri (git-reference
>> +               (url "https://gitlab.com/koral/gcmh")
>> +               (commit commit)))
>> +         (sha256
>> +          (base32 "1r3wiqhrzh7wvqy484nl031fd4bn4cpvkv9646s4cjgvnnnv7jz3"))
>> +         (file-name (git-file-name name version))))
>> +      (build-system emacs-build-system)
>> +      (home-page "https://gitlab.com/koral/gcmh")
>> +      (synopsis
>> +       "The GNU Emacs Garbage Collector Magic Hack")
>
> The string should be moved on the same line as `synopsis'. Also:
>
>   Emacs Garbage Collector Magic Hack
>
> is enough.
>
>> +      (description
>> +       "This package enforces a sneaky Garbage Collection strategy to minimize
>
> I suggest 
>
>   ... a sneaky @dfn{garbage collector} (GC) strategy to minimize...
>
> Could you send an updated patch?

Good suggestions, I have addressed them and here is a new patch.