From: "Ludovic Courtès" <ludo@gnu.org>
To: Greg Hogan <code@greghogan.com>
Cc: 43620-done@debbugs.gnu.org
Subject: bug#43620: [PATCH 2/2] gnu: Add folly.
Date: Sat, 10 Oct 2020 22:59:50 +0200 [thread overview]
Message-ID: <87k0vxhk55.fsf@gnu.org> (raw)
In-Reply-To: <CA+3U0Z=Sf_odimfCh7jT3sRM2y4EtGEXPqH=Sb27vT21vMt_LA@mail.gmail.com> (Greg Hogan's message of "Sat, 10 Oct 2020 12:50:15 -0400")
[-- Attachment #1: Type: text/plain, Size: 348 bytes --]
Greg Hogan <code@greghogan.com> skribis:
>>From 8e3df10ad8aa791e34a5a5abcaabe0438f7b063a Mon Sep 17 00:00:00 2001
> From: Greg Hogan <code@greghogan.com>
> Date: Tue, 22 Sep 2020 15:22:32 +0000
> Subject: [PATCH] gnu: Add folly.
>
> * gnu/packages/cpp.scm (folly): New variable.
Applied with the changes below.
Thanks!
Ludo’.
[-- Warning: decoded text below may be mangled, UTF-8 assumed --]
[-- Attachment #2: Type: text/x-patch, Size: 1272 bytes --]
diff --git a/gnu/packages/cpp.scm b/gnu/packages/cpp.scm
index 7f52dc3772..da3ea8ec55 100644
--- a/gnu/packages/cpp.scm
+++ b/gnu/packages/cpp.scm
@@ -697,8 +697,7 @@ standard GNU style syntax for options.")
(build-system cmake-build-system)
(arguments
'(;; Tests must be explicitly enabled
- ;#:configure-flags
- ;'("-DBUILD_TESTS=ON")))
+ ;;#:configure-flags '("-DBUILD_TESTS=ON")))
;; Leave tests disabled; see https://github.com/facebook/folly/issues/1456
#:tests? #f))
(propagated-inputs
@@ -725,8 +724,8 @@ standard GNU style syntax for options.")
(synopsis "Collection of C++ components complementing the standard library")
(description
"Folly (acronymed loosely after Facebook Open Source Library) is a library
-of C++14 components which complements @code{std} and Boost.")
+of C++14 components that complements @code{std} and Boost.")
(home-page "https://github.com/facebook/folly/wiki")
- ; 32-bit is not supported: https://github.com/facebook/folly/issues/103
- (supported-systems '("aarch64" "x86_64-linux"))
+ ;; 32-bit is not supported: https://github.com/facebook/folly/issues/103
+ (supported-systems '("aarch64-linux" "x86_64-linux"))
(license license:asl2.0)))
prev parent reply other threads:[~2020-10-10 21:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-09-25 18:13 [bug#43620] [PATCH 2/2] gnu: Add folly Greg Hogan
2020-09-29 20:46 ` Ludovic Courtès
2020-10-10 16:50 ` Greg Hogan
2020-10-10 20:59 ` Ludovic Courtès [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
List information: https://guix.gnu.org/
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=87k0vxhk55.fsf@gnu.org \
--to=ludo@gnu.org \
--cc=43620-done@debbugs.gnu.org \
--cc=code@greghogan.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
Code repositories for project(s) associated with this public inbox
https://git.savannah.gnu.org/cgit/guix.git
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for read-only IMAP folder(s) and NNTP newsgroup(s).